Page MenuHomePhabricator
Create Task
Maniphest T364938

CommunityConfiguration edit links appear at unrelated pages
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Go to any of the following pages:

What happens?:

A "View form" link appears in the page navigation (see top-right corner):

image.png (976×2 px, 226 KB)

What should have happened instead?:

For Special:Block, no link is expected. For main namespace pages, the "normal" set of links is expected (Read, Edit, Edit source, View history).

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): eswiki betalabs

Other information (browser name/version, screenshots, etc.): Comes as a regression from T363788: Community Configuration: Edit History.

Note that https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommunityConfiguration/+/1026406 has some code-quality issues, particularly when it comes to i18n.

Details

SubjectRepoBranchLines +/-
Improve navigation link handling in CommunityConfigurationmediawiki/extensions/CommunityConfigurationwmf/1.43.0-wmf.8+34 -34
Improve navigation link handling in CommunityConfigurationmediawiki/extensions/CommunityConfigurationmaster+34 -34
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.May 14 2024, 9:50 PM
Restricted Application edited projects, added Growth-Team; removed Growth-Team (Sprint 14 (Growth Team)). · View Herald TranscriptMay 14 2024, 9:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF triaged this task as High priority.May 14 2024, 9:50 PM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 14 (Growth Team)); removed Growth-Team.
Urbanecm_WMF moved this task from Backlog to Needed before pilot release on the MediaWiki-extensions-CommunityConfiguration board.
Urbanecm_WMF added a parent task: T363788: Community Configuration: Edit History.
Urbanecm_WMF mentioned this in T363788: Community Configuration: Edit History.
Cyndymediawiksim claimed this task.May 15 2024, 5:24 AM
Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (Sprint 14 (Growth Team)) board.
gerritbot added a comment.May 15 2024, 6:24 AM

Change #1031756 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/CommunityConfiguration@master] Improve navigation link handling in CommunityConfiguration

https://gerrit.wikimedia.org/r/1031756

gerritbot added a project: Patch-For-Review.May 15 2024, 6:24 AM
Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Sprint 14 (Growth Team)) board.May 15 2024, 6:41 AM
Tacsipacsi subscribed.May 15 2024, 8:05 AM
Cyndymediawiksim moved this task from Code Review to Doing on the Growth-Team (Sprint 14 (Growth Team)) board.May 23 2024, 7:43 AM
Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Sprint 14 (Growth Team)) board.May 23 2024, 12:53 PM
KStoller-WMF moved this task from Sprint 14 (Growth Team) to Sprint 15 (Growth Team) on the Growth-Team board.May 28 2024, 10:14 PM
KStoller-WMF edited projects, added Growth-Team (Sprint 15 (Growth Team)); removed Growth-Team (Sprint 14 (Growth Team)).
Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (Sprint 15 (Growth Team)) board.May 29 2024, 7:50 AM
Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Sprint 15 (Growth Team)) board.May 29 2024, 8:40 AM
Sgs moved this task from Code Review to QA on the Growth-Team (Sprint 15 (Growth Team)) board.Jun 5 2024, 3:48 PM
gerritbot added a comment.Jun 5 2024, 3:50 PM

Change #1038843 had a related patch set uploaded (by Sergio Gimeno; author: Cyndywikime):

[mediawiki/extensions/CommunityConfiguration@wmf/1.43.0-wmf.8] Improve navigation link handling in CommunityConfiguration

https://gerrit.wikimedia.org/r/1038843

gerritbot added a comment.Jun 5 2024, 3:51 PM

Change #1031756 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Improve navigation link handling in CommunityConfiguration

https://gerrit.wikimedia.org/r/1031756

Cyndymediawiksim mentioned this in rECOM29441db5ba27: Improve navigation link handling in CommunityConfiguration.Jun 5 2024, 3:51 PM
Etonkovidova closed this task as Resolved.Jun 5 2024, 6:55 PM
gerritbot added a comment.Jun 6 2024, 8:18 PM

Change #1038843 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@wmf/1.43.0-wmf.8] Improve navigation link handling in CommunityConfiguration

https://gerrit.wikimedia.org/r/1038843

Urbanecm_WMF mentioned this in rECOM5b976f93164e: Improve navigation link handling in CommunityConfiguration.Jun 6 2024, 8:19 PM
Stashbot mentioned this in T366549: Rename namespace "Wiktionary" to "Wikikamus" in ms.wiktionary.org.Jun 6 2024, 8:22 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-06T20:22:12Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:1039729|[mswiktionary] Rename namespace "Wiktionary" to "Wikikamus" (T366549)]], [[gerrit:1038843|Improve navigation link handling in CommunityConfiguration (T364938 T365504 T360954)]], [[gerrit:1038714|Drop logging level for unsupported providers to DEBUG (T366519 T360954)]]

Stashbot mentioned this in T365504: Disable Actions for Special:CommunityConfiguration edit form.Jun 6 2024, 8:22 PM
Stashbot mentioned this in T360954: Deploy CommunityConfiguration to testwiki.
Stashbot mentioned this in T366519: CommunityConfiguration: WikiPageConfigReader should not log WARNINGs when encountering a provider it does not support.
Stashbot added a comment.Jun 6 2024, 8:24 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-06T20:24:30Z] <urbanecm@deploy1002> urbanecm and sgimeno and gergesshamon: Backport for [[gerrit:1039729|[mswiktionary] Rename namespace "Wiktionary" to "Wikikamus" (T366549)]], [[gerrit:1038843|Improve navigation link handling in CommunityConfiguration (T364938 T365504 T360954)]], [[gerrit:1038714|Drop logging level for unsupported providers to DEBUG (T366519 T360954)]] synced to the testservers (https://wikitech.wikimedia.org/wiki

Maintenance_bot removed a project: Patch-For-Review.Jun 6 2024, 8:31 PM
Stashbot added a comment.Jun 6 2024, 8:41 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-06T20:41:54Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1039729|[mswiktionary] Rename namespace "Wiktionary" to "Wikikamus" (T366549)]], [[gerrit:1038843|Improve navigation link handling in CommunityConfiguration (T364938 T365504 T360954)]], [[gerrit:1038714|Drop logging level for unsupported providers to DEBUG (T366519 T360954)]] (duration: 19m 42s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits