Page MenuHomePhabricator
Create Task
Maniphest T365408

[Subtask[Regression] Vector 2022 uses wrong font size on talk pages
Closed, ResolvedPublic
Actions

Assigned To
Jdlrobson
Authored By
matmarex
May 20 2024, 11:44 PM
Tags
Referenced Files
F54654734: 2024-05-29_11-42-59.png
May 29 2024, 6:45 PM
F54316720: screenshot 376.png
May 25 2024, 1:43 AM
F54316719: screenshot 375.png
May 25 2024, 1:43 AM
F54134588: image.png
May 22 2024, 3:06 PM
F54131581: Screenshot 2024-05-22 at 9.23.46 AM.png
May 22 2024, 1:28 PM
F54000994: image.png
May 20 2024, 11:44 PM
Subscribers
Aklapper
Edtadros
GMikesell-WMF
Jdlrobson
Jdrewniak
matmarex
ovasileva

Description

To reproduce, visit https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page

The sidebar appearance menu is disabled, and it says "This page always uses small font size". However, the page is not using the "Small" font size. It almost looks like the "Standard" size, but with wrong line-height.

image.png (2×3 px, 796 KB)

Requirement

Ensure that the "small" font size is correctly applied on talk pages in the Vector 2022 skin.

BDD

Feature: Correct Font Size on Talk Pages in Vector 2022

  Scenario: Apply "small" font size on talk pages
    Given the user is viewing a talk page in the Vector 2022 skin
    When the page loads
    Then the "small" font size should be correctly applied

Test Steps

Test Case 1: Apply "Small" Font Size on Talk Pages

  1. Visit this talk page on the beta environment using the Vector 2022 skin.
  2. Ensure that the "small" font size is applied to the text.
  3. AC1: Confirm that the font size matches the "small" specification (14px / 22px).

QA Results - Beta

ACStatusDetails
1✅T365408#9831985

QA Results - PROD

ACStatusDetails
1✅T365408#9843629

Details

SubjectRepoBranchLines +/-
Small font size is not applying to excluded pagesmediawiki/skins/Vectorwmf/1.43.0-wmf.6+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.May 20 2024, 11:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2024, 11:44 PM
Jdlrobson mentioned this in T364887: It should be possible to set a different default font size on different pages for Vector 2022.May 21 2024, 8:01 PM
Jdlrobson subscribed.

Thanks for the bug report. Looks like something was missed in review: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1030563/7#message-bfd89eac064dfe38e558e36cdd87531f4f5eee3b so since that is still open, I'll make this a subtask.

Jdlrobson renamed this task from Vector 2022 uses wrong font size on talk pages to [Regression] Vector 2022 uses wrong font size on talk pages.May 21 2024, 8:02 PM
Jdlrobson renamed this task from [Regression] Vector 2022 uses wrong font size on talk pages to [Subtask[Regression] Vector 2022 uses wrong font size on talk pages.
Jdlrobson added a project: Web-Team-Backlog (FY2023-24 Q4 Sprint 4).
Jdlrobson added a parent task: T364887: It should be possible to set a different default font size on different pages for Vector 2022.
Jdlrobson assigned this task to ovasileva.EditedMay 22 2024, 12:56 AM

This is a blocker for deployment. It made need to be backported since it will impact anonymous users on Polish Wikipedia?

ovasileva triaged this task as High priority.May 22 2024, 6:19 AM
Jdrewniak subscribed.May 22 2024, 1:28 PM

I'm not sure I see an error here. Currently the default font-size on beta is small. The font-size values from the spec in T359030 are (computed font-size/line-height):
small = 14px / 22px
standard = 16px / 25.6px
large = 20px / 30px

The font-size on that talk page on beta is 14px / 22px, which corresponds to "small", and the option is disabled, as expected.

Screenshot 2024-05-22 at 9.23.46 AM.png (535×1 px, 309 KB)

Jdrewniak added a comment.May 22 2024, 1:31 PM

Disregard that last comment, that screenshot was taken after the fix was merged, so I was just looking at the fixed/expected result.

matmarex added a comment.May 22 2024, 3:06 PM

Yes, it's fixed now for me too.

image.png (2×3 px, 708 KB)

Looks like the fix was https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1034574.

matmarex added a parent task: T361400: 1.43.0-wmf.6 deployment blockers.May 22 2024, 3:08 PM
In T365408#9819470, @Jdlrobson wrote:

This is a blocker for deployment. It made need to be backported since it will impact anonymous users on Polish Wikipedia?

Marking as release blocker per this comment.

Jdlrobson moved this task from Needs analysis to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 22 2024, 6:51 PM
gerritbot added a comment.May 22 2024, 6:51 PM

Change #1034992 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.43.0-wmf.6] Small font size is not applying to excluded pages

https://gerrit.wikimedia.org/r/1034992

gerritbot added a project: Patch-For-Review.May 22 2024, 6:51 PM
Jdlrobson reassigned this task from ovasileva to Jdrewniak.May 22 2024, 6:52 PM
Jdlrobson added a subscriber: ovasileva.
In T365408#9821923, @matmarex wrote:
In T365408#9819470, @Jdlrobson wrote:

This is a blocker for deployment. It made need to be backported since it will impact anonymous users on Polish Wikipedia?

Marking as release blocker per this comment.

Sorry I originally meant a blocker for the release of font size in 2 weeks time, not the train, but after talking to @ovasileva we decided this should be a blocker which Jan will deploy in an hours time.

Jdlrobson raised the priority of this task from High to Unbreak Now!.May 22 2024, 6:52 PM
gerritbot added a comment.May 22 2024, 8:32 PM

Change #1034992 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.6] Small font size is not applying to excluded pages

https://gerrit.wikimedia.org/r/1034992

Stashbot mentioned this in T364015: Exception handling for appearance settings (width) - Vector.May 22 2024, 8:33 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-22T20:33:29Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1034993|Revert "Add exclusion behaviour for "width" option in Appearance menu" (T364015)]], [[gerrit:1034992|Small font size is not applying to excluded pages (T364887 T365408)]]

Stashbot added a comment.May 22 2024, 8:36 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-22T20:36:22Z] <jdrewniak@deploy1002> jdrewniak and jdlrobson: Backport for [[gerrit:1034993|Revert "Add exclusion behaviour for "width" option in Appearance menu" (T364015)]], [[gerrit:1034992|Small font size is not applying to excluded pages (T364887 T365408)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.May 22 2024, 8:50 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-22T20:50:16Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:1034993|Revert "Add exclusion behaviour for "width" option in Appearance menu" (T364015)]], [[gerrit:1034992|Small font size is not applying to excluded pages (T364887 T365408)]] (duration: 16m 46s)

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 22 2024, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2024, 9:30 PM
Jdlrobson lowered the priority of this task from Unbreak Now! to High.May 22 2024, 10:03 PM
Jdlrobson moved this task from Doing to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.
Jdlrobson removed a parent task: T361400: 1.43.0-wmf.6 deployment blockers.
Jdlrobson reassigned this task from Jdrewniak to Edtadros.May 23 2024, 4:56 PM
Jdlrobson moved this task from Incoming to typography/darkmode on the Desktop Improvements (Vector 2022) board.May 24 2024, 9:37 PM
Edtadros updated the task description. (Show Details)May 25 2024, 1:34 AM
Edtadros removed Edtadros as the assignee of this task.May 25 2024, 1:43 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Apply "Small" Font Size on Talk Pages

  1. Visit this talk page on the beta environment using the Vector 2022 skin.
  2. Ensure that the "small" font size is applied to the text.
  3. ✅ AC1: Confirm that the font size matches the "small" specification (14px / 22px).

screenshot 375.png (724×1 px, 226 KB)

screenshot 376.png (856×1 px, 327 KB)

Edtadros updated the task description. (Show Details)May 25 2024, 1:49 AM
Edtadros updated the task description. (Show Details)
Edtadros mentioned this in T365385: Verify 1.43.0-wmf.6 deployment.May 28 2024, 10:05 PM
GMikesell-WMF subscribed.May 29 2024, 6:45 PM

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 125
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Apply "Small" Font Size on Talk Pages

  1. Visit this talk page on the beta environment using the Vector 2022 skin.
  2. Ensure that the "small" font size is applied to the text.
  3. ✅ AC1: Confirm that the font size matches the "small" specification (14px / 22px).

2024-05-29_11-42-59.png (1×3 px, 633 KB)

GMikesell-WMF updated the task description. (Show Details)May 29 2024, 6:46 PM
GMikesell-WMF added a project: Verified.May 30 2024, 9:22 PM
Jdlrobson closed this task as Resolved.May 31 2024, 1:15 AM
Jdlrobson claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits