Page MenuHomePhabricator

[REPO][SW] Ensure api-testing MediaWiki extension tests pass when temp account feature flag is enabled
Closed, ResolvedPublic

Description

Acceptance criteria:

  • All api-testing tests for extensions/skins pass when temp accounts are enabled

Status (23 May 2024):

111:24:08 > wikibase-rest-api-definition@0.1.0 api-testing:e2e
211:24:08 > npm run mocha -- --recursive tests/mocha/api-testing
311:24:08
411:24:09
511:24:09 > wikibase-rest-api-definition@0.1.0 mocha
611:24:09 > mocha --timeout 0 --inline-diffs --recursive tests/mocha/api-testing
711:24:09
811:24:10
911:24:10
1011:24:10 addItemAliasesInLanguage
1111:24:12 ✔ responds 404 if the item does not exist (286ms)
1211:24:13 ✔ responds 409 if the item is a redirect (455ms)
1311:24:13 20x success response
1411:24:13 ✔ can create a new list of aliases with edit metadata omitted (223ms)
1511:24:13 ✔ can add to an existing list of aliases with edit metadata omitted (198ms)
1611:24:15 ✔ can add aliases with edit metadata provided (1802ms)
1711:24:15 400 error response
1811:24:15 ✔ invalid item id (84ms)
1911:24:15 ✔ should have sitelink change dispatched (90ms)
2011:24:15 ✔ invalid language code (97ms)
2111:24:15 ✔ alias is empty (48ms)
2211:24:15 ✔ should have sitelink usage (69ms)
2311:24:15 ✔ alias list is empty (41ms)
2411:24:15 ✔ should have wikibase_item page prop (62ms)
2511:24:15 item deletion
2611:24:15 ✔ alias too long (68ms)
2711:24:15 ✔ alias contains invalid characters (42ms)
2811:24:15 ✔ duplicate input aliases (63ms)
2911:24:15 ✔ input alias already exist (88ms)
3011:24:15
3111:24:15 addItemStatement
3211:24:17 ✔ should dispatch item deletion (110ms)
3311:24:17 201 success response
3411:24:17 ✔ should not have sitelink usage (49ms)
3511:24:17 ✔ should not have wikibase_item page prop
3611:24:17
3711:24:17 data value normalization
3811:24:17 ✔ can add a statement to an item with edit metadata omitted (311ms)
3911:24:18 ✔ can add a statement to an item with edit metadata provided (342ms)
4011:24:18 ✔ can add a statement with a globecoordinate value in new format (443ms)
4111:24:18 ✔ can add a statement with a time value in new format (420ms)
4211:24:19 ✔ can add a statement with a wikibase-entityid value in new format (356ms)
4311:24:19 400 error response
4411:24:19 ✔ invalid Item ID (39ms)
4511:24:19 ✔ comment too long (54ms)
4611:24:19 ✔ invalid edit tag (47ms)
4711:24:19 ✔ invalid bot flag (58ms)
4811:24:19 ✔ invalid comment (53ms)
4911:24:19 ✔ invalid statement field (82ms)
5011:24:19 ✔ missing statement field
5111:24:19 404 error response
5211:24:19 ✔ normalize Commons media (273ms)
5311:24:19 ✔ item not found (85ms)
5411:24:19 409 error response
5511:24:19 ✔ normalize Unicode string (218ms)
5611:24:19
5711:24:19 Label Rendering in Comments
5811:24:20 ✔ item is a redirect (489ms)
5911:24:20
6011:24:20 addPropertyAliasesInLanguage
6111:24:21 ✔ responds 404 if the property does not exist (90ms)
6211:24:21 20x success response
6311:24:21 1) "before all" hook: create string property for "renders entity labels in parsed edit summaries in API requests"
6411:24:21
6511:24:21 Lua Wikibase integration
6611:24:21 ✔ can add to an existing list of aliases with edit metadata omitted (221ms)
6711:24:22 ✔ can add aliases with edit metadata provided (332ms)
6811:24:22 ✔ can create a new list of aliases with edit metadata omitted (231ms)
6911:24:22 400 error response
7011:24:22 ✔ invalid property id (73ms)
7111:24:22 ✔ invalid language code (65ms)
7211:24:22 ✔ alias is empty (82ms)
7311:24:22 ✔ alias list is empty (73ms)
7411:24:22 ✔ alias too long (80ms)
7511:24:22 ✔ alias contains invalid characters (73ms)
7611:24:22 ✔ duplicate input aliases (80ms)
7711:24:23 ✔ input alias already exist (65ms)
7811:24:23
7911:24:23 addPropertyStatement
8011:24:24 201 success response
8111:24:24 ✔ can add a statement to a property with edit metadata omitted (277ms)
8211:24:24 ✔ can add a statement to a property with edit metadata (202ms)
8311:24:25 ✔ can add a statement with a globecoordinate value in new format (477ms)
8411:24:25 ✔ can add a statement with a time value in new format (516ms)
8511:24:26 ✔ can add a statement with a wikibase-entityid value in new format (564ms)
8611:24:26 400 error response
8711:24:26 ✔ invalid request data (72ms)
8811:24:26 ✔ invalid property id (45ms)
8911:24:26 ✔ comment too long (70ms)
9011:24:26 ✔ invalid edit tag (64ms)
9111:24:26 ✔ invalid statement field (92ms)
9211:24:26 ✔ missing statement field (70ms)
9311:24:26 404 error response
9411:24:26 ✔ property not found (83ms)
9511:24:26
9611:24:26 Auth
9711:24:27 ✔ getLabel can be invoked correctly (622ms)
9811:24:27 ✔ getLabel returns the label of the redirect target for a redirected item (447ms)
9911:24:28 ✔ getLabel can be invoked correctly with strange uselang query param (851ms)
10011:24:28 ✔ getLabelByLang can be invoked correctly (549ms)
10111:24:29 ✔ reassigning entity ID has no impact on usage tracking (767ms)
10211:24:30 Authentication
10311:24:30 addItemStatement
10411:24:30 ✔ getLabelByLang returns the label of the redirect target for a redirected item (487ms)
10511:24:30 ✔ has an X-Authenticated-User header with the logged in user (178ms)
10611:24:30 OAuth
10711:24:30 - responds with an error given an invalid bearer token
10811:24:30 replaceItemStatement
10911:24:30 ✔ has an X-Authenticated-User header with the logged in user (191ms)
11011:24:30 OAuth
11111:24:30 - responds with an error given an invalid bearer token
11211:24:30 replaceStatement
11311:24:30 ✔ has an X-Authenticated-User header with the logged in user (186ms)
11411:24:30 OAuth
11511:24:30 - responds with an error given an invalid bearer token
11611:24:30 deleteItemStatement
11711:24:30 ✔ getEntity_claims can be invoked correctly (519ms)
11811:24:30 ✔ has an X-Authenticated-User header with the logged in user (123ms)
11911:24:31 ✔ getEntity_claims can be invoked not yet existing property (784ms)
12011:24:31 OAuth
12111:24:31 - responds with an error given an invalid bearer token
12211:24:31 deleteStatement
12311:24:31 ✔ has an X-Authenticated-User header with the logged in user (196ms)
12411:24:32 ✔ getEntity_aliases can be invoked correctly (641ms)
12511:24:32 ✔ getEntity_labels can be invoked correctly (524ms)
12611:24:32 OAuth
12711:24:32 - responds with an error given an invalid bearer token
12811:24:32 patchItemStatement
12911:24:33 ✔ has an X-Authenticated-User header with the logged in user (152ms)
13011:24:33 OAuth
13111:24:33 - responds with an error given an invalid bearer token
13211:24:33 patchStatement
13311:24:33 ✔ has an X-Authenticated-User header with the logged in user (170ms)
13411:24:33 OAuth
13511:24:33 - responds with an error given an invalid bearer token
13611:24:33 replaceItemLabel
13711:24:33 ✔ has an X-Authenticated-User header with the logged in user (301ms)
13811:24:33 OAuth
13911:24:33 - responds with an error given an invalid bearer token
14011:24:33 replaceItemDescription
14111:24:33 ✔ getDescription can be invoked correctly (956ms)
14211:24:33 ✔ has an X-Authenticated-User header with the logged in user (190ms)
14311:24:33 OAuth
14411:24:33 - responds with an error given an invalid bearer token
14511:24:33 setSitelink
14611:24:34 ✔ has an X-Authenticated-User header with the logged in user (280ms)
14711:24:34 ✔ formatValue can be invoked correctly (997ms)
14811:24:34 OAuth
14911:24:34 - responds with an error given an invalid bearer token
15011:24:34 patchSitelinks
15111:24:34 ✔ has an X-Authenticated-User header with the logged in user (210ms)
15211:24:35 ✔ formatValue uses the label of the redirect target for a redirected item (570ms)
15311:24:35 ensure resilience of label and description usage tracking => T287704
15411:24:35 ✔ gets the empty label with nil as language and doesnt break addLabelUsage (390ms)
15511:24:35 OAuth
15611:24:35 - responds with an error given an invalid bearer token
15711:24:35 patchItemLabels
15811:24:35 ✔ gets the empty label with an object as language and doesnt break addLabelUsage (368ms)
15911:24:36 ✔ has an X-Authenticated-User header with the logged in user (196ms)
16011:24:36 OAuth
16111:24:36 - responds with an error given an invalid bearer token
16211:24:36 patchItemDescriptions
16311:24:36 ✔ has an X-Authenticated-User header with the logged in user (138ms)
16411:24:36 OAuth
16511:24:36 - responds with an error given an invalid bearer token
16611:24:36 patchItemAliases
16711:24:36 ✔ has an X-Authenticated-User header with the logged in user (168ms)
16811:24:36 OAuth
16911:24:36 - responds with an error given an invalid bearer token
17011:24:36 addItemAliasesInLanguage
17111:24:36 ✔ has an X-Authenticated-User header with the logged in user (133ms)
17211:24:36 OAuth
17311:24:36 - responds with an error given an invalid bearer token
17411:24:36 deleteItemLabel
17511:24:36 ✔ has an X-Authenticated-User header with the logged in user (172ms)
17611:24:36 ✔ gets the empty label with an integer as language and doesnt break addLabelUsage (812ms)
17711:24:37 ✔ gets the empty label with an invalid language and doesnt break addLabelUsage (625ms)
17811:24:37 OAuth
17911:24:37 - responds with an error given an invalid bearer token
18011:24:37 deleteItemDescription
18111:24:37 ✔ has an X-Authenticated-User header with the logged in user (127ms)
18211:24:38 ✔ gets the empty description with nil as language and doesnt break addDescriptionUsage (768ms)
18311:24:38 OAuth
18411:24:38 - responds with an error given an invalid bearer token
18511:24:38 deleteSitelink
18611:24:38 ✔ has an X-Authenticated-User header with the logged in user (163ms)
18711:24:38 ✔ gets the empty description with an object as language and doesnt break addDescriptionUsage (782ms)
18811:24:39 OAuth
18911:24:39 - responds with an error given an invalid bearer token
19011:24:39 patchPropertyLabels
19111:24:39 ✔ has an X-Authenticated-User header with the logged in user (154ms)
19211:24:39 OAuth
19311:24:39 - responds with an error given an invalid bearer token
19411:24:39 patchPropertyDescriptions
19511:24:39 ✔ has an X-Authenticated-User header with the logged in user (196ms)
19611:24:39 OAuth
19711:24:39 - responds with an error given an invalid bearer token
19811:24:39 patchPropertyAliases
19911:24:39 ✔ has an X-Authenticated-User header with the logged in user (160ms)
20011:24:39 OAuth
20111:24:39 - responds with an error given an invalid bearer token
20211:24:39 addPropertyAliasesInLanguage
20311:24:39 ✔ has an X-Authenticated-User header with the logged in user (116ms)
20411:24:39 OAuth
20511:24:39 - responds with an error given an invalid bearer token
20611:24:39 addPropertyStatement
20711:24:39 ✔ gets the empty description with an integer as language and doesnt break addDescriptionUsage (760ms)
20811:24:39 ✔ has an X-Authenticated-User header with the logged in user (128ms)
20911:24:39 OAuth
21011:24:39 - responds with an error given an invalid bearer token
21111:24:39 replacePropertyStatement
21211:24:39 ✔ has an X-Authenticated-User header with the logged in user (102ms)
21311:24:39 OAuth
21411:24:39 - responds with an error given an invalid bearer token
21511:24:39 replaceStatement
21611:24:39 ✔ has an X-Authenticated-User header with the logged in user (96ms)
21711:24:39 OAuth
21811:24:39 - responds with an error given an invalid bearer token
21911:24:39 patchPropertyStatement
22011:24:40 ✔ has an X-Authenticated-User header with the logged in user (137ms)
22111:24:40 OAuth
22211:24:40 - responds with an error given an invalid bearer token
22311:24:40 deletePropertyStatement
22411:24:40 ✔ gets the empty description with an invalid language and doesnt break addDescriptionUsage (465ms)
22511:24:40
22611:24:40 namespaces
22711:24:40 ✔ has an X-Authenticated-User header with the logged in user (163ms)
22811:24:40 OAuth
22911:24:40 - responds with an error given an invalid bearer token
23011:24:40 deleteStatement
23111:24:40 ✔ has an X-Authenticated-User header with the logged in user (181ms)
23211:24:40 OAuth
23311:24:40 - responds with an error given an invalid bearer token
23411:24:40 replacePropertyLabel
23511:24:41 ✔ has an X-Authenticated-User header with the logged in user (142ms)
23611:24:41 OAuth
23711:24:41 - responds with an error given an invalid bearer token
23811:24:41 replacePropertyDescription
23911:24:41 ✔ has an X-Authenticated-User header with the logged in user (129ms)
24011:24:41 OAuth
24111:24:41 - responds with an error given an invalid bearer token
24211:24:41 deletePropertyLabel
24311:24:41 ✔ has an X-Authenticated-User header with the logged in user (128ms)
24411:24:41 OAuth
24511:24:41 - responds with an error given an invalid bearer token
24611:24:41 deletePropertyDescription
24711:24:41 ✔ has an X-Authenticated-User header with the logged in user (147ms)
24811:24:41 ✔ 120 has defaultcontentmodel wikibase-item
24911:24:41 ✔ 122 has defaultcontentmodel wikibase-property
25011:24:41
25111:24:41 sitelink redirect behavior with badges
25211:24:41 OAuth
25311:24:41 - responds with an error given an invalid bearer token
25411:24:41 patchProperty
25511:24:42 ✔ has an X-Authenticated-User header with the logged in user (127ms)
25611:24:42 OAuth
25711:24:42 - responds with an error given an invalid bearer token
25811:24:42 getItemStatements
25911:24:42 ✔ has an X-Authenticated-User header with the logged in user (50ms)
26011:24:42 OAuth
26111:24:42 - responds with an error given an invalid bearer token
26211:24:42 getItemStatement
26311:24:42 ✔ has an X-Authenticated-User header with the logged in user (47ms)
26411:24:42 OAuth
26511:24:42 - responds with an error given an invalid bearer token
26611:24:42 getItem
26711:24:42 ✔ has an X-Authenticated-User header with the logged in user (49ms)
26811:24:42 OAuth
26911:24:42 - responds with an error given an invalid bearer token
27011:24:42 getItemAliasesInLanguage
27111:24:42 ✔ has an X-Authenticated-User header with the logged in user (51ms)
27211:24:42 OAuth
27311:24:42 - responds with an error given an invalid bearer token
27411:24:42 getItemAliases
27511:24:42 ✔ has an X-Authenticated-User header with the logged in user (49ms)
27611:24:42 OAuth
27711:24:42 - responds with an error given an invalid bearer token
27811:24:42 getItemDescription
27911:24:42 ✔ has an X-Authenticated-User header with the logged in user (44ms)
28011:24:42 OAuth
28111:24:42 - responds with an error given an invalid bearer token
28211:24:42 getItemDescriptions
28311:24:42 ✔ has an X-Authenticated-User header with the logged in user (51ms)
28411:24:42 OAuth
28511:24:42 - responds with an error given an invalid bearer token
28611:24:42 getItemLabel
28711:24:42 ✔ has an X-Authenticated-User header with the logged in user (42ms)
28811:24:42 OAuth
28911:24:42 - responds with an error given an invalid bearer token
29011:24:42 getItemLabels
29111:24:42 ✔ has an X-Authenticated-User header with the logged in user (41ms)
29211:24:42 OAuth
29311:24:42 - responds with an error given an invalid bearer token
29411:24:42 getStatement
29511:24:42 ✔ has an X-Authenticated-User header with the logged in user
29611:24:42 OAuth
29711:24:42 - responds with an error given an invalid bearer token
29811:24:42 getSitelinks
29911:24:42 ✔ has an X-Authenticated-User header with the logged in user (48ms)
30011:24:42 OAuth
30111:24:42 - responds with an error given an invalid bearer token
30211:24:42 getSitelink
30311:24:42 ✔ has an X-Authenticated-User header with the logged in user (43ms)
30411:24:42 OAuth
30511:24:42 - responds with an error given an invalid bearer token
30611:24:42 getProperty
30711:24:42 ✔ has an X-Authenticated-User header with the logged in user (45ms)
30811:24:42 OAuth
30911:24:42 - responds with an error given an invalid bearer token
31011:24:42 getPropertyLabel
31111:24:42 ✔ has an X-Authenticated-User header with the logged in user (48ms)
31211:24:42 OAuth
31311:24:42 - responds with an error given an invalid bearer token
31411:24:42 getPropertyLabels
31511:24:42 ✔ has an X-Authenticated-User header with the logged in user (55ms)
31611:24:42 OAuth
31711:24:42 - responds with an error given an invalid bearer token
31811:24:42 getPropertyDescriptions
31911:24:42 ✔ has an X-Authenticated-User header with the logged in user (65ms)
32011:24:42 OAuth
32111:24:42 - responds with an error given an invalid bearer token
32211:24:42 getPropertyDescription
32311:24:42 ✔ has an X-Authenticated-User header with the logged in user
32411:24:42 OAuth
32511:24:42 - responds with an error given an invalid bearer token
32611:24:42 getPropertyAliases
32711:24:42 ✔ has an X-Authenticated-User header with the logged in user (63ms)
32811:24:42 OAuth
32911:24:42 - responds with an error given an invalid bearer token
33011:24:42 getPropertyAliasesInLanguage
33111:24:42 ✔ has an X-Authenticated-User header with the logged in user (49ms)
33211:24:42 OAuth
33311:24:42 - responds with an error given an invalid bearer token
33411:24:42 getPropertyStatements
33511:24:42 ✔ has an X-Authenticated-User header with the logged in user (40ms)
33611:24:42 OAuth
33711:24:42 - responds with an error given an invalid bearer token
33811:24:42 getStatement
33911:24:43 ✔ has an X-Authenticated-User header with the logged in user (43ms)
34011:24:43 OAuth
34111:24:43 - responds with an error given an invalid bearer token
34211:24:43 getPropertyStatement
34311:24:43 ✔ has an X-Authenticated-User header with the logged in user (56ms)
34411:24:43 OAuth
34511:24:43 - responds with an error given an invalid bearer token
34611:24:43 addItem
34711:24:43 ✔ has an X-Authenticated-User header with the logged in user (127ms)
34811:24:43 OAuth
34911:24:43 - responds with an error given an invalid bearer token
35011:24:43 Authorization
35111:24:43 addItemStatement
35211:24:43 ✔ Unauthorized bot edit
35311:24:43 replaceItemStatement
35411:24:43 ✔ Unauthorized bot edit
35511:24:43 replaceStatement
35611:24:43 ✔ Unauthorized bot edit
35711:24:43 deleteItemStatement
35811:24:43 ✔ Unauthorized bot edit
35911:24:44 deleteStatement
36011:24:44 ✔ Unauthorized bot edit
36111:24:45 patchItemStatement
36211:24:45 ✔ Unauthorized bot edit
36311:24:45 patchStatement
36411:24:45 ✔ Unauthorized bot edit
36511:24:45 replaceItemLabel
36611:24:45 ✔ Unauthorized bot edit
36711:24:45 replaceItemDescription
36811:24:45 ✔ Unauthorized bot edit
36911:24:45 setSitelink
37011:24:45 ✔ Unauthorized bot edit (43ms)
37111:24:45 ✔ wbsetsitelink: disallows redirect sitelink without redirect badge (1168ms)
37211:24:46 patchSitelinks
37311:24:46 ✔ Unauthorized bot edit (39ms)
37411:24:46 ✔ wbsetsitelink: allows redirect sitelink with redirect badge (1047ms)
37511:24:47 patchItemLabels
37611:24:47 ✔ Unauthorized bot edit (38ms)
37711:24:47 patchItemDescriptions
37811:24:47 ✔ Unauthorized bot edit
37911:24:47 patchItemAliases
38011:24:47 ✔ Unauthorized bot edit
38111:24:47 addItemAliasesInLanguage
38211:24:47 ✔ Unauthorized bot edit
38311:24:47 deleteItemLabel
38411:24:47 ✔ Unauthorized bot edit
38511:24:48 ✔ wbsetsitelink: allows adding redirect badge to redirect sitelink (1844ms)
38611:24:48 deleteItemDescription
38711:24:48 ✔ Unauthorized bot edit
38811:24:49 deleteSitelink
38911:24:49 ✔ Unauthorized bot edit (44ms)
39011:24:49 ✔ wbsetsitelink: disallows removing redirect badge from redirect sitelink (1268ms)
39111:24:50 patchPropertyLabels
39211:24:50 ✔ Unauthorized bot edit
39311:24:50 patchPropertyDescriptions
39411:24:50 ✔ Unauthorized bot edit (39ms)
39511:24:50 patchPropertyAliases
39611:24:50 ✔ Unauthorized bot edit
39711:24:50 addPropertyAliasesInLanguage
39811:24:50 ✔ Unauthorized bot edit
39911:24:50 addPropertyStatement
40011:24:50 ✔ Unauthorized bot edit
40111:24:50 replacePropertyStatement
40211:24:50 ✔ Unauthorized bot edit
40311:24:50 replaceStatement
40411:24:50 ✔ Unauthorized bot edit (39ms)
40511:24:50 patchPropertyStatement
40611:24:50 ✔ Unauthorized bot edit
40711:24:50 deletePropertyStatement
40811:24:50 ✔ Unauthorized bot edit
40911:24:50 ✔ wbsetsitelink: allows replacing redirect badge with another (947ms)
41011:24:50 deleteStatement
41111:24:50 ✔ Unauthorized bot edit (45ms)
41211:24:50 replacePropertyLabel
41311:24:50 ✔ Unauthorized bot edit (39ms)
41411:24:50 replacePropertyDescription
41511:24:51 ✔ Unauthorized bot edit (42ms)
41611:24:51 deletePropertyLabel
41711:24:51 ✔ Unauthorized bot edit
41811:24:51 deletePropertyDescription
41911:24:51 ✔ Unauthorized bot edit
42011:24:51 patchProperty
42111:24:51 ✔ Unauthorized bot edit (48ms)
42211:24:51 addItem
42311:24:51 ✔ Unauthorized bot edit (41ms)
42411:24:51 addItemStatement
42511:24:51 Blocked user
42611:24:51 ✔ cannot create/edit if blocked
42711:24:51 replaceItemStatement
42811:24:51 Blocked user
42911:24:51 ✔ cannot create/edit if blocked (83ms)
43011:24:51 replaceStatement
43111:24:51 Blocked user
43211:24:52 ✔ cannot create/edit if blocked (54ms)
43311:24:52 deleteItemStatement
43411:24:52 Blocked user
43511:24:52 ✔ cannot create/edit if blocked (48ms)
43611:24:52 ✔ wbsetsitelink: disallows removing redirect badge from redirect sitelink with no title provided (1742ms)
43711:24:53 deleteStatement
43811:24:53 Blocked user
43911:24:53 ✔ cannot create/edit if blocked (80ms)
44011:24:53 ✔ wbeditentity: disallows redirect sitelink without redirect badge (1319ms)
44111:24:54 patchItemStatement
44211:24:54 Blocked user
44311:24:54 ✔ cannot create/edit if blocked (45ms)
44411:24:54 patchStatement
44511:24:54 Blocked user
44611:24:54 ✔ wbeditentity: allows redirect sitelink with redirect badge (951ms)
44711:24:54 ✔ cannot create/edit if blocked (40ms)
44811:24:54 replaceItemLabel
44911:24:54 Blocked user
45011:24:54 ✔ cannot create/edit if blocked (60ms)
45111:24:54 replaceItemDescription
45211:24:54 Blocked user
45311:24:54 ✔ cannot create/edit if blocked (48ms)
45411:24:55 setSitelink
45511:24:55 Blocked user
45611:24:55 ✔ cannot create/edit if blocked (104ms)
45711:24:56 ✔ wbeditentity: allows adding redirect badge to redirect sitelink (1570ms)
45811:24:56 patchSitelinks
45911:24:56 Blocked user
46011:24:56 ✔ cannot create/edit if blocked
46111:24:57 patchItemLabels
46211:24:57 Blocked user
46311:24:57 ✔ cannot create/edit if blocked (90ms)
46411:24:57 patchItemDescriptions
46511:24:57 Blocked user
46611:24:57 ✔ cannot create/edit if blocked (54ms)
46711:24:57 ✔ wbeditentity: disallows removing redirect badge from redirect sitelink (1445ms)
46811:24:57 patchItemAliases
46911:24:57 Blocked user
47011:24:57 ✔ cannot create/edit if blocked (70ms)
47111:24:57 addItemAliasesInLanguage
47211:24:57 Blocked user
47311:24:57 ✔ cannot create/edit if blocked (56ms)
47411:24:58 deleteItemLabel
47511:24:58 Blocked user
47611:24:58 ✔ cannot create/edit if blocked (76ms)
47711:24:58 1) "after each" hook for "cannot create/edit if blocked"
47811:24:58 deleteItemDescription
47911:24:58 Blocked user
48011:24:58 ✔ cannot create/edit if blocked (53ms)
48111:24:58 2) "after each" hook for "cannot create/edit if blocked"
48211:24:58 deleteSitelink
48311:24:58 Blocked user
48411:24:58 ✔ cannot create/edit if blocked (73ms)
48511:24:58 3) "after each" hook for "cannot create/edit if blocked"
48611:24:58 ✔ wbeditentity: allows replacing redirect badge with another (1380ms)
48711:24:58 patchPropertyLabels
48811:24:58 Blocked user
48911:24:59 ✔ cannot create/edit if blocked (65ms)
49011:24:59 patchPropertyDescriptions
49111:24:59 Blocked user
49211:24:59 ✔ cannot create/edit if blocked (62ms)
49311:24:59 patchPropertyAliases
49411:24:59 Blocked user
49511:24:59 ✔ cannot create/edit if blocked (84ms)
49611:24:59 addPropertyAliasesInLanguage
49711:24:59 Blocked user
49811:24:59 ✔ cannot create/edit if blocked (55ms)
49911:25:00 addPropertyStatement
50011:25:00 Blocked user
50111:25:00 ✔ cannot create/edit if blocked (53ms)
50211:25:00 replacePropertyStatement
50311:25:00 Blocked user
50411:25:00 ✔ cannot create/edit if blocked (56ms)
50511:25:00 replaceStatement
50611:25:00 Blocked user
50711:25:00 ✔ wbeditentity: disallows removing redirect badge from redirect sitelink with no title provided (1563ms)
50811:25:00
50911:25:00
51011:25:00 43 passing (52s)
51111:25:00 1 failing
51211:25:00
51311:25:00 1) Label Rendering in Comments
51411:25:00 "before all" hook: create string property for "renders entity labels in parsed edit summaries in API requests":
51511:25:00 AssertionError: User "<anon>": Action "wbeditentity" returned error code "badtoken": Invalid CSRF token.!
51611:25:00 at Client.action (node_modules/api-testing/lib/actionapi.js:123:11)
51711:25:00 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
51811:25:00 at async createProperty (tests/api-testing/LabelRenderingTest.js:61:20)
51911:25:00 at async Context.<anonymous> (tests/api-testing/LabelRenderingTest.js:34:26)
52011:25:00
52111:25:00
52211:25:00
52311:25:00 ✔ cannot create/edit if blocked (59ms)
52411:25:00 ERROR: "api-testing:wikibase" exited with 1.
52511:25:00 INFO:quibble.commands:<<< Finish: Run API-Testing, in 132.213 s

The work here is a mix of:

  1. If using an anonymous user and anonymous token, only make one edit per test. That's because subsequent edits would be done as a temp user. (Alternatively, clear the cached token and re-request it.)
  2. If we are not explicitly testing anonymous editing behavior, consider just using a regular, named user account for the edits
  3. In some cases, business logic needs to be updated.

Business logic changes (like T365673) should be tracked in subtasks.

Extensions with apitests. Check indicates that the extension tests pass (core's currently fail) with temp accounts enabled:

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
kostajh renamed this task from Ensure api-testing MediaWiki extension and skin tests pass when temp account feature flag is enabled to Ensure api-testing MediaWiki extension tests pass when temp account feature flag is enabled.May 23 2024, 9:05 AM
kostajh updated the task description. (Show Details)

Change #1035331 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/CampaignEvents@master] DNM: CI check

https://gerrit.wikimedia.org/r/1035331

Change #1035332 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/EventBus@master] DNM: CI check

https://gerrit.wikimedia.org/r/1035332

Change #1035333 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/FlaggedRevs@master] DNM: CI check

https://gerrit.wikimedia.org/r/1035333

kostajh updated the task description. (Show Details)
kostajh updated the task description. (Show Details)

Change #1035335 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Flow@master] DNM: CI check for temp accounts

https://gerrit.wikimedia.org/r/1035335

Change #1035336 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] DNM: CI check for temp accounts

https://gerrit.wikimedia.org/r/1035336

Change #1035337 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Math@master] DNM: CI check for temp accounts

https://gerrit.wikimedia.org/r/1035337

Change #1035338 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/ReadingLists@master] DNM: CI check for temp accounts

https://gerrit.wikimedia.org/r/1035338

Change #1035339 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/VisualEditor@master] DNM: CI check for temp accounts

https://gerrit.wikimedia.org/r/1035339

Change #1035340 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@master] DNM: CI check for temp accounts

https://gerrit.wikimedia.org/r/1035340

Change #1035342 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/WikibaseManifest@master] DNM: CI check for temp accounts

https://gerrit.wikimedia.org/r/1035342

Change #1035345 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/services/parsoid@master] DNM: CI check for temp accounts

https://gerrit.wikimedia.org/r/1035345

kostajh updated the task description. (Show Details)

Change #1035333 abandoned by Kosta Harlan:

[mediawiki/extensions/FlaggedRevs@master] DNM: CI check

Reason:

https://gerrit.wikimedia.org/r/1035333

Change #1035331 abandoned by Kosta Harlan:

[mediawiki/extensions/CampaignEvents@master] DNM: CI check

Reason:

https://gerrit.wikimedia.org/r/1035331

Change #1035332 abandoned by Kosta Harlan:

[mediawiki/extensions/EventBus@master] DNM: CI check

Reason:

https://gerrit.wikimedia.org/r/1035332

Change #1035335 abandoned by Kosta Harlan:

[mediawiki/extensions/Flow@master] DNM: CI check for temp accounts

Reason:

https://gerrit.wikimedia.org/r/1035335

Change #1035336 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] DNM: CI check for temp accounts

Reason:

https://gerrit.wikimedia.org/r/1035336

Change #1035338 abandoned by Kosta Harlan:

[mediawiki/extensions/ReadingLists@master] DNM: CI check for temp accounts

Reason:

https://gerrit.wikimedia.org/r/1035338

Change #1035339 abandoned by Kosta Harlan:

[mediawiki/extensions/VisualEditor@master] DNM: CI check for temp accounts

Reason:

https://gerrit.wikimedia.org/r/1035339

Change #1035345 abandoned by Kosta Harlan:

[mediawiki/services/parsoid@master] DNM: CI check for temp accounts

Reason:

https://gerrit.wikimedia.org/r/1035345

Change #1035342 abandoned by Kosta Harlan:

[mediawiki/extensions/WikibaseManifest@master] DNM: CI check for temp accounts

Reason:

https://gerrit.wikimedia.org/r/1035342

Change #1035337 abandoned by Kosta Harlan:

[mediawiki/extensions/Math@master] DNM: CI check for temp accounts

Reason:

https://gerrit.wikimedia.org/r/1035337

kostajh updated the task description. (Show Details)

It looks like the only failing api-testing tests in extensions when temp accounts are enabled are in Wikibase. @ArthurTaylor @Lucas_Werkmeister_WMDE, per T326908: Update WMDE Engineering-owned products that may be affected by IP Masking, is this something that WMDE could work on fixing please? Here is a link to the CI patch that demonstrates the errors, see also P62964.

Lucas_Werkmeister_WMDE renamed this task from Ensure api-testing MediaWiki extension tests pass when temp account feature flag is enabled to [REPO][SW] Ensure api-testing MediaWiki extension tests pass when temp account feature flag is enabled.May 23 2024, 12:06 PM

Prio Notes:

Impact AreaAffected
production / end usersno
monitoringno
development effortsyes
onboarding effortsno
additional stakeholdersyes

Change #1036246 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Use named user in LabelRenderingTest for TempAccount support

https://gerrit.wikimedia.org/r/1036246

Change #1036246 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use named user in LabelRenderingTest for TempAccount support

https://gerrit.wikimedia.org/r/1036246

ItamarWMDE subscribed.

Unfortunately, there are still failures when running the tests on the CI Check patch (but we might have not chosen the right way to verify this): https://integration.wikimedia.org/ci/job/mediawiki-quibble-apitests-vendor-php74/7786/console

Change #1047472 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/CentralAuth@master] DNM: CI check

https://gerrit.wikimedia.org/r/1047472

Change #1035333 restored by Lucas Werkmeister (WMDE):

[mediawiki/extensions/FlaggedRevs@master] DNM: CI check

https://gerrit.wikimedia.org/r/1035333

Change #1047472 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/CentralAuth@master] DNM: CI check

Reason:

I misunderstood the task; there are PHPUnit failures here, but T365676 is about api-testing, which this extension doesn’t have AFAICT.

https://gerrit.wikimedia.org/r/1047472

Change #1035333 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/FlaggedRevs@master] DNM: CI check

Reason:

All the api-testing failures here are in core tests, not in FlaggedRevs tests.

https://gerrit.wikimedia.org/r/1035333

Change #1047477 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove custom CI $wgTempAccountCreationThrottle

https://gerrit.wikimedia.org/r/1047477

With the above Wikibase change applied (I rebased the CI check onto it), AFAICT the only remaining failures in CI are the same MediaWiki core api-testing failures that were also seen in e.g. FlaggedRevs’ CI check. (Are those tracked in another task?)

Change #1047477 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove custom CI $wgTempAccountCreationThrottle

https://gerrit.wikimedia.org/r/1047477

kostajh claimed this task.

With the above Wikibase change applied (I rebased the CI check onto it), AFAICT the only remaining failures in CI are the same MediaWiki core api-testing failures that were also seen in e.g. FlaggedRevs’ CI check. (Are those tracked in another task?)

Yes, those are tracked in T365647: Ensure api-testing MediaWiki core tests pass when temp account feature flag is enabled. Thanks!

Change #1035340 abandoned by Kosta Harlan:

[mediawiki/extensions/Wikibase@master] DNM: CI check for temp accounts

Reason:

https://gerrit.wikimedia.org/r/1035340