Page MenuHomePhabricator
Create Task
Maniphest T365645

Ensure PHPUnit MediaWiki extensions tests pass when temp account feature flag is enabled
Closed, ResolvedPublic
Actions

Description

Acceptance criteria:

Status (22 May 2024):

P62955 PHPUnit extension tests failures with temp accounts - wmf-quibble-core-vendor-mysql-php74
122:44:09 There were 6 errors:
222:44:09
322:44:09 1) AbuseFilterConsequencesTest::testFilterConsequences with data set "Basic test for "createaccount", disallowed." (array(15), array('createaccount', 'User:AnotherUser', 'AnotherUser'), array(array(15)))
422:44:09 CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled
522:44:09
622:44:09 /workspace/src/includes/user/ActorStore.php:638
722:44:09 /workspace/src/includes/user/ActorStore.php:415
822:44:09 /workspace/src/extensions/CheckUser/src/Services/CheckUserInsert.php:317
922:44:09 /workspace/src/extensions/CheckUser/src/Services/CheckUserInsert.php:234
1022:44:09 /workspace/src/extensions/CheckUser/src/Hooks.php:286
1122:44:09 /workspace/src/extensions/CheckUser/src/Hooks.php:204
1222:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:263
1322:44:09 /workspace/src/includes/deferred/MWCallableUpdate.php:42
1422:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:486
1522:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:198
1622:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:285
1722:44:09 /workspace/src/includes/deferred/DeferredUpdatesScope.php:269
1822:44:09 /workspace/src/includes/deferred/DeferredUpdatesScope.php:198
1922:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:304
2022:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:368
2122:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:162
2222:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:176
2322:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:265
2422:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:154
2522:44:09 /workspace/src/extensions/AbuseFilter/includes/FilterRunner.php:258
2622:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php:89
2722:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php:53
2822:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterCreateAccountTestTrait.php:39
2922:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:535
3022:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:786
3122:44:09 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
32Logs generated by test
33
34Show Details
3522:44:09
3622:44:09 2) AbuseFilterConsequencesTest::testThrottle with data set "Basic test for throttling "createaccount"" (array(11), array(array('createaccount', 'User:AnotherUser', 'AnotherUser'), array('createaccount', 'User:YetAnotherUser', 'YetAnotherUser')), array(array(11)))
3722:44:09 CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled
3822:44:09
3922:44:09 /workspace/src/includes/user/ActorStore.php:638
4022:44:09 /workspace/src/includes/user/ActorStore.php:415
4122:44:09 /workspace/src/extensions/CheckUser/src/Services/CheckUserInsert.php:317
4222:44:09 /workspace/src/extensions/CheckUser/src/Services/CheckUserInsert.php:234
4322:44:09 /workspace/src/extensions/CheckUser/src/Hooks.php:286
4422:44:09 /workspace/src/extensions/CheckUser/src/Hooks.php:204
4522:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:263
4622:44:09 /workspace/src/includes/deferred/MWCallableUpdate.php:42
4722:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:486
4822:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:198
4922:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:285
5022:44:09 /workspace/src/includes/deferred/DeferredUpdatesScope.php:269
5122:44:09 /workspace/src/includes/deferred/DeferredUpdatesScope.php:198
5222:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:304
5322:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:368
5422:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:162
5522:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:176
5622:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:265
5722:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:154
5822:44:09 /workspace/src/extensions/AbuseFilter/includes/FilterRunner.php:258
5922:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php:89
6022:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php:53
6122:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterCreateAccountTestTrait.php:39
6222:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:535
6322:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:563
6422:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:1007
6522:44:09 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
66Logs generated by test
67
68Show Details
6922:44:09
7022:44:09 3) AbuseFilterConsequencesTest::testWarn with data set "Basic test for warning on "createaccount"" (array(23), array('createaccount', 'User:AnotherWarnedUser', 'AnotherWarnedUser'), array(23), array(array(23)))
7122:44:09 CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled
7222:44:09
7322:44:09 /workspace/src/includes/user/ActorStore.php:638
7422:44:09 /workspace/src/includes/user/ActorStore.php:415
7522:44:09 /workspace/src/extensions/CheckUser/src/Services/CheckUserInsert.php:317
7622:44:09 /workspace/src/extensions/CheckUser/src/Services/CheckUserInsert.php:234
7722:44:09 /workspace/src/extensions/CheckUser/src/Hooks.php:286
7822:44:09 /workspace/src/extensions/CheckUser/src/Hooks.php:204
7922:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:263
8022:44:09 /workspace/src/includes/deferred/MWCallableUpdate.php:42
8122:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:486
8222:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:198
8322:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:285
8422:44:09 /workspace/src/includes/deferred/DeferredUpdatesScope.php:269
8522:44:09 /workspace/src/includes/deferred/DeferredUpdatesScope.php:198
8622:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:304
8722:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:368
8822:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:162
8922:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:176
9022:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:265
9122:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:154
9222:44:09 /workspace/src/extensions/AbuseFilter/includes/FilterRunner.php:258
9322:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php:89
9422:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php:53
9522:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterCreateAccountTestTrait.php:39
9622:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:535
9722:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:563
9822:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:1118
9922:44:09 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
100Logs generated by test
101
102Show Details
10322:44:09
10422:44:09 4) AbuseFilterConsequencesTest::testVarDump with data set #5 (array(15), array('createaccount', 'User:AnotherUser', 'AnotherUser'), array('action'))
10522:44:09 CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled
10622:44:09
10722:44:09 /workspace/src/includes/user/ActorStore.php:638
10822:44:09 /workspace/src/includes/user/ActorStore.php:415
10922:44:09 /workspace/src/extensions/CheckUser/src/Services/CheckUserInsert.php:317
11022:44:09 /workspace/src/extensions/CheckUser/src/Services/CheckUserInsert.php:234
11122:44:09 /workspace/src/extensions/CheckUser/src/Hooks.php:286
11222:44:09 /workspace/src/extensions/CheckUser/src/Hooks.php:204
11322:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:263
11422:44:09 /workspace/src/includes/deferred/MWCallableUpdate.php:42
11522:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:486
11622:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:198
11722:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:285
11822:44:09 /workspace/src/includes/deferred/DeferredUpdatesScope.php:269
11922:44:09 /workspace/src/includes/deferred/DeferredUpdatesScope.php:198
12022:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:304
12122:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:368
12222:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:162
12322:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:176
12422:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:265
12522:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:154
12622:44:09 /workspace/src/extensions/AbuseFilter/includes/FilterRunner.php:258
12722:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php:89
12822:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php:53
12922:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterCreateAccountTestTrait.php:39
13022:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:535
13122:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:1215
13222:44:09 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
133Logs generated by test
134
135Show Details
13622:44:09
13722:44:09 5) AbuseFilterConsequencesTest::testGlobalFilters with data set #5 (array(18), array('createaccount', 'User:AbuseFilterGlobalUser', 'AbuseFilterGlobalUser'), array(array(18)))
13822:44:09 CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled
13922:44:09
14022:44:09 /workspace/src/includes/user/ActorStore.php:638
14122:44:09 /workspace/src/includes/user/ActorStore.php:415
14222:44:09 /workspace/src/extensions/CheckUser/src/Services/CheckUserInsert.php:317
14322:44:09 /workspace/src/extensions/CheckUser/src/Services/CheckUserInsert.php:234
14422:44:09 /workspace/src/extensions/CheckUser/src/Hooks.php:286
14522:44:09 /workspace/src/extensions/CheckUser/src/Hooks.php:204
14622:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:263
14722:44:09 /workspace/src/includes/deferred/MWCallableUpdate.php:42
14822:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:486
14922:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:198
15022:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:285
15122:44:09 /workspace/src/includes/deferred/DeferredUpdatesScope.php:269
15222:44:09 /workspace/src/includes/deferred/DeferredUpdatesScope.php:198
15322:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:304
15422:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:368
15522:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:162
15622:44:09 /workspace/src/includes/deferred/DeferredUpdates.php:176
15722:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:265
15822:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseLogger.php:154
15922:44:09 /workspace/src/extensions/AbuseFilter/includes/FilterRunner.php:258
16022:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php:89
16122:44:09 /workspace/src/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php:53
16222:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterCreateAccountTestTrait.php:39
16322:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:535
16422:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterConsequencesTest.php:1487
16522:44:09 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
166Logs generated by test
167
168Show Details
16922:44:09
17022:44:09 6) RCVariableGeneratorTest::testGetVarsFromRCRow with data set "createaccount with IP performer" ('newusers', 'createaccount', MediaWiki\User\UserIdentityValue Object (...))
17122:44:09 CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled
17222:44:09
17322:44:09 /workspace/src/includes/user/ActorStore.php:638
17422:44:09 /workspace/src/includes/user/ActorStore.php:415
17522:44:09 /workspace/src/includes/logging/ManualLogEntry.php:299
17622:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/AbuseFilterCreateAccountTestTrait.php:56
17722:44:09 /workspace/src/extensions/AbuseFilter/tests/phpunit/RCVariableGeneratorTest.php:120
17822:44:09 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
179Logs generated by test
180
181Show Details
18222:44:09
18322:44:09 ERRORS!
18422:44:09 Tests: 12865, Assertions: 59921, Errors: 6, Skipped: 164.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CentralAuthCreateLocalTest#testWithNonAttachedUser: Set context usermediawiki/extensions/CentralAuthmaster+2 -0
Update FlaggablePageTestmediawiki/extensions/FlaggedRevsmaster+3 -20
RCVariableGeneratorTest: Handle anonymous user test with temp accounts enabledmediawiki/extensions/AbuseFiltermaster+6 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 ResolvedNiharikaT324492 Temporary accounts - MVP
 ResolvedkostajhT358847 [Epic] Ensure safety of release train and CI infrastructure during temporary accounts rollout
 ResolvedkostajhT355879 [Epic] Make PHPUnit extension and core, Selenium, and API testing tests pass with temp account feature flag enabled
 ResolvedkostajhT365645 Ensure PHPUnit MediaWiki extensions tests pass when temp account feature flag is enabled
 ResolvedDreamy_JazzT353953 Don't use actor IDs for private CheckUser events when these actions are performed by IP addresses
 ResolvedDreamy_JazzT359965 Update Special:CheckUser to handle 'NULL' as the value of cupe_actor in some of the rows of cu_private_event
 ResolvedDreamy_JazzT359962 Write null to cu_private_event.cupe_actor if temporary accounts are enabled and the performer is an IP address
 ResolvedABran-WMFT360332 Make the cupe_actor column nullable on WMF wikis
 ResolvedDreamy_JazzT359873 Make the cupe_private column nullable
 DeclinedABran-WMFT366241 Switchover s2 master (db2207 -> db2204)
 ResolvedABran-WMFT366242 Switchover s3 master (db2205 -> db2127)
 ResolvedDreamy_JazzT366505 Stop writing old for event table migration in extension.json
 ResolvedDreamy_JazzT329189 Add read new support to Special:Investigate for event table migration
 ResolvedDreamy_JazzT329200 Enable read new support in Special:Investigate's 'Timeline' tab
 ResolvedDreamy_JazzT329201 Enable read new support in Special:Investigate's 'IPs & User agents' tab
 ResolvedDreamy_JazzT347102 Alias column names in Special:Investigate to not include the "cuc_" prefix
 ResolvedDreamy_JazzT362152 Improve test coverage on Special:Investigate code
 ResolvedSecurityDreamy_JazzT338419 CVE-2024-40609: Wikimedia\RequestTimeout\RequestTimeoutException on Special:Investigate timeline mode
 DeclinedDreamy_JazzT363376 Move code that groups and sorts the rows from the CheckUser result tables to the CheckUserLookupUtils service to reduce duplication
 ResolvedDreamy_JazzT341827 Add read new support to the CheckUser API
 ResolvedDreamy_JazzT354643 Queries to cu_log_event on large wikis are exceeding TransactionProfiler limits on Special:CheckUser
 ResolvedDreamy_JazzT360622 Use the CheckUserLookupUtils service in Special:CheckUser pager classes
 ResolvedDreamy_JazzT360962 Create ApiQueryCheckUserResponseFactory service
 ResolvedDreamy_JazzT360963 Implement response classes for the CheckUser API
 ResolvedDreamy_JazzT360961 Create ApiQueryCheckUserAbstractResponse
 ResolvedDreamy_JazzT360072 Alias select fields in ApiQueryCheckUser
 ResolvedDreamy_JazzT360106 Improve test coverage on ApiQueryCheckUser
 ResolvedDreamy_JazzT360453 Create the CheckUserLookupUtils service
 ResolvedBUG REPORTDreamy_JazzT361722 'ipusers' does not handle 'cupe_actor' as NULL
 ResolvedDreamy_JazzT341829 Enable read new for the event table migration
 ResolvedDreamy_JazzT330158 Enable write new for the event table migration
 ResolvedDreamy_JazzT328874 Create temporary column in cu_changes to assist in migration to the new tables
 ResolvedMarosteguiT329203 Add new column cuc_only_for_read_old to cu_changes for migration purposes to wmf wikis
 ResolvedDreamy_JazzT341586 Allow write old and new for event table migration
 ResolvedPRODUCTION ERRORDreamy_JazzT342902 Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'cuc_only_for_read_old' in 'field list'Function: MediaWiki\CheckUser\Hooks::onAuthManagerLoginAuthenticateAuditQuery: INSERT INTO `cu_changes` (cuc_page_id,cuc_namespac
 ResolvedMarosteguiT343174 Add missing column cuc_only_for_read_old to testcommonswiki
 ResolvedLadsgroupT326105 Create cu_log_event and cu_private_event on WMF wikis
 ResolvedDreamy_JazzT328992 Add read new support to Special:CheckUser for event table migration
 ResolvedDreamy_JazzT328995 Enable read new support in Special:CheckUser's 'Get edits' mode
 ResolvedBUG REPORTDreamy_JazzT347773 Log action text shown when reading new does not respect the deleted status of the log
 ResolvedDreamy_JazzT328997 Enable read new support in Special:CheckUser's 'Get users' mode
 ResolvedDreamy_JazzT328998 Enable read new support in Special:CheckUser's 'Get IP Addresses' mode
 ResolvedDreamy_JazzT328988 Create a SelectQueryBuilder that allows selecting from all three tables
 ResolvedDreamy_JazzT342629 Investigate CheckUser currently saving failed login attempted to usernames which fail RIGOR_VALID
 ResolvedDreamy_JazzT341688 Create LogFormatter for cu_private_event log events
 ResolvedBUG REPORTDreamy_JazzT347400 Read new cannot parse the log_params of global block log entries
 ResolvedBUG REPORTDreamy_JazzT347669 moveLogEntriesFromCuChanges import inconsistencies
 ResolvedDreamy_JazzT358148 Fix test failures for CheckUser when temporary accounts are enabled

Event Timeline

kostajh created this task.May 22 2024, 7:59 PM
kostajh updated the task description. (Show Details)May 22 2024, 8:21 PM
kostajh updated the task description. (Show Details)May 23 2024, 7:05 AM
kostajh renamed this task from Ensure PHPUnit tests pass when temp account feature flag is enabled to Ensure PHPUnit extensions tests pass when temp account feature flag is enabled.May 23 2024, 7:08 AM
kostajh updated the task description. (Show Details)
kostajh updated the task description. (Show Details)
kostajh renamed this task from Ensure PHPUnit extensions tests pass when temp account feature flag is enabled to Ensure PHPUnit MediaWiki extensions tests pass when temp account feature flag is enabled.May 23 2024, 7:10 AM
kostajh mentioned this in T353953: Don't use actor IDs for private CheckUser events when these actions are performed by IP addresses.May 23 2024, 7:18 AM
kostajh added a subtask: T353953: Don't use actor IDs for private CheckUser events when these actions are performed by IP addresses.
kostajh added a subtask: T358148: Fix test failures for CheckUser when temporary accounts are enabled.May 23 2024, 7:22 AM
gerritbot added a comment.May 23 2024, 7:42 AM

Change #1035314 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/AbuseFilter@master] RCVariableGeneratorTest: Handle anonymous user test with temp accounts enabled

https://gerrit.wikimedia.org/r/1035314

gerritbot added a project: Patch-For-Review.May 23 2024, 7:42 AM
gerritbot added a comment.May 23 2024, 10:00 AM

Change #1035314 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] RCVariableGeneratorTest: Handle anonymous user test with temp accounts enabled

https://gerrit.wikimedia.org/r/1035314

Maintenance_bot removed a project: Patch-For-Review.May 23 2024, 10:30 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 23 2024, 11:00 AM
Tchanders moved this task from Inbox to Release train CI and infrastructure on the Temporary accounts board.Jun 4 2024, 12:56 PM
Tchanders edited projects, added Temporary accounts (Release train CI and infrastructure); removed Temporary accounts.
Dreamy_Jazz closed subtask T353953: Don't use actor IDs for private CheckUser events when these actions are performed by IP addresses as Resolved.Jun 5 2024, 3:35 PM
Dreamy_Jazz closed this task as Resolved.Jun 5 2024, 4:33 PM
Dreamy_Jazz claimed this task.
Dreamy_Jazz removed Dreamy_Jazz as the assignee of this task.
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz updated the task description. (Show Details)
gerritbot added a comment.Jun 19 2024, 2:56 PM

Change #1047529 had a related patch set uploaded (by Kosta Harlan; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/FlaggedRevs@master] Update FlaggablePageTest

https://gerrit.wikimedia.org/r/1047529

gerritbot added a project: Patch-For-Review.Jun 19 2024, 2:56 PM
Lucas_Werkmeister_WMDE reopened this task as Open.Jun 19 2024, 3:04 PM
Lucas_Werkmeister_WMDE subscribed.

Reopening for this CentralAuth failure seen in several of the changes attached to T365676 (e.g. Wikibase and FlaggedRevs):

1) CentralAuthCreateLocalTest::testWithNonAttachedUser
CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled

/workspace/src/includes/user/ActorStore.php:638
/workspace/src/includes/user/ActorStore.php:415
/workspace/src/includes/logging/ManualLogEntry.php:299
/workspace/src/extensions/CentralAuth/includes/User/CentralAuthForcedLocalCreationService.php:108
/workspace/src/extensions/CentralAuth/includes/Special/SpecialCreateLocalAccount.php:87
/workspace/src/extensions/CentralAuth/tests/phpunit/CentralAuthCreateLocalTest.php:122
phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106

(I assume that’s in scope for this task, but feel free to make it a subtask instead.)

I looked a bit at the code, and if I understand it correctly, Special:CreateLocalAccount is only expected to be used by privileged users (e.g. sysops and stewards), and the test should probably make sure that the special page runs from a logged in context; but I’m not confident enough with the code to try that myself.

gerritbot added a comment.Jun 19 2024, 3:07 PM

Change #1047529 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Update FlaggablePageTest

https://gerrit.wikimedia.org/r/1047529

Maintenance_bot removed a project: Patch-For-Review.Jun 19 2024, 3:30 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.11; 2024-06-25); removed MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).Jun 19 2024, 4:00 PM
gerritbot added a comment.Jun 27 2024, 5:29 PM

Change #1050434 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/CentralAuth@master] CentralAuthCreateLocalTest#testWithNonAttachedUser: Set context user

https://gerrit.wikimedia.org/r/1050434

gerritbot added a project: Patch-For-Review.Jun 27 2024, 5:29 PM
kostajh added a comment.Jun 27 2024, 5:30 PM
In T365645#9907299, @Lucas_Werkmeister_WMDE wrote:

Reopening for this CentralAuth failure seen in several of the changes attached to T365676 (e.g. Wikibase and FlaggedRevs):

1) CentralAuthCreateLocalTest::testWithNonAttachedUser
CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled

/workspace/src/includes/user/ActorStore.php:638
/workspace/src/includes/user/ActorStore.php:415
/workspace/src/includes/logging/ManualLogEntry.php:299
/workspace/src/extensions/CentralAuth/includes/User/CentralAuthForcedLocalCreationService.php:108
/workspace/src/extensions/CentralAuth/includes/Special/SpecialCreateLocalAccount.php:87
/workspace/src/extensions/CentralAuth/tests/phpunit/CentralAuthCreateLocalTest.php:122
phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106

(I assume that’s in scope for this task, but feel free to make it a subtask instead.)

I looked a bit at the code, and if I understand it correctly, Special:CreateLocalAccount is only expected to be used by privileged users (e.g. sysops and stewards), and the test should probably make sure that the special page runs from a logged in context; but I’m not confident enough with the code to try that myself.

Thanks, should be fixed in CentralAuthCreateLocalTest#testWithNonAttachedUser: Set context user

kostajh claimed this task.Jun 27 2024, 5:30 PM
kostajh added a project: Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)).
gerritbot added a comment.Jun 27 2024, 9:50 PM

Change #1050434 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] CentralAuthCreateLocalTest#testWithNonAttachedUser: Set context user

https://gerrit.wikimedia.org/r/1050434

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.12; 2024-07-02); removed MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 27 2024, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 27 2024, 10:30 PM
kostajh closed this task as Resolved.Jun 28 2024, 6:20 AM
kostajh moved this task from Priority Backlog to Done on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 12 2024, 3:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits