Page MenuHomePhabricator
Create Task
Maniphest T366236

Labels disappearing from the UI, displaying Q and P numbers instead.
Closed, ResolvedPublicBUG REPORT
Actions

Description

Since yesterday (May 29th) labels have been disappearing from the UI, exposing instead the underlying P and Q numbers.

Steps to replicate the issue (include links if applicable):

  1. Go to any item with a Wikipedia link
  2. Click edit on the Wikipedia section
  3. Click the "set a badge" icon.

What happens?:
The UI displays a list of linked QItems

What should have happened instead?:
The UI should display a list of links with human friendly labels.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

image.png (397×378 px, 17 KB)

Details

SubjectRepoBranchLines +/-
Specify default data value type in entityViewmediawiki/extensions/Wikibasemaster+1 -1
Register parsers for both data types and value typesmediawiki/extensions/Wikibasemaster+13 -5
Customize query in gerrit

Related Objects

Event Timeline

Moebeus created this task.Thu, May 30, 7:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, May 30, 7:45 AM
Moebeus updated the task description. (Show Details)Thu, May 30, 7:46 AM
Fnielsen subscribed.Thu, May 30, 7:52 AM

I see that the property labels (sometimes) disappear.

Moebeus updated the task description. (Show Details)Thu, May 30, 7:54 AM
Moebeus added a comment.Thu, May 30, 7:57 AM
In T366236#9845259, @Fnielsen wrote:

I see that the property labels (sometimes) disappear.

Indeed. It happens all over the place, but for other parts of the UI a refresh will sort it out, unlike with the interwikilinks.

image.png (438×235 px, 29 KB)
image.png (116×619 px, 31 KB)

Lydia_Pintscher added a project: Wikidata Dev Team.Thu, May 30, 8:50 AM
Arian_Bozorg moved this task from Incoming to Unified DOT Backlog on the Wikidata Dev Team board.Thu, May 30, 8:51 AM
Arian_Bozorg updated the task description. (Show Details)Thu, May 30, 8:55 AM
ArthurTaylor claimed this task.Thu, May 30, 9:31 AM
ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.
ArthurTaylor moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Thu, May 30, 11:16 AM

Change #1037474 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Specify default data value type in entityView

https://gerrit.wikimedia.org/r/1037474

gerritbot added a project: Patch-For-Review.Thu, May 30, 11:16 AM
gerritbot added a comment.Thu, May 30, 12:23 PM

Change #1037513 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Register parsers for both data types and value types

https://gerrit.wikimedia.org/r/1037513

ArthurTaylor mentioned this in T366275: Wikidata property label is not rendered after editing..Thu, May 30, 1:20 PM
gerritbot added a comment.Thu, May 30, 1:49 PM

Change #1037513 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Register parsers for both data types and value types

https://gerrit.wikimedia.org/r/1037513

WMDE-leszek subscribed.Thu, May 30, 7:47 PM
gerritbot added a comment.Fri, May 31, 7:07 AM

Change #1037474 abandoned by Arthur taylor:

[mediawiki/extensions/Wikibase@master] Specify default data value type in entityView

Reason:

Prefer the solution 1037513

https://gerrit.wikimedia.org/r/1037474

ArthurTaylor removed ArthurTaylor as the assignee of this task.Fri, May 31, 7:14 AM
ArthurTaylor moved this task from In Development to Waiting for Deployment Window on the Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor subscribed.
Maintenance_bot removed a project: Patch-For-Review.Fri, May 31, 7:30 AM
Bugreporter merged a task: T366423: Add a badge shows the Q-ID only, not the names.Mon, Jun 3, 1:13 AM
Bugreporter added a subscriber: Raymond.
matej_suchanek added a project: Regression.Mon, Jun 3, 7:53 AM
Xover subscribed.Tue, Jun 4, 12:33 PM
jhsoby subscribed.Wed, Jun 5, 8:32 AM
ArthurTaylor added a comment.Thu, Jun 6, 7:57 AM

The train has reached Wikidata.org - badges appear to work again for me. Can someone confirm?

ArthurTaylor moved this task from Waiting for Deployment Window to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Thu, Jun 6, 7:59 AM
Lydia_Pintscher closed this task as Resolved.Mon, Jun 10, 11:56 AM
Lydia_Pintscher claimed this task.
Lydia_Pintscher moved this task from Product Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.
Lydia_Pintscher subscribed.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL