Page MenuHomePhabricator
Create Task
Maniphest T366370

Enable night theme on pages which have no color contrast issues
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Fri, May 31, 4:03 PM
Tags
Referenced Files
F55102668: screenshot 705.png
Sun, Jun 9, 6:37 AM
F55102660: screenshot 704.png
Sun, Jun 9, 6:37 AM
F55102651: screenshot 703.png
Sun, Jun 9, 6:37 AM
F55102643: screenshot 702.png
Sun, Jun 9, 6:37 AM
F55102639: screenshot 701.png
Sun, Jun 9, 6:37 AM
F55102633: screenshot 700.png
Sun, Jun 9, 6:37 AM
F55102627: screenshot 699.png
Sun, Jun 9, 6:37 AM
F55102624: screenshot 698.png
Sun, Jun 9, 6:37 AM
View All 82 Files
Subscribers
Aklapper
Edtadros
Jdlrobson
Krinkle
Masumrezarock100

Description

Background

For pages where there are no issues with night mode, as judged by the evaluation in T361557, we should enable night mode.

User story

As a user I want all my pages in dark mode.

Requirement

Enable night mode on pages without color contrast issues, including specific namespaces, action pages, and special pages as listed in the Acceptance Criteria section of the task. Verify the implementation on the provided pages.

BDD

gherkin
Feature: Enable Night Mode on Pages without Color Contrast Issues

  Scenario: Enable night mode on pages without color contrast issues
    Given the night mode is enabled
    When the user views the specified namespaces, action pages, and special pages
    Then the pages should display in night mode without color contrast issues

Test Steps

Test Case 1: Verify Night Mode on Specified Pages

  1. Enable night mode.
  2. Navigate to the specified pages listed in the Acceptance Criteria section of the task.
  3. AC1: Confirm that pages display in night mode without color contrast issues.

Acceptance criteria

Communication criteria - does this need an announcement or discussion?

An announcement would be useful so interface admins can address issues.

Rollback plan

N/A

This task was created by Version 1.0.0 of the Web team task template using phabulous

Details

SubjectRepoBranchLines +/-
Enable night theme on pages which have no color contrast issuesoperations/mediawiki-configmaster+48 -99
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Fri, May 31, 4:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, May 31, 4:03 PM
Jdlrobson updated the task description. (Show Details)Fri, May 31, 4:36 PM
Jdlrobson updated the task description. (Show Details)Fri, May 31, 4:39 PM
Jdlrobson triaged this task as High priority.Fri, May 31, 4:49 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 5); removed Web-Team-Backlog.Fri, May 31, 4:56 PM
Jdlrobson set the point value for this task to 1.
Jdlrobson moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.Fri, May 31, 4:59 PM
Jdlrobson claimed this task.Fri, May 31, 5:17 PM
Jdlrobson updated the task description. (Show Details)
• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Mon, Jun 3, 1:39 AM
JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Mon, Jun 3, 1:44 AM
Jdlrobson updated the task description. (Show Details)Mon, Jun 3, 4:22 PM
Jdlrobson merged a task: T358409: Special:UserRights does not render readable in night mode.
Jdlrobson added subscribers: Krinkle, Masumrezarock100.
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.Mon, Jun 3, 6:14 PM
gerritbot added a comment.Mon, Jun 3, 6:59 PM

Change #1038424 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable night theme on pages which have no color contrast issues

https://gerrit.wikimedia.org/r/1038424

gerritbot added a project: Patch-For-Review.Mon, Jun 3, 6:59 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.Mon, Jun 3, 7:24 PM
gerritbot added a comment.Mon, Jun 3, 8:28 PM

Change #1038424 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable night theme on pages which have no color contrast issues

https://gerrit.wikimedia.org/r/1038424

Maintenance_bot removed a project: Patch-For-Review.Mon, Jun 3, 8:31 PM
Stashbot mentioned this in T366314: Deploy and QA responsive tables change.Mon, Jun 3, 8:36 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-03T20:36:51Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:1037600|Wrap tables in Vector 2022 for projects where legacy Vector is default (T366314)]], [[gerrit:1038424|Enable night theme on pages which have no color contrast issues (T366370)]]

Stashbot added a comment.Mon, Jun 3, 8:39 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-03T20:39:12Z] <urbanecm@deploy1002> jdlrobson and urbanecm: Backport for [[gerrit:1037600|Wrap tables in Vector 2022 for projects where legacy Vector is default (T366314)]], [[gerrit:1038424|Enable night theme on pages which have no color contrast issues (T366370)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mon, Jun 3, 8:51 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-03T20:51:48Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1037600|Wrap tables in Vector 2022 for projects where legacy Vector is default (T366314)]], [[gerrit:1038424|Enable night theme on pages which have no color contrast issues (T366370)]] (duration: 14m 57s)

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.Mon, Jun 3, 9:01 PM
Jdrewniak reassigned this task from Jdlrobson to Edtadros.Tue, Jun 4, 4:13 PM
Jdlrobson claimed this task.Tue, Jun 4, 4:15 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Edtadros.
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Tue, Jun 4, 8:51 PM
Edtadros updated the task description. (Show Details)Sun, Jun 9, 5:20 AM
Edtadros reassigned this task from Edtadros to Jdlrobson.Sun, Jun 9, 6:37 AM
Edtadros moved this task from QA to Needs More Work on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.

Test Result - Prod

Status: ❌ FAIL
Environment: enwiki, commons
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Night Mode on Specified Pages

  1. Enable night mode.
  2. Navigate to the specified pages listed in the Acceptance Criteria section of the task.
  3. ❌ AC1: Confirm that pages display in night mode without color contrast issues.

14, 34, and 78 did not appear in dark mode.

#StatusPage LinkScreenshot
1✅Category:Expatriate_sportspeople_by_nationality
screenshot 624.png (1×1 px, 396 KB)
2✅Help:Gadget-Cat-a-lot
screenshot 625.png (1×1 px, 654 KB)
3✅Main_Page?action=info
screenshot 626.png (1×1 px, 395 KB)
4✅Special:BrokenRedirects
screenshot 627.png (1×1 px, 259 KB)
5✅Special:LintErrors
screenshot 628.png (1×1 px, 379 KB)
6✅Special:AllPages
screenshot 629.png (1×1 px, 308 KB)
7✅Special:PrefixIndex
screenshot 630.png (1×1 px, 286 KB)
8✅Special:Categories
screenshot 631.png (1×1 px, 400 KB)
9✅Special:CategoryTree
screenshot 632.png (1×1 px, 292 KB)
10✅Special:EntityUsage
screenshot 633.png (1×1 px, 268 KB)
11✅Special:LinkSearch
screenshot 634.png (1×1 px, 306 KB)
12✅Special:PagesWithProp
screenshot 635.png (1×1 px, 276 KB)
13✅Special:PagesWithBadges
screenshot 636.png (1×1 px, 277 KB)
14❌Special:Search
screenshot 637.png (1×1 px, 265 KB)
15✅Special:BotPasswords
screenshot 638.png (1×1 px, 314 KB)
16✅Special:ChangeCredentials
screenshot 639.png (1×1 px, 257 KB)
17✅Special:ChangeEmail
screenshot 640.png (1×1 px, 289 KB)
18✅Special:MergeAccount
screenshot 641.png (1×1 px, 348 KB)
19✅Special:Manage Two-factor authentication
screenshot 642.png (1×1 px, 273 KB)
20✅Special:OAuthManageMyGrants
screenshot 643.png (1×1 px, 315 KB)
21✅Special:RemoveCredentials
screenshot 644.png (1×1 px, 255 KB)
22✅Special:PasswordReset
screenshot 645.png (1×1 px, 262 KB)
23✅Special:ResetTokens
screenshot 646.png (1×1 px, 284 KB)
24✅Special:ActiveUsers
screenshot 647.png (1×1 px, 429 KB)
25✅Special:CreateAccount
screenshot 648.png (1×1 px, 324 KB)
26✅Special:EmailUser
screenshot 649.png (1×1 px, 256 KB)
27✅Special:CentralAuth
screenshot 650.png (1×1 px, 295 KB)
28✅Special:GlobalUsers
screenshot 651.png (1×1 px, 294 KB)
29✅Special:GlobalGroupPermissions
screenshot 652.png (1×1 px, 413 KB)
30✅Special:ListGrants
screenshot 653.png (1×1 px, 384 KB)
31✅Special:OAuthListConsumers
screenshot 654.png (1×1 px, 338 KB)
32✅Special:GlobalBlockList
screenshot 655.png (1×1 px, 493 KB)
33✅Special:PasswordPolicies
screenshot 656.png (1×1 px, 420 KB)
34❌Special:Contributions
screenshot 657.png (1×1 px, 299 KB)
35✅Special:ListUsers
screenshot 658.png (1×1 px, 445 KB)
36✅Special:EditRecovery
screenshot 659.png (1×1 px, 259 KB)
37✅Special:NewFiles
screenshot 660.png (1×1 px, 384 KB)
38✅Special:NewPages
screenshot 661.png (1×1 px, 389 KB)
39✅Special:Log
screenshot 662.png (1×1 px, 391 KB)
40✅Special:GlobalUsage
screenshot 663.png (1×1 px, 270 KB)
41✅Special:ListDuplicatedFiles
screenshot 664.png (1×1 px, 409 KB)
42✅Special:MediaStatistics
screenshot 665.png (1×1 px, 387 KB)
43✅Special:OrphanedTimedText
screenshot 666.png (1×1 px, 367 KB)
44✅Special:FileDuplicateSearch
screenshot 667.png (1×1 px, 260 KB)
45✅Special:VipsTest
screenshot 668.png (1×1 px, 260 KB)
46✅Special:ApiFeatureUsage
screenshot 669.png (1×1 px, 273 KB)
47✅Special:BookSources
screenshot 670.png (1×1 px, 270 KB)
48✅Special:ExpandTemplates
screenshot 671.png (1×1 px, 309 KB)
49✅Special:GadgetUsage
screenshot 672.png (1×1 px, 368 KB)
50✅Special:Gadgets
screenshot 673.png (1×1 px, 447 KB)
51✅Special:TemplateSandbox
screenshot 674.png (1×1 px, 291 KB)
52✅Special:Version
screenshot 675.png (1×1 px, 409 KB)
53✅Special:Interwiki
screenshot 676.png (1×1 px, 367 KB)
54✅Special:WikiSets
screenshot 677.png (1×1 px, 261 KB)
55✅Special:SiteMatrix
screenshot 678.png (1×1 px, 348 KB)
56✅Special:DeletePage
screenshot 679.png (1×1 px, 253 KB)
57✅Special:Diff
screenshot 680.png (1×1 px, 260 KB)
58✅Special:EditPage
screenshot 681.png (1×1 px, 253 KB)
59✅Special:NewSection
screenshot 682.png (1×1 px, 255 KB)
60✅Special:PageHistory
screenshot 683.png (1×1 px, 254 KB)
61✅Special:PageInfo
screenshot 684.png (1×1 px, 253 KB)
62✅Special:PermanentLink
screenshot 685.png (1×1 px, 258 KB)
63✅Special:ProtectPage
screenshot 686.png (1×1 px, 254 KB)
64✅Special:Purge
screenshot 687.png (1×1 px, 251 KB)
65✅Special:Random
screenshot 688.png (1×1 px, 460 KB)
66✅Special:RandomInCategory
screenshot 689.png (1×1 px, 258 KB)
67✅Special:RandomRedirect
screenshot 690.png (1×1 px, 332 KB)
68✅Special:RandomRootpage
screenshot 691.png (1×1 px, 401 KB)
69✅Special:Redirect
screenshot 692.png (1×1 px, 290 KB)
70✅Special:Book
screenshot 693.png (1×1 px, 319 KB)
71✅Special:ChangeContentModel
screenshot 694.png (1×1 px, 266 KB)
72✅Special:CiteThisPage
screenshot 695.png (1×1 px, 254 KB)
73✅Special:Export
screenshot 696.png (1×1 px, 339 KB)
74✅Special:Impact
screenshot 697.png (1×1 px, 305 KB)
75✅Special:NewcomerTasksInfo
screenshot 698.png (1×1 px, 307 KB)
76✅Special:ValidationStatistics
screenshot 699.png (1×1 px, 366 KB)
77✅Special:StablePages
screenshot 700.png (1×1 px, 548 KB)
78❌Special:ContentTranslationStats
screenshot 701.png (1×1 px, 190 KB)
79✅Special:Contribute
screenshot 702.png (1×1 px, 283 KB)
80✅Special:CreateMassMessageList
screenshot 703.png (1×1 px, 267 KB)
81✅Special:MathWikibase
screenshot 704.png (1×1 px, 262 KB)
82✅Special:Userrights
screenshot 705.png (1×1 px, 261 KB)
Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.Mon, Jun 10, 3:57 PM
Jdlrobson updated the task description. (Show Details)

Thanks @Edtadros ! Those failures shouldn't have been in the QA steps - my bad! I've removed! We have follow up tickets for them.

Jdlrobson reassigned this task from Jdlrobson to ovasileva.Mon, Jun 10, 5:23 PM
ovasileva closed this task as Resolved.Wed, Jun 12, 11:51 AM
ovasileva added a project: User-notice.

Marking with tech news for the announcement. I think we can probably say something like: "The dark mode beta feature is now available on a new set of special pages, allowing testing for any potential issues"

Everything else looks good. Resolving.

Quiddity moved this task from To Triage to Announce in next Tech/News on the User-notice board.Wed, Jun 12, 6:10 PM
Quiddity moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Thu, Jun 13, 11:28 PM
Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Thu, Jun 20, 5:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL