Support {{#FORMAL:}} in JavaScript
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Functionality for new {{#FORMAL:}} syntax was added in T238433: Inline syntax for language politeness variants (informal/formal), to enable translation into both formal and informal variants in one language code for languages that make that distinction. However, the implementation doesn't support JavaScript yet, while it should.

To reproduce the problem in production:

Open the browser console
Type or paste: mw.messages.set( 'mytest', '{{#FORMAL:informal|formal}}' );
Type or paste: mw.msg( 'mytest' ); and see the result.
- Actual result: {{#FORMAL:informal|formal}}
- Expected result: informal (unless your user interface language is set to de-formal, es-formal or hu-formal, in which case the expected result would be formal).

Details

Other Assignee: abi_

	Subject	Repo	Branch	Lines +/-
	Support {{#FORMAL:}} syntax in jqueryMsg	mediawiki/core	REL1_43	+42 -2
	Support {{#FORMAL:}} syntax in jqueryMsg	mediawiki/core	master	+42 -2

Customize query in gerrit

Related Objects

Mentioned Here: T238433: Inline syntax for language politeness variants (informal/formal)

Event Timeline

jhsoby created this task.Jun 4 2024, 1:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 4 2024, 1:59 PM

Change #1038812 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/core@master] Support {{#FORMAL:}} syntax in jqueryMsg

https://gerrit.wikimedia.org/r/1038812

gerritbot added a project: Patch-For-Review.Jun 4 2024, 2:00 PM

Nikerabbit triaged this task as Medium priority.Jun 6 2024, 7:03 AM

Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2024-April-June) board.

Nikerabbit set the point value for this task to 2.

Nikerabbit added a project: Unplanned-Sprint-Work.

Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.Jun 11 2024, 8:41 AM

jhsoby merged a task: T367083: {{int:citoid-citoiddialog-mode-manual}} is not parsed in message Citoid-citoiddialog-use-general-error-message.Jun 11 2024, 1:16 PM

jhsoby added a subscriber: Raymond.

Nikerabbit updated Other Assignee, added: abi_.Jun 27 2024, 10:41 AM

Nikerabbit edited projects, added LPL Essential (LPL Essential 2024 Jul-Oct); removed Language-Team (Language-2024-April-June).

Nikerabbit moved this task from Sprint Backlog to Needs Review on the LPL Essential (LPL Essential 2024 Jul-Oct) board.

Tkarcher subscribed.Jul 23 2024, 7:33 AM

abi_ moved this task from Needs Review to Sprint Backlog on the LPL Essential (LPL Essential 2024 Jul-Oct) board.Aug 5 2024, 8:27 AM

I just learned that this is potentially much more user-facing than expected. The moment someone not aware of this limitation adds a single {{#FORMAL:…}} to an existing message (just anywhere, it doesn't even need to be nested with the existing {{GENDER:…}} syntax) the jqueryMsg code starts to fail hard with "Parse errors", stops doing anything and leaves the message completely unparsed. I believe this is a problem, because:

GENDER and FORMAL obviously belong together. As a translator I would expect the two to behave the same – either both work or both do not work.
How can translators on translatewiki even tell if they are allowed to use certain features or not? They would need to be able to identify messages that are parsed via jqueryMsg, and then known that these (and only these) can use GENDER but not FORMAL. I don't think there is a way to tell.

Can you prioritize this accordingly?

Johannes_Richter_WMDE subscribed.Aug 6 2024, 11:25 AM

Latest update: There is a patch from Jon that needs to be reviewed: https://gerrit.wikimedia.org/r/c/1038812

matmarex subscribed.Oct 4 2024, 7:43 PM

Krinkle subscribed.Tue, Oct 22, 8:53 PM

Change #1038812 merged by jenkins-bot:

[mediawiki/core@master] Support {{#FORMAL:}} syntax in jqueryMsg

https://gerrit.wikimedia.org/r/1038812

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Wed, Oct 23, 7:02 PM

Maintenance_bot removed a project: Patch-For-Review.Wed, Oct 23, 7:31 PM

matmarex closed this task as Resolved.Thu, Oct 24, 4:51 PM

Change #1082817 had a related patch set uploaded (by Bartosz Dziewoński; author: Jon Harald Søby):