Abuse filters with array index access cannot be saved anymore
Open, HighPublicBUG REPORT
Actions

Assigned To

None

Authored By

	matej_suchanek
	Sat, Jun 22, 7:55 PM

Description

Steps to replicate the issue (include links if applicable):

Go to Special:AbuseFilter/new
Set the following conditions: added_lines[0] & false
Save the filter

It also happens when updating an existing filter with similar conditions.

What happens?:

You get an error like:

[6f778b4a-04a4-403e-9a9e-894fe8258f81] 2024-06-22 19:43:24: Kritická výjimka typu „MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException“

What should have happened instead?:

The filter is saved. Or the exception is handled, and the error is more user-friendly.

Other information (browser name/version, screenshots, etc.):

Probably caused by rEABFf5d7b6890898c2e4c672142de70a91ba3ec0f099.

This can become annoying when you really really need to update a filter but are not allowed to do so.

Details

	Subject	Repo	Branch	Lines +/-
	[POC] getReferencedVars	mediawiki/extensions/AbuseFilter	master	+69 -15

Customize query in gerrit

Related Objects

Mentioned Here: rEABFf5d7b6890898: Force full evaluation of filter in FilterEvaluator->getUsedVars()

Event Timeline

matej_suchanek created this task.Sat, Jun 22, 7:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Jun 22, 7:55 PM

Having reproduced locally, I found it is this exception. The type is null (no variable has a value). Maybe it should handle DNULL in the same way as DUNDEFINED?

suffusion_of_yellow subscribed.Sun, Jun 23, 8:05 PM

This seems to affect any filter with an error in the "path not taken": This

old_size > 0 & new_size / old_size < 0.5

gives me

[3e374600-82e9-4f10-8656-9983c4facaf7] 2024-06-23 20:41:55: Fatal exception of type "MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException"

Brainstorming here, but if all we're interested in is the names of any variables that might be used, is it really necessary to evaluate the filter? Maybe just extract the names from AbuseFilterTokenizer's output instead?

codenamenoreste subscribed.Mon, Jun 24, 3:17 AM

Novem_Linguae subscribed.Mon, Jun 24, 4:14 AM

Titore subscribed.Mon, Jun 24, 6:32 AM

Change #1049092 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/AbuseFilter@master] [POC] getReferencedVars

https://gerrit.wikimedia.org/r/1049092

gerritbot added a project: Patch-For-Review.Mon, Jun 24, 8:12 AM

In T368203#9916180, @suffusion_of_yellow wrote:

Brainstorming here, but if all we're interested in is the names of any variables that might be used, is it really necessary to evaluate the filter? Maybe just extract the names from AbuseFilterTokenizer's output instead?

I made a proof of concept, but it isn't finished. Everyone is free to amend the patch (or make an alternative).

1AmNobody24 subscribed.Thu, Jun 27, 6:13 AM

Abuse filters with array index access cannot be saved anymoreOpen, HighPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Abuse filters with array index access cannot be saved anymore
Open, HighPublicBUG REPORT
Actions