Abuse filters with array index access cannot be saved anymore: "MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException: notarray"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Steps to replicate the issue (include links if applicable):

Go to Special:AbuseFilter/new
Set the following conditions: added_lines[0] & false
Save the filter

It also happens when updating an existing filter with similar conditions.

What happens?:

You get an error like:

[6f778b4a-04a4-403e-9a9e-894fe8258f81] 2024-06-22 19:43:24: Kritická výjimka typu „MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException“
resp.
MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException: notarray

What should have happened instead?:

The filter is saved. Or the exception is handled, and the error is more user-friendly.

Other information (browser name/version, screenshots, etc.):

Probably caused by rEABFf5d7b6890898c2e4c672142de70a91ba3ec0f099.

This can become annoying when you really really need to update a filter but are not allowed to do so.

Details

	Subject	Repo	Branch	Lines +/-
	Introduce and use FilterEvaluator::getReferencedVars	mediawiki/extensions/AbuseFilter	master	+50 -3
	Simplify FilterEvaluator::getUsedVars using ::checkSyntax	mediawiki/extensions/AbuseFilter	master	+12 -20

Customize query in gerrit

Related Objects

Mentioned In: T369793: MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException: notarray
T368831: Fatal exception of type "MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException"
Mentioned Here: rEABFf5d7b6890898: Force full evaluation of filter in FilterEvaluator->getUsedVars()

Event Timeline

matej_suchanek created this task.Jun 22 2024, 7:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2024, 7:55 PM

Having reproduced locally, I found it is this exception. The type is null (no variable has a value). Maybe it should handle DNULL in the same way as DUNDEFINED?

suffusion_of_yellow subscribed.Jun 23 2024, 8:05 PM

This seems to affect any filter with an error in the "path not taken": This

old_size > 0 & new_size / old_size < 0.5

gives me

[3e374600-82e9-4f10-8656-9983c4facaf7] 2024-06-23 20:41:55: Fatal exception of type "MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException"

Brainstorming here, but if all we're interested in is the names of any variables that might be used, is it really necessary to evaluate the filter? Maybe just extract the names from AbuseFilterTokenizer's output instead?

codenamenoreste subscribed.Jun 24 2024, 3:17 AM

Novem_Linguae subscribed.Jun 24 2024, 4:14 AM

Titore subscribed.Jun 24 2024, 6:32 AM

Change #1049092 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/AbuseFilter@master] [POC] getReferencedVars

https://gerrit.wikimedia.org/r/1049092

gerritbot added a project: Patch-For-Review.Jun 24 2024, 8:12 AM

In T368203#9916180, @suffusion_of_yellow wrote:

Brainstorming here, but if all we're interested in is the names of any variables that might be used, is it really necessary to evaluate the filter? Maybe just extract the names from AbuseFilterTokenizer's output instead?

I made a proof of concept, but it isn't finished. Everyone is free to amend the patch (or make an alternative).

1AmNobody24 subscribed.Jun 27 2024, 6:13 AM

Dragoniez mentioned this in T368831: Fatal exception of type "MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException".Jun 29 2024, 4:11 PM

Nemoralis merged a task: T368831: Fatal exception of type "MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException".Jun 29 2024, 4:22 PM

Nemoralis added a subscriber: Dragoniez.

Change #1052272 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/AbuseFilter@master] Simplify FilterEvaluator::getUsedVars using ::checkSyntax

https://gerrit.wikimedia.org/r/1052272

Change #1052272 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Simplify FilterEvaluator::getUsedVars using ::checkSyntax

https://gerrit.wikimedia.org/r/1052272

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 8 2024, 1:00 PM

matej_suchanek mentioned this in T369793: MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException: notarray.Jul 11 2024, 10:52 AM

Aklapper renamed this task from Abuse filters with array index access cannot be saved anymore to Abuse filters with array index access cannot be saved anymore: "MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException: notarray".Jul 11 2024, 10:57 AM

Aklapper changed the subtype of this task from "Bug Report" to "Production Error".

Aklapper added a project: Wikimedia-production-error.

Aklapper updated the task description. (Show Details)

Aklapper merged a task: T369793: MediaWiki\Extension\AbuseFilter\Parser\Exception\UserVisibleException: notarray.

matej_suchanek closed this task as Resolved.Jul 12 2024, 5:21 PM

matej_suchanek claimed this task.

Change #1049092 abandoned by STran:

[mediawiki/extensions/AbuseFilter@master] Introduce and use FilterEvaluator::getReferencedVars

Reason:

Resolved by I637367c3b3850f7988d890379fef7f4753159953