Page MenuHomePhabricator
Create Task
Maniphest T372444

Deleted contributions not showing for users with spaces in their user name
Closed, ResolvedPublicBUG REPORT
Actions

Description

For example

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
DeletedContribsPager: Use the UserIdentity object instead of the raw target stringmediawiki/coreREL1_44+17 -17
DeletedContribsPager: Use the UserIdentity object instead of the raw target stringmediawiki/coreREL1_43+18 -18
DeletedContribsPager: Use the UserIdentity object instead of the raw target stringmediawiki/coremaster+17 -17
Fix DeletedContributions for user names containing spacesmediawiki/corewmf/1.43.0-wmf.18+30 -2
Fix DeletedContributions for user names containing spacesmediawiki/coremaster+30 -2
Customize query in gerrit

Related Objects

Event Timeline

Pppery created this task.Aug 13 2024, 10:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2024, 10:46 PM
Pppery added a comment.Aug 13 2024, 10:47 PM

This seems to be a regression in the latest version. Probably not important enough to block the train, though.

Pppery mentioned this in T366963: 1.43.0-wmf.18 deployment blockers.Aug 13 2024, 10:47 PM
• mszabo subscribed.Aug 14 2024, 5:57 PM

This regressed during T370438 work, we'll tackle it.

• mszabo changed the task status from Open to In Progress.Aug 14 2024, 5:57 PM
• mszabo claimed this task.
• mszabo triaged this task as Low priority.
• mszabo added projects: Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)).
gerritbot added a comment.Aug 14 2024, 6:04 PM

Change #1062747 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] Fix DeletedContributions for user names containing spaces

https://gerrit.wikimedia.org/r/1062747

gerritbot added a project: Patch-For-Review.Aug 14 2024, 6:04 PM
• mszabo moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)) board.Aug 14 2024, 6:04 PM
Pppery merged a task: T372610: User's edits do not show up in either Special:Contributions or Special:DeletedContributions and are not suppressed.Aug 15 2024, 11:52 PM
Pppery added subscribers: RoySmith, Vermont.
Johannnes89 subscribed.Aug 16 2024, 6:12 AM
Primefac subscribed.Aug 16 2024, 11:49 AM
Xaosflux added a project: Regression.Aug 16 2024, 12:23 PM
Sdrqaz subscribed.Aug 16 2024, 12:26 PM
gerritbot added a comment.Aug 16 2024, 1:26 PM

Change #1062747 merged by jenkins-bot:

[mediawiki/core@master] Fix DeletedContributions for user names containing spaces

https://gerrit.wikimedia.org/r/1062747

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2024, 1:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.19; 2024-08-20).Aug 16 2024, 2:00 PM
1234qwer1234qwer4 subscribed.Aug 16 2024, 7:10 PM

I'm not sure how this is "low" priority.

ScottishFinnishRadish subscribed.Aug 17 2024, 12:33 AM
Pppery moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.Aug 17 2024, 4:54 AM
ToBeFree awarded a token.Aug 17 2024, 12:05 PM
ToBeFree subscribed.
Supertoff subscribed.Aug 17 2024, 5:10 PM
Supertoff unsubscribed.
Mathis_Benguigui subscribed.Aug 18 2024, 11:52 AM
Ameisenigel subscribed.Aug 18 2024, 12:42 PM
Count_Count subscribed.Aug 18 2024, 2:19 PM
Novem_Linguae subscribed.Aug 18 2024, 5:03 PM
Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)) board.Aug 19 2024, 12:51 PM
AntiCompositeNumber subscribed.Aug 19 2024, 11:03 PM

Can we get this backported ASAP? Special:DeletedContributions is a critical administrative tool.

gerritbot added a comment.Aug 20 2024, 2:16 AM

Change #1063926 had a related patch set uploaded (by Samtar; author: Máté Szabó):

[mediawiki/core@wmf/1.43.0-wmf.18] Fix DeletedContributions for user names containing spaces

https://gerrit.wikimedia.org/r/1063926

gerritbot added a project: Patch-For-Review.Aug 20 2024, 2:16 AM
TheresNoTime subscribed.Aug 20 2024, 2:21 AM
In T372444#10075918, @AntiCompositeNumber wrote:

Can we get this backported ASAP? Special:DeletedContributions is a critical administrative tool.

Agreed – have cherry picked & will backport in a few hours unless there's any objections..

gerritbot added a comment.Aug 20 2024, 12:06 PM

Change #1063926 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.18] Fix DeletedContributions for user names containing spaces

https://gerrit.wikimedia.org/r/1063926

Stashbot added a comment.Aug 20 2024, 12:08 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-20T12:08:08Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1063926|Fix DeletedContributions for user names containing spaces (T372444)]], [[gerrit:1064004|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]], [[gerrit:1064002|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]]

Stashbot mentioned this in T370413: Contributions are not shown for usemod-style IP address octets that end with xxx.Aug 20 2024, 12:08 PM
Stashbot added a comment.Aug 20 2024, 12:12 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-20T12:12:09Z] <dreamyjazz@deploy1003> dreamyjazz, samtar: Backport for [[gerrit:1063926|Fix DeletedContributions for user names containing spaces (T372444)]], [[gerrit:1064004|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]], [[gerrit:1064002|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Aug 20 2024, 12:19 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-20T12:19:47Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:1063926|Fix DeletedContributions for user names containing spaces (T372444)]], [[gerrit:1064004|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]], [[gerrit:1064002|Allow ContributionsSpecialPage to accept usemodwiki IP addresses (T370413)]] (duration: 11m 38s)

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.18; 2024-08-13); removed MW-1.43-notes (1.43.0-wmf.19; 2024-08-20).Aug 20 2024, 1:00 PM
AntiCompositeNumber added a subscriber: Dreamy_Jazz.Aug 20 2024, 3:23 PM

Thank you @TheresNoTime and @Dreamy_Jazz for the backport and deploy. I'm seeing deleted contributions as expected now.

• mszabo closed this task as Resolved.Aug 21 2024, 10:33 AM
• mszabo set Final Story Points to 2.
• mszabo moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)) board.
Ammarpad mentioned this in T379515: Special:Contributions/0 doesn't work.Nov 11 2024, 10:51 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 11 2024, 11:30 AM
gerritbot added a comment.Sep 10 2025, 6:05 PM

Change #1187057 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] DeletedContribsPager: Use the UserIdentity object instead of the raw target string

https://gerrit.wikimedia.org/r/1187057

gerritbot added a project: Patch-For-Review.Sep 10 2025, 6:05 PM
Func mentioned this in T404230: Special:Contributions and Special:Logs unable to filter entries by imported actors.Sep 10 2025, 6:07 PM
Maintenance_bot added a project: MW-Interfaces-Team.Sep 10 2025, 6:30 PM
gerritbot added a comment.Sep 13 2025, 7:36 PM

Change #1187057 merged by jenkins-bot:

[mediawiki/core@master] DeletedContribsPager: Use the UserIdentity object instead of the raw target string

https://gerrit.wikimedia.org/r/1187057

Maintenance_bot removed a project: Patch-For-Review.Sep 13 2025, 8:31 PM
gerritbot added a comment.Sep 14 2025, 1:34 AM

Change #1187964 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@REL1_43] DeletedContribsPager: Use the UserIdentity object instead of the raw target string

https://gerrit.wikimedia.org/r/1187964

gerritbot added a project: Patch-For-Review.Sep 14 2025, 1:34 AM
gerritbot added a comment.Sep 14 2025, 1:46 AM

Change #1187965 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@REL1_44] DeletedContribsPager: Use the UserIdentity object instead of the raw target string

https://gerrit.wikimedia.org/r/1187965

gerritbot added a comment.Sep 14 2025, 1:56 PM

Change #1187964 merged by jenkins-bot:

[mediawiki/core@REL1_43] DeletedContribsPager: Use the UserIdentity object instead of the raw target string

https://gerrit.wikimedia.org/r/1187964

gerritbot added a comment.Sep 14 2025, 1:56 PM

Change #1187965 merged by jenkins-bot:

[mediawiki/core@REL1_44] DeletedContribsPager: Use the UserIdentity object instead of the raw target string

https://gerrit.wikimedia.org/r/1187965

Maintenance_bot removed a project: Patch-For-Review.Sep 14 2025, 2:30 PM
ScottishFinnishRadish unsubscribed.Sep 14 2025, 2:31 PM
matmarex subscribed.Sep 15 2025, 1:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits