Page MenuHomePhabricator

Lots of "SQL query did not specify the caller" warnings
Closed, ResolvedPublic

Description

When running populateCentralCheckUserIndexTables.php on group0 wikis, I saw a lot of warnings about the SQL query not providing a caller.

Example warning: https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-mediawiki-1-7.0.0-1-2024.09.19?id=kAI4C5IBRIa8zbfsU34k

We should specify the caller in the query builder that is missing it to avoid creating too many warnings.

Event Timeline

Dreamy_Jazz renamed this task from Lots of SQL query did not specify the caller warnings to Lots of "SQL query did not specify the caller" warnings.Sep 19 2024, 5:02 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz updated the task description. (Show Details)

Change #1074223 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add ::caller to queries in populateCentralCheckUserIndexTables.php

https://gerrit.wikimedia.org/r/1074223

Change #1074241 had a related patch set uploaded (by Kosta Harlan; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@wmf/1.43.0-wmf.23] Add ::caller to queries in populateCentralCheckUserIndexTables.php

https://gerrit.wikimedia.org/r/1074241

Change #1074223 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add ::caller to queries in populateCentralCheckUserIndexTables.php

https://gerrit.wikimedia.org/r/1074223

Change #1074241 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@wmf/1.43.0-wmf.23] Add ::caller to queries in populateCentralCheckUserIndexTables.php

https://gerrit.wikimedia.org/r/1074241

Mentioned in SAL (#wikimedia-operations) [2024-09-19T20:27:39Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1074241|Add ::caller to queries in populateCentralCheckUserIndexTables.php (T375221)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-19T20:29:27Z] <dreamyjazz@deploy1003> kharlan, dreamyjazz: Backport for [[gerrit:1074241|Add ::caller to queries in populateCentralCheckUserIndexTables.php (T375221)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-09-19T20:34:29Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:1074241|Add ::caller to queries in populateCentralCheckUserIndexTables.php (T375221)]] (duration: 06m 50s)