Page MenuHomePhabricator

Nearby articles do not work
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Press show nearby pages

What happens?:
Nothing happens. It does ask for permission for my location first time it happened, but after that nothing happens. Here’s video proof.

What should have happened instead?:
It should have actually worked! It should have told me events around me which were notable enough to have a Wikipedia page, Like this:


Okay, I’ll admit, I am in a boring place.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
iOS 18.0.1
Other information (browser name/version, screenshots, etc.):
Chrome

By the way, this is Test wiki, so it has nothing to do with the main wiki, which is why it is simple English.

Requirement

Fix the issue where the Nearby articles feature on simple.m.wikipedia.beta.wmflabs.org is not showing notable nearby Wikipedia pages as expected when accessed via the mobile interface.

BDD

Feature: Nearby articles function

  Scenario: Viewing nearby Wikipedia articles on mobile
    Given the user is on simple.m.wikipedia.beta.wmflabs.org
    And they press the "Nearby" icon from the menu
    When they press "Show nearby pages"
    Then the system should display notable nearby Wikipedia articles.

Test Steps

Test Case 1: Verify Nearby articles functionality

  1. Go to https://simple.m.wikipedia.beta.wmflabs.org.
  2. Press the three-line button (menu).
  3. Press the Nearby icon to search for nearby articles.
  4. Press “Show nearby pages.”
  5. AC1: Confirm that notable nearby Wikipedia pages are displayed.

QA Results - Beta

ACStatusDetails
1T377672#10252207

QA Results - Prod

ACStatusDetails
1T377672#10260766

Event Timeline

Is it possible that simple on beta just doesn't have any articles actually anywhere near you?

For example, it should only show things within a 10KM range..

Do you have an examples of pages it should've shown? Do they have coordinates properly assigned etc?

If I look for me, the town I live in, doesn't have an article on simple beta, and therefore statistically, there's gonna be little else within that 10km range that might

Except, it should still be wired up to production enwiki - https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings-labs.php

		'wgNearbyPagesUrl' => [
			'default' => 'https://en.wikipedia.org/w/api.php',
			'wikidatawiki'  => 'https://www.wikidata.org/w/api.php',
			'testwikidatawiki' => 'https://www.wikidata.org/w/api.php',
		],

I don't see any attempts to actually do an API request

Screenshot 2024-10-20 at 15.37.10.png (580×1 px, 163 KB)

But yet

Screenshot 2024-10-20 at 15.38.18.png (68×487 px, 16 KB)

I think it is related to that "Too many calls to Location or History APIs within a short timeframe."

Which suggests two issues. One, the browser console shouldn't be the only place this is surfaced. It should be trapped and displayed to the user.

And the underlying issue why it seems to be constantly showing that...

Change #1081707 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Revert "mediawiki.router: Call onRouterHashChange after push/replaceState"

https://gerrit.wikimedia.org/r/1081707

Jdlrobson subscribed.

There is an error in the console. git bisect points to the above patch (I'll follow up tomorrow):

jquery.js:3783 jQuery.Deferred exception: Maximum call stack size exceeded RangeError: Maximum call stack size exceeded
    at Router.onRouterHashChange (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:1:554)
    at Router.navigateTo (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:2:188)
    at Proxy.loadPages (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=%40w…e%7Cext.nearby.scripts%7Cmobile.startup&skin=minerva&version=13mz8:648:835)
    at Router.<anonymous> (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=%40w…e%7Cext.nearby.scripts%7Cmobile.startup&skin=minerva&version=13mz8:647:489)
    at Router.checkRoute (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:1:949)
    at Router.onRouterHashChange (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:1:663)
    at Router.navigateTo (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:2:188)
    at Proxy.loadPages (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=%40w…e%7Cext.nearby.scripts%7Cmobile.startup&skin=minerva&version=13mz8:648:835)
    at Router.<anonymous> (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=%40w…e%7Cext.nearby.scripts%7Cmobile.startup&skin=minerva&version=13mz8:647:489)
    at Router.checkRoute (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:1:949) undefined

For those who don’t understand, there should be a picture saying this:

IMG_0140.png (1×2 px, 205 KB)

But it shows nothing. Absolutely nothing. No uh oh! No Wikipedia article nearby you are something like that. Just the button shows it’s being clicked and that’s it!

Change #1081965 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] Follow-up I7e66bd7517: Only emit onRouterHashChange when the hash changes

https://gerrit.wikimedia.org/r/1081965

There is an error in the console. git bisect points to the above patch (I'll follow up tomorrow):

Thanks for the investigation. It looks like @Krinkle is happy to review these if it is a distraction for you. I have a fix but we can also revert and try later.

Change #1081965 merged by jenkins-bot:

[mediawiki/core@master] Follow-up I7e66bd7517: Only emit onRouterHashChange when the hash changes

https://gerrit.wikimedia.org/r/1081965

@Esanders Hello. I'm on train duty this wek and @Jdlrobson added this task as a train blocker. Can you ensure that the relevant fix is backported to the wmf/1.43.0-wmf.28 branch?

@Esanders Hello. I'm on train duty this wek and @Jdlrobson added this task as a train blocker. Can you ensure that the relevant fix is backported to the wmf/1.43.0-wmf.28 branch?

Disregard this. The .28 branch hasn't been created yet.

Disregard this. The .28 branch hasn't been created yet.

I was going to say :) It has been merged any the feature appears to be working fine on beta.

Change #1081707 abandoned by Jdlrobson:

[mediawiki/core@master] Revert "mediawiki.router: Call onRouterHashChange after push/replaceState"

Reason:

Thanks Ed! Abandoning now https://gerrit.wikimedia.org/r/q/I8f4ed957a4 has been merged.

https://gerrit.wikimedia.org/r/1081707

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS
Browser: Chrome
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Case 1: Verify Nearby articles functionality

  1. Go to https://simple.m.wikipedia.beta.wmflabs.org.
  2. Press the three-line button (menu).
  3. Press the Nearby icon to search for nearby articles.
  4. Press “Show nearby pages.”
  5. AC1: Confirm that notable nearby Wikipedia pages are displayed.

screenshot 33.mov.gif (1×1 px, 485 KB)

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS 15.0
Browser: Chrome 130
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Case 1: Verify Nearby articles functionality

  1. Go to https://simple.m.wikipedia.org.
  2. Press the three-line button (menu).
  3. Press the Nearby icon to search for nearby articles.
  4. Press “Show nearby pages.”
  5. AC1: Confirm that notable nearby Wikipedia pages are displayed.

2024-10-24_13-59-19.mp4.gif (1×1 px, 855 KB)

Leaving open so we can give estimate before closing.

ovasileva set the point value for this task to 1.

Put 1 point on it for the QA effort. Resolving!

Note: it only shows normal English language Wikipedia pages

Note: it only shows normal English language Wikipedia pages

If you are referring to beta cluster, yes that's correct and by design. If you'd like to display that functionality you can follow the https://wikitech.wikimedia.org/wiki/Wikimedia_site_requests policy and reconfigure https://github.com/wikimedia/operations-mediawiki-config/blob/ae52a7b24bd24f9220377559165c0e7a9c06ec4a/wmf-config/InitialiseSettings-labs.php#L2107 on a per site basis. Hope this helps!