Page MenuHomePhabricator
Create Task
Maniphest T380071

[wmf.3] GuidedTours are broken (originally: Homepage: No intro tours for new accounts)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue

  • Create a new account on any wiki (tested on testwiki and guwiki)
  • Special:Welcome page is correctly displayed and a user have a prompt to go to Special:Homepage

What happens?:

  • Special:Homepage is displayed correctly but a new user doesn't see the intro tours
  • the Console error is displayed
jquery.js:3783 jQuery.Deferred exception: Cannot read properties of undefined (reading 'isSinglePage') TypeError: Cannot read properties of undefined (reading 'isSinglePage')
    at Step.handleOnShow (https://gu.wikipedia.org/w/load.php?lang=gu&modules=%40wikimedia%2Fcodex%2C…styles.icons-content%2Cicons-media&skin=vector-2022&version=ru901:1176:813)
    at options.onShow (https://gu.wikipedia.org/w/load.php?lang=gu&modules=%40wikimedia%2Fcodex%2C…styles.icons-content%2Cicons-media&skin=vector-2022&version=ru901:1179:369)
    at mw.libs.guiders.guiders.show (https://gu.wikipedia.org/w/load.php?lang=gu&modules=%40wikimedia%2Fcodex%2C…styles.icons-content%2Cicons-media&skin=vector-2022&version=ru901:1215:105)
    at https://gu.wikipedia.org/w/load.php?lang=gu&modules=%40wikimedia%2Fcodex%2C…styles.icons-content%2Cicons-media&skin=vector-2022&version=ru901:1185:180
    at fire (https://gu.wikipedia.org/w/load.php?lang=gu&modules=%40wikimedia%2Fcodex%2C….styles.icons-content%2Cicons-media&skin=vector-2022&version=ru901:198:705)
    at fireWith (https://gu.wikipedia.org/w/load.php?lang=gu&modules=%40wikimedia%2Fcodex%2C….styles.icons-content%2Cicons-media&skin=vector-2022&version=ru901:199:903)
    at mightThrow (https://gu.wikipedia.org/w/load.php?lang=gu&modules=%40wikimedia%2Fcodex%2C….styles.icons-content%2Cicons-media&skin=vector-2022&version=ru901:202:252)
    at process (https://gu.wikipedia.org/w/load.php?lang=gu&modules=%40wikimedia%2Fcodex%2C….styles.icons-content%2Cicons-media&skin=vector-2022&version=ru901:202:309) undefined

What should have happened instead?:

  • the intro tours should be displayed to new users landing on Special:Homepage

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
fix tours by finishing partial variable renamemediawiki/extensions/GuidedTourwmf/1.44.0-wmf.3+3 -3
fix tours by finishing partial variable renamemediawiki/extensions/GuidedTourmaster+3 -3
Add Cypress test to confirm tours workingmediawiki/extensions/GuidedTourmaster+3 K -66
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Nov 15 2024, 4:35 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 15 2024, 4:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF triaged this task as High priority.Nov 16 2024, 6:56 PM
Urbanecm_WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Michael added a project: MediaWiki-extensions-GuidedTour.Nov 18 2024, 10:02 AM

Maybe even all tours are broken! At least I tested it with the built-in ?tour=uprightdownleft and it fails with the same error

Michael claimed this task.Nov 18 2024, 10:18 AM
Michael moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.
Michael added a project: The-Wikipedia-Adventure.
Michael added a subscriber: Pppery.

All tours are indeed broken everywhere, including The-Wikipedia-Adventure. Will upload a fix.

Restricted Application added a project: User-Michael. · View Herald TranscriptNov 18 2024, 10:18 AM
Michael renamed this task from [wmf.3] Homepage: No intro tours for new accounts to [wmf.3] GuidedTours are broken (originally: Homepage: No intro tours for new accounts).Nov 18 2024, 10:19 AM
gerritbot added a comment.Nov 18 2024, 10:22 AM

Change #1092200 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GuidedTour@master] fix tours by finishing partial variable rename

https://gerrit.wikimedia.org/r/1092200

gerritbot added a project: Patch-For-Review.Nov 18 2024, 10:22 AM
Michael added a comment.Nov 18 2024, 11:22 AM

Caused by Remove unnecessary local context variables.

gerritbot added a comment.Nov 18 2024, 12:12 PM

Change #1092200 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] fix tours by finishing partial variable rename

https://gerrit.wikimedia.org/r/1092200

gerritbot added a comment.Nov 18 2024, 12:19 PM

Change #1092207 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GuidedTour@master] Add Cypress test to confirm tours working

https://gerrit.wikimedia.org/r/1092207

Michael moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Nov 18 2024, 12:20 PM

Added a browser-test to prevent this from happening again.

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.4; 2024-11-19).Nov 18 2024, 1:00 PM
gerritbot added a comment.Nov 18 2024, 1:34 PM

Change #1092207 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Add Cypress test to confirm tours working

https://gerrit.wikimedia.org/r/1092207

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Nov 18 2024, 1:38 PM

Both merged, thanks @Michael! Should we backport this?

Maintenance_bot removed a project: Patch-For-Review.Nov 18 2024, 2:30 PM
Michael added a comment.Nov 18 2024, 4:04 PM
In T380071#10331230, @Urbanecm_WMF wrote:

Both merged, thanks @Michael! Should we backport this?

Sorry, seeing this only now. Yeah, backporting makes sense to me, otherwise we would need to wait till Thursday for it to roll out to most Wikipedias.

Pppery removed a project: The-Wikipedia-Adventure.Nov 18 2024, 4:45 PM

Thanks for the notice, but I don't think general GuidedTour issues should have that project tag. And I'm already watching MediaWiki-extensions-GuidedTour so don't need to be manually subscribed.

gerritbot added a comment.Nov 19 2024, 7:56 AM

Change #1092741 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GuidedTour@wmf/1.44.0-wmf.3] fix tours by finishing partial variable rename

https://gerrit.wikimedia.org/r/1092741

gerritbot added a project: Patch-For-Review.Nov 19 2024, 7:56 AM
gerritbot added a comment.Nov 19 2024, 8:23 AM

Change #1092741 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@wmf/1.44.0-wmf.3] fix tours by finishing partial variable rename

https://gerrit.wikimedia.org/r/1092741

Maintenance_bot removed a project: Patch-For-Review.Nov 19 2024, 8:31 AM
Stashbot mentioned this in T375392: Modify the user group application form on Meta.Nov 19 2024, 8:34 AM

Mentioned in SAL (#wikimedia-operations) [2024-11-19T08:34:04Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1092741|fix tours by finishing partial variable rename (T380071)]], [[gerrit:1092364|affcom contactpages: Fix Letter of intent and logo field labels (T375392)]], [[gerrit:1092743|Add nowiki to commonsuploads dblist (T380252)]]

Stashbot mentioned this in T380252: Add nowiki to commonsuploads dblist.Nov 19 2024, 8:34 AM
Stashbot added a comment.Nov 19 2024, 8:39 AM

Mentioned in SAL (#wikimedia-operations) [2024-11-19T08:39:41Z] <urbanecm@deploy2002> ammarpad, migr, jhsoby, urbanecm: Backport for [[gerrit:1092741|fix tours by finishing partial variable rename (T380071)]], [[gerrit:1092364|affcom contactpages: Fix Letter of intent and logo field labels (T375392)]], [[gerrit:1092743|Add nowiki to commonsuploads dblist (T380252)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Nov 19 2024, 8:48 AM

Mentioned in SAL (#wikimedia-operations) [2024-11-19T08:48:34Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1092741|fix tours by finishing partial variable rename (T380071)]], [[gerrit:1092364|affcom contactpages: Fix Letter of intent and logo field labels (T375392)]], [[gerrit:1092743|Add nowiki to commonsuploads dblist (T380252)]] (duration: 14m 29s)

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.3; 2024-11-12); removed MW-1.44-notes (1.44.0-wmf.4; 2024-11-19).Nov 19 2024, 9:00 AM
Etonkovidova closed this task as Resolved.Nov 19 2024, 4:48 PM

Checked Growth Homepage intro tours on beta and on testwiki wmf.4 - works as expected.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits