Page MenuHomePhabricator

[wmf.6] Surfacing Add link highlight is not shown in some sections
Open, Needs TriagePublic

Description

Notes:

  • I checked only frwiki. It could be that the issue is not present on other pilot wikis.
  • It's not the case when only one highlight is displayed. On many articles all three highlights are present. It seems that links in some articles' sub-sections do not get highlight.
  • I checked "List of excluded sections from the Add link task" on Spécial:Configuration_communautaire/GrowthSuggestedEdits does exclude Références and Bibliographie sections. And, in any case, since add links are present in Suggested edit mode, they should be highlighted in reading mode .

Steps:

  1. On frwiki wmf.6 create a new account (make sure that that new user doesn't make any edits).
  2. On Special:Homepage see Add link suggested articles.
  3. Select one title of suggested articles and go to that article via Search (not via Specia:Homepage).

Note: From here I 'll use a specific example - https://fr.m.wikipedia.org/wiki/La_République

  1. In La_République article there are two highlighted add link suggestions - que l’idée apparaît [[ridicule]] pour le moment and Socrate reconnaît dans cette [[métaphore]] la manière

What happened:

  • when a user clicks on a highlighted suggestion, Add link editing surface will display three suggested links, not two.

The third link is in Annexes section under`Articles connexes` - dans laquelle l'auteur imagine que les États-Unis ne choisiraient plus

mobile frwiki wmf.6frwiki wmf.6
add link is not highlighted
Screen Shot 2024-12-09 at 2.54.21 PM.png (492×514 px, 72 KB)
in Suggested editing mode the link is present
Screen Shot 2024-12-09 at 3.07.50 PM.png (636×472 px, 86 KB)

More examples:

LinkDesktop - add links are presentMobile - the highlight for a link is not present
Pierre_Decock
Screen Shot 2024-12-09 at 5.53.16 PM.png (1×1 px, 423 KB)
(animated gif)
highlight_partially working.gif (734×451 px, 650 KB)
DuBouillon
Screen Shot 2024-12-09 at 5.26.30 PM.png (1×1 px, 529 KB)
Screen Shot 2024-12-09 at 5.26.15 PM.png (731×417 px, 108 KB)
Bernard Darras
Screen Shot 2024-12-09 at 5.32.11 PM.png (1×2 px, 547 KB)
Screen Shot 2024-12-09 at 5.32.52 PM.png (603×331 px, 95 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1101817 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(surfacing): Show highlights in lists as well

https://gerrit.wikimedia.org/r/1101817

Adding another test case (testwiki wmf.6) to check after the fix is in place:

Screen Shot 2024-12-11 at 8.23.43 AM.png (1×812 px, 193 KB)
Screen Shot 2024-12-11 at 8.24.45 AM.png (1×2 px, 380 KB)

Change #1101817 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(surfacing): Show highlights in lists as well

https://gerrit.wikimedia.org/r/1101817

Change #1104633 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.6] fix(surfacing): Show highlights in lists as well

https://gerrit.wikimedia.org/r/1104633

Change #1104633 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.6] fix(surfacing): Show highlights in lists as well

https://gerrit.wikimedia.org/r/1104633

Mentioned in SAL (#wikimedia-operations) [2024-12-16T15:04:23Z] <ladsgroup@deploy2002> Started scap sync-world: Backport for [[gerrit:1104629|Kick bundlesize out of package.json (T382192 T360590)]], [[gerrit:1104633|fix(surfacing): Show highlights in lists as well (T381841)]], [[gerrit:1104624|stats(surfacing): track link recommendation api recommendations (T378536)]]

Mentioned in SAL (#wikimedia-operations) [2024-12-16T15:09:08Z] <ladsgroup@deploy2002> migr, ladsgroup: Backport for [[gerrit:1104629|Kick bundlesize out of package.json (T382192 T360590)]], [[gerrit:1104633|fix(surfacing): Show highlights in lists as well (T381841)]], [[gerrit:1104624|stats(surfacing): track link recommendation api recommendations (T378536)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-12-16T15:15:54Z] <ladsgroup@deploy2002> Finished scap sync-world: Backport for [[gerrit:1104629|Kick bundlesize out of package.json (T382192 T360590)]], [[gerrit:1104633|fix(surfacing): Show highlights in lists as well (T381841)]], [[gerrit:1104624|stats(surfacing): track link recommendation api recommendations (T378536)]] (duration: 11m 30s)