Page MenuHomePhabricator
Create Task
Maniphest T378536

Surfacing structured tasks: Create a proof of concept solution for generating Add Link suggestions on-the-fly
Open, HighPublic5 Estimated Story Points
Actions

Description

Background & Problem

Growth intends to surface Add Link tasks in read mode (T362584). Unfortunately, the task pool doesn't contain a suggestion for all articles (we stop enlarging it once it reaches 500 articles/topic, see the refreshLinkRecommendations.php maintenance script). One of the solutions to this problem is to attempt to generate a task recommendation on the fly,

Solution

Within this task, we should attempt to create an Add Link suggestion while the user read the article. Once the suggestion is available, the Add Link session can start. This can be a prototype level solution, locked behind the wgGESurfacingStructuredTasksEnabled feature flag. The goal here would to evaluate the speed and usability of the solution (can we generate recommendations quickly enough?).

Timebox: ~5 points (requires both investigation, communication, and advising on next steps)

Details

SubjectRepoBranchLines +/-
beta: enable updating link-suggestions from read-modeoperations/mediawiki-configmaster+7 -0
feat(surfacing): request link recommendations while readingmediawiki/extensions/GrowthExperimentsmaster+42 -0
stats(surfacing): track link recommendation api recommendationsmediawiki/extensions/GrowthExperimentswmf/1.44.0-wmf.6+21 -0
stats(surfacing): track link recommendation api recommendationsmediawiki/extensions/GrowthExperimentsmaster+21 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Oct 29 2024, 7:38 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 29 2024, 7:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF added a parent task: T362584: [EPIC] Surface Structured Tasks to new editors within or alongside VisualEditor (FY24/25 WE1.2.3 & WE1.2.6).Oct 29 2024, 7:38 PM
KStoller-WMF added a project: Growth-Structured-Tasks.Oct 29 2024, 8:28 PM
KStoller-WMF triaged this task as Medium priority.Nov 1 2024, 6:24 PM
KStoller-WMF moved this task from Inbox to Up Next on the Growth-Team board.
KStoller-WMF raised the priority of this task from Medium to High.Wed, Dec 4, 4:52 PM
KStoller-WMF updated the task description. (Show Details)Tue, Dec 10, 5:08 PM
KStoller-WMF set the point value for this task to 5.
KStoller-WMF moved this task from Up Next to Current Sprint on the Growth-Team board.Tue, Dec 10, 5:57 PM
KStoller-WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Michael claimed this task.Wed, Dec 11, 5:09 PM
Michael moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.
Restricted Application added a project: User-Michael. · View Herald TranscriptWed, Dec 11, 5:09 PM
gerritbot added a comment.Thu, Dec 12, 12:14 PM

Change #1102796 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] PoC(surfacing): request link recommendations while reading

https://gerrit.wikimedia.org/r/1102796

gerritbot added a project: Patch-For-Review.Thu, Dec 12, 12:14 PM
Michael moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Thu, Dec 12, 12:22 PM

The proof of concept was surprisingly easy to get working. Locally, the request takes only about a second, though I did not try it out with very long pages.

Curious what you all think about this!

Michael added a comment.Thu, Dec 12, 1:30 PM

I think some of the thoughts from T378527#10384905 are relevant for this approach as well. Especially: can we somehow store that we have no suggestions for the combination of revision-id+config-hash+model-hash? That way, we would likely skip a lot of requests to the link-recommendation service coming from this approach here.

gerritbot added a comment.Thu, Dec 12, 5:43 PM

Change #1102909 had a related patch set uploaded (by Michael Große; author: Michael Große):

[operations/mediawiki-config@master] beta: enable updating link-suggestions from read-mode

https://gerrit.wikimedia.org/r/1102909

KStoller-WMF mentioned this in T378233: Alpha test analysis: Surfacing Structured Tasks experiment (WE1.2.6).Thu, Dec 12, 10:01 PM
gerritbot added a comment.Mon, Dec 16, 10:40 AM

Change #1104602 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] stats(surfacing): track link recommendation api recommendations

https://gerrit.wikimedia.org/r/1104602

gerritbot added a comment.Mon, Dec 16, 12:14 PM

Change #1104602 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] stats(surfacing): track link recommendation api recommendations

https://gerrit.wikimedia.org/r/1104602

Michael mentioned this in T382251: Make generating Add Link suggestions on-the-fly production ready.Mon, Dec 16, 12:27 PM
Michael added a parent task: T382251: Make generating Add Link suggestions on-the-fly production ready.
gerritbot added a comment.Mon, Dec 16, 12:50 PM

Change #1104624 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.6] stats(surfacing): track link recommendation api recommendations

https://gerrit.wikimedia.org/r/1104624

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Mon, Dec 16, 1:00 PM
gerritbot added a comment.Mon, Dec 16, 3:02 PM

Change #1104624 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.6] stats(surfacing): track link recommendation api recommendations

https://gerrit.wikimedia.org/r/1104624

Stashbot mentioned this in T382192: CI is broken for lots of MW repos due to extension/Popups explicitly requiring node 18.Mon, Dec 16, 3:04 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-16T15:04:23Z] <ladsgroup@deploy2002> Started scap sync-world: Backport for [[gerrit:1104629|Kick bundlesize out of package.json (T382192 T360590)]], [[gerrit:1104633|fix(surfacing): Show highlights in lists as well (T381841)]], [[gerrit:1104624|stats(surfacing): track link recommendation api recommendations (T378536)]]

Stashbot mentioned this in T360590: [EPIC] Create a set of tests for defining a performance budget.Mon, Dec 16, 3:04 PM
Stashbot mentioned this in T381841: [wmf.6] Surfacing Add link highlight is not shown in some sections.
Stashbot added a comment.Mon, Dec 16, 3:09 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-16T15:09:08Z] <ladsgroup@deploy2002> migr, ladsgroup: Backport for [[gerrit:1104629|Kick bundlesize out of package.json (T382192 T360590)]], [[gerrit:1104633|fix(surfacing): Show highlights in lists as well (T381841)]], [[gerrit:1104624|stats(surfacing): track link recommendation api recommendations (T378536)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mon, Dec 16, 3:15 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-16T15:15:54Z] <ladsgroup@deploy2002> Finished scap sync-world: Backport for [[gerrit:1104629|Kick bundlesize out of package.json (T382192 T360590)]], [[gerrit:1104633|fix(surfacing): Show highlights in lists as well (T381841)]], [[gerrit:1104624|stats(surfacing): track link recommendation api recommendations (T378536)]] (duration: 11m 30s)

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.6; 2024-12-03); removed MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Mon, Dec 16, 4:00 PM
gerritbot added a comment.Mon, Dec 16, 8:52 PM

Change #1102796 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] feat(surfacing): request link recommendations while reading

https://gerrit.wikimedia.org/r/1102796

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.8; 2024-12-17); removed MW-1.44-notes (1.44.0-wmf.6; 2024-12-03).Mon, Dec 16, 9:00 PM
ppelberg awarded a token.Mon, Dec 16, 9:45 PM
ppelberg subscribed.
gerritbot added a comment.Tue, Dec 17, 2:27 PM

Change #1102909 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: enable updating link-suggestions from read-mode

https://gerrit.wikimedia.org/r/1102909

Stashbot added a comment.Tue, Dec 17, 2:27 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-17T14:27:58Z] <dcausse@deploy2002> Started scap sync-world: Backport for [[gerrit:1102909|beta: enable updating link-suggestions from read-mode (T378536)]]

Maintenance_bot removed a project: Patch-For-Review.Tue, Dec 17, 2:30 PM
Stashbot added a comment.Tue, Dec 17, 2:34 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-17T14:34:27Z] <dcausse@deploy2002> migr, dcausse: Backport for [[gerrit:1102909|beta: enable updating link-suggestions from read-mode (T378536)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Tue, Dec 17, 2:46 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-17T14:46:24Z] <dcausse@deploy2002> Finished scap sync-world: Backport for [[gerrit:1102909|beta: enable updating link-suggestions from read-mode (T378536)]] (duration: 18m 26s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits