| Etonkovidova | |
| Dec 19 2024, 12:13 AM |
| F58028829: Screen Shot 2024-12-18 at 3.51.52 PM.png | |
| Dec 19 2024, 12:13 AM |
| F58028825: Screen Shot 2024-12-18 at 3.52.30 PM.png | |
| Dec 19 2024, 12:13 AM |
| F58028820: Screen Shot 2024-12-18 at 1.26.44 PM.png | |
| Dec 19 2024, 12:13 AM |
Notice: The issue is present only after Echo notification flyout menu was open.
Steps
After reloading a page, hovering over the badges won't show the issue:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Sgs | T366760 [EPIC] Dark mode for Growth team maintained features | |||
| Resolved | Jdlrobson-WMF | T382463 [wmf.8] Dark mode: low contrast for hover over Echo notifications badges and counter | |||
| Resolved | BUG REPORT | None | T343838 Echo should progressively enhance existing notification icon rather than creating its own |
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
Removing from Web team since Growth team already estimated this (lower than we did).
It seems like when Echo enhances these buttons to be OOUI it should also drop cdx-button cdx-button--weight-quiet cdx-button--icon-only cdx-button--fake-button cdx-button--fake-button--enabled to avoid conflicts between OOUI and Codex.
Given this just adds more technical debt on top of existing technical debt, I do recommend this is declined or stalled on T343838.
I don't think that this is going to appear on our roadmap anytime soon, unless someone pushes for it, so I'll gladly mark it as stalled in favor of T343838 being done by web. After that is done, then this task can probably closed as well.