Page MenuHomePhabricator

Diffs of trailing newlines addition and removal don't work properly
Open, LowPublic

Description

Split from T44616, diffs of the removal of trailing newlines should work, even though such diffs are rare. Example diff: https://test.wikipedia.org/w/index.php?title=Some_page_title&diff=prev&oldid=152897.

This diff should show that the page went from #REDIRECT [[Foo]]\n\n to #REDIRECT [[Foo]]\n. Instead, it pretends as though there were no changes to the wikitext of the page at all! This is incorrect diff behavior.


Version: 1.34.x
Severity: minor

Details

Reference
bz42669

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:44 AM
bzimport set Reference to bz42669.
bzimport added a subscriber: Unknown Object (MLST).

I believe this same issue changes \r\n to \n without a visible diff, but I'm not completely sure.

I noticed this bug with this diff. I have to wonder if at some point the software is trimming the wikitext.