Page MenuHomePhabricator

Diffs of trailing newlines addition and removal don't work properly
Open, LowPublic


Split from T44616, diffs of the removal of trailing newlines should work, even though such diffs are rare. Example diff:

This diff should show that the page went from #REDIRECT [[Foo]]\n\n to #REDIRECT [[Foo]]\n. Instead, it pretends as though there were no changes to the wikitext of the page at all! This is incorrect diff behavior.

Version: 1.34.x
Severity: minor



Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:44 AM
bzimport added a project: MediaWiki-Page-Diffs.
bzimport set Reference to bz42669.
bzimport added a subscriber: Unknown Object (MLST).
MZMcBride created this task.Dec 4 2012, 4:30 AM

This is also true for diffs of trailing newline additions, and I've modified the summary accordingly:

Also see this discussion:

I believe this same issue changes \r\n to \n without a visible diff, but I'm not completely sure.

Aklapper updated the task description. (Show Details)Aug 10 2019, 5:02 PM
Aklapper removed a subscriber: wikibugs-l-list.