Page MenuHomePhabricator

VisualEditor: Tools to set/unset text with annotations (tracker)
Closed, DeclinedPublic

Description

Given that these all exist in DM, it's "just" a question of making a set of icons for each function and adding it to the tool bar (and then working out what to do with a toolbar with eight such icons when we wanted two.

Have left off from the existing list in ve.dm.TextStyleAnnotation.js:

  • span - as that'll need to be a distinct bug given the complexity (it'll need at least an inspector, possibly a dialog)
  • strong/em - should we just silently use these instead of b/i (or vice versa)? Either way, it feels confusing to give the user both options.

Version: unspecified
Severity: enhancement

Details

Reference
bz47780

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:16 AM
bzimport set Reference to bz47780.

Related URL: https://gerrit.wikimedia.org/r/64475 (Gerrit Change I2f317e1dda2c2e2fceac401768c732dae02e83ce)

Icons for these are now merged into master; the outstanding work here is relatively light, except for the overall design issue about the toolbar having too many buttons.

Related URL: https://gerrit.wikimedia.org/r/64801 (Gerrit Change I51f2605e7d8e2bab1d641f02244d5cd24f505676)