Page MenuHomePhabricator

VisualEditor: "This is a minor edit" is not auto checked in save dialog if the "minordefault" preference is on
Closed, ResolvedPublic

Description

How to reproduce:

  1. Enable the "Mark all edits minor by default" option in the preferences.
  2. Edit a page in the VisualEditor.
  3. Press "Review and save", then "Looks good to me".
  4. The edit summary entering bubble appears.

Observed:

  • The "This is a minor edit" box is not checked.

Expected:

  • The "This is a minor edit" box is checked.

Comment: The saved revision IS correctly marked as minor. It's just the check box that appears incorrectly.

GWT scenario for Cucumber:
Given that I am editing an article while the minordefault preference is on
When I am saving the article
Then the "This is a minor edit" box is checked


Version: unspecified
Severity: normal

Details

Reference
bz48347

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:27 AM
bzimport set Reference to bz48347.
Amire80 created this task.May 11 2013, 5:36 AM

You know, if minoredit preference was killed, this wouldn't be an issue...

(In reply to comment #1)

You know, if minoredit preference was killed, this wouldn't be an issue...

I couldn't agree more :)

Related URL: https://gerrit.wikimedia.org/r/63844 (Gerrit Change Ib5cdcb9433be5ff7b9179d3833f42e5c3453285a)

Merged into master; will go out with wmf5.