Page MenuHomePhabricator

Improve data value validation and error handling in api
Closed, ResolvedPublic

Description

In the SetQualifier module, I gave it invalid data value input (and it was being handled incorrectly in the api). I got back an exception with full stack trace in the api result.

Generally speaking, in a number of places, the api is also doing insufficient validation and error handling of the data values. The api user should *not* see an exception in the api error output. Any exceptions due to invalid value input should be caught and translated into a proper api error message and code.

(See also related bug 48864 and bug 48473)


Version: master
Severity: normal

Details

Reference
bz48888

Related Objects

StatusAssignedTask
OpenNone
ResolvedLydia_Pintscher
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
Resolvedadrianheine
ResolvedNone
ResolvedNone
Resolvedadrianheine
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
Resolvedadrianheine
DeclinedNone
DeclinedNone

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:36 AM
bzimport set Reference to bz48888.
bzimport added a subscriber: Unknown Object (MLST).
aude created this task.May 28 2013, 10:59 AM

Making this as depending on 49264. Input validation has improved since this was filed, but it's still possible to trigger a fatal error by submitting a structurally invalid data value.

Closing as this is too general to be useful and we have other bugs for it.