VisualEditor: Incorrect tab text (create vs. edit) shown on Special:MovePage, Special:Undelete, others?
Closed, ResolvedPublic

Description

When attempting to move a page where VisualEditor is enabled (take https://www.mediawiki.org/wiki/Special:MovePage/VisualEditor:Sandbox for an example), the tab "Create source" should be an "Edit source" tab instead.


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66885

--> VisualEditor

Confirmed. It says "Read | Edit | Create source | View history".

https://www.mediawiki.org/wiki/Special:MovePage/Sandbox

Also shown on Special:Undelete, after the page has been restored.

i.e. "User:John Vandenberg/test has been restored" has tabs: Read | Edit | Create source | View history

More importantly, it lets you load VE dynamically, which it shouldn't.

Change 77246 had a related patch set uploaded by Esanders:
Fix edit links on special pages

https://gerrit.wikimedia.org/r/77246

Change 77246 merged by jenkins-bot:
Fix edit links on special pages

https://gerrit.wikimedia.org/r/77246

Change 77253 had a related patch set uploaded by Esanders:
Fix pageExists/isViewPage behaviour

https://gerrit.wikimedia.org/r/77253

Change 77253 merged by jenkins-bot:
mw.ViewPageTarget.init: Fix pageExists/isViewPage behaviour

https://gerrit.wikimedia.org/r/77253

Change 77165 had a related patch set uploaded by Catrope:
Move edit tab generation into PHP and make it more configurable

https://gerrit.wikimedia.org/r/77165

Now fixed and deployed.

I mean, as the page does not exist, shouldn't that read Create source instead, as in http://en.wikipedia.org/wiki/Esempio ?

(In reply to comment #12)

I think I can still see this?
http://en.wikipedia.org/wiki/Special:WhatLinksHere/Esempio
Thanks.

This is caused by (core) bug 53774 which we will need to fix.

Change 82744 had a related patch set uploaded by Jforrester:
Reference core bug 53774 in bug 49000 comment

https://gerrit.wikimedia.org/r/82744

Change 82744 merged by jenkins-bot:
Reference core bug 53774 in bug 49000 comment

https://gerrit.wikimedia.org/r/82744

Is there anything left to do here?

(In reply to Alex Monk from comment #17)

Is there anything left to do here?

This appears fixed for now (albeit as a hack).

Add Comment