Page MenuHomePhabricator

Scroll to an item when it is selected e.g. when it has been newly inserted
Closed, ResolvedPublic8 Estimated Story Points

Description

The bug 51905 made me realize of a potential problem. When a media, say an image, is inserted, sometimes it may be inserted outside the field of view of the user, and this may lead some users to think that it wasn't inserted at all, causing aborted edits, confusion, frustration, and even bad edits. For example if there is an infobox in the article, or a bunch of images aligned to the right, then if the user inserts an image, in many cases it will be inserted below all this, and the user will not see it without scrolling the screen.

The solution to this potential problem is, I think, fairly simple: make the VisualEditor detect if the image is in the field of view of the user, and if it's not, then scroll the screen so that it is!


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=58091

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:05 AM
bzimport set Reference to bz51911.

I experienced the same problem in bug 51863.

A auto-disappearing popup notice "Your image has been inserted; scroll down to see it." would help.

Jdforrester-WMF renamed this task from VisualEditor: Scroll to item when it has been newly-inserted to Scroll to an item when it is selected e.g. when it has been newly inserted.Feb 24 2015, 6:33 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF added subscribers: Romaine, Krenair, Akoopal and 2 others.
Jdforrester-WMF changed the task status from Open to Stalled.Mar 2 2015, 4:34 AM
Jdforrester-WMF changed the task status from Stalled to Open.Mar 20 2015, 7:23 PM

Change 200243 had a related patch set uploaded (by Mooeypoo):
Scroll to newly inserted elements

https://gerrit.wikimedia.org/r/200243

Change 200243 merged by jenkins-bot:
Scroll the selection into view when it is outside the window

https://gerrit.wikimedia.org/r/200243

Checked all Insert menu options in beta (Chrome, FF35, and Safari).

What was checked

  • a cursor placed at the top/bottom of a page and Insert
  • a cursor placed at the bottom of a page - and scroll up and then 'Insert'
  • 'Insert' options for Media Caption
  • 'Undo/Redo' with different cursor positions