Page MenuHomePhabricator

[mediawiki.feedback.js] Resizing the dialog causes submit and cancel buttons to disappear/become detached
Closed, ResolvedPublic1 Estimated Story Points

Description

From en.wp user Cryptic C62:

  1. It is possible to break the "Submit feedback" form by doing the following procedure:
    1. Shrink the browser window so that there is at least an inch or two between the top of the browser and the top of your screen (in other words, don't maximize the window size)
    2. Drag the "Submit feedback" form as far up as it will go
    3. Click and hold the top edge of the form to begin resizing, then drag the mouse up to the top of the screen.
      1. In Monobook, this causes the "submit" and "cancel" buttons to disappear off the bottom of the form.
      2. In Vector, this causes the bottom chunk of the form to become disconnected (see screenshot).

The screenshot is: https://en.wikipedia.org/wiki/File:VE_Feedback_Break.jpg


Version: 1.23.0
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:56 AM
bzimport set Reference to bz52588.

This would be an upstream bug in query.ui.dialog. Feedback dialog is one of the few parts of VE that uses jquery UI dialog.

Moving to MW/JS which is where MW's feedback dialog is managed, I believe..

matmarex set Security to None.
matmarex added a project: VisualEditor.

Still reproducible after recent jQuery UI update.

Isolated test case:

  1. http://s.codepen.io/Krinkle/debug/MYJEYG
  2. Drag the top edge of the dialog to the of the screen (beyond edge, e.g. into address bar)

As soon as the cursor leaves the viewport, the buttons slide down into hidden/unscrollable overflow of the dialog container. Once the cursor is released, this area can't be brought back regardless of repositioning or resizing.

Change 192749 had a related patch set uploaded (by Mooeypoo):
[wip] Refactoring mw.Feedback to work with OOUI elements

https://gerrit.wikimedia.org/r/192749

Change 192749 merged by jenkins-bot:
Refactoring mw.Feedback to work with OOUI elements

https://gerrit.wikimedia.org/r/192749