Page MenuHomePhabricator

VisualEditor: Linktrail & linkprefix appear to be active on zhwiki when they shouldn't be
Closed, DeclinedPublic

Description

Repro:

  1. Create a new page with wikitext "[[中文]]" on zhwiki
  2. VisualEditor-edit this page and type "s" at the end
  3. The whole document now looks as if it has a link to "中文" with text "中文s"
  4. Save the page
  5. Resulting wikitext is "[[中文]]s", and in rendered HTML (both PHP and Parsoid - bug 41151), "s" is not a part of the link text

Version: unspecified
Severity: normal

Details

Reference
bz54891

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz54891.
liangent created this task.Oct 2 2013, 7:14 PM

Linkprefix is also affected - type "s" at the beginning instead of the end in the repro above.

(In reply to comment #0)

Repro:

  1. Create a new page with wikitext "[[中文]]" on zhwiki
  2. VisualEditor-edit this page and type "s" at the end
  3. The whole document now looks as if it has a link to "中文" with text "中文s"
  4. Save the page
  5. Resulting wikitext is "[[中文]]s", and in rendered HTML (both PHP and Parsoid
  6. bug 41151), "s" is not a part of the link text

I can't reproduce that - I got <a>中文</a>s in the edit surface, and it saved as expected:

https://zh.wikipedia.org/w/index.php?title=User:Jdforrester_(WMF)/Sandbox&diff=28804969&oldid=28804968 (for linkhead)

Are you absolutely sure it showed as <a>中文s</a> (because it really shouldn't!)? What browser were you using?

(In reply to comment #2)

Are you absolutely sure it showed as <a>中文s</a> (because it really
shouldn't!)?

Yes - already checked with inspector.

What browser were you using?

Firefox 22.

I get:

<p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>

… when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).

Very odd. :-(

(In reply to comment #4)

I get:

<p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>

… when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).

Very odd. :-(

btw I can't reproduce it using Chrome either.

(In reply to comment #4)

I get:

<p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>

… when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).

Very odd. :-(

Hmm in Firefox 24 it's no longer reproducible here...

(In reply to comment #6)

(In reply to comment #4)
> I get:
>
> <p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
> ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>
>
> … when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).
>
> Very odd. :-(

Hmm in Firefox 24 it's no longer reproducible here...

If you can reproduce in Firefox 22 again, once it's in the broken state in the ContentEditable surface please place the cursor to the left (up-page of) the link and insert a new line. This should trigger a re-render and cause the shown HTML to be corrected to what it should be?

(In reply to comment #7)

(In reply to comment #6)
> (In reply to comment #4)
> > I get:
> >
> > <p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
> > ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>
> >
> > … when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).
> >
> > Very odd. :-(
>
> Hmm in Firefox 24 it's no longer reproducible here...

If you can reproduce in Firefox 22 again, once it's in the broken state in
the
ContentEditable surface please place the cursor to the left (up-page of) the
link and insert a new line. This should trigger a re-render and cause the
shown
HTML to be corrected to what it should be?

Unfortunatly I don't know how to get it back now :(

I simply APT updated it. Does any have some hint about downgrading a package?

I downloaded versions 21, 22 and 23 from: https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/21.0/ (etc.)

I didn't get your reported behaviour in any of them. :-(

dchan added a comment.Oct 8 2013, 11:01 PM

I do not get the reported problem in Firefox 18 (And Chromium 25).