Page MenuHomePhabricator

IM labels are inconsistent in the Language Settings panel
Closed, ResolvedPublic


IM names in Marathi before the IM is changed from the keyboard menu


The labels next to the Input Method names on the Input Settings panel of ULS display different text against some IMs if the user makes any changes to the settings from the Keyboard Menu.

Steps to Reproduce:

  1. Language Settings panel -> Input Settings -> Select Marathi as the language -> Select any input method -> Apply Settings
  2. Click on the Search box
  3. From the Keyboard menu -> Select a different keyboard for Marathi
  4. Reopen Language Settings panel -> Input Settings
  5. Observe the names next to the radio buttons


The text next to the IMs displayed in step 1 and step 4 differ. (See attachments).


The text should be identical

Version: unspecified
Severity: normal


marathi-before.png (459×820 px, 71 KB)



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:35 AM
bzimport set Reference to bz56160.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 13587
IM names in Marathi after the IM is changed from the keyboard menu


marathi-after.png (496×784 px, 77 KB)

Created attachment 13588
IM names in Hindi before the IM is changed from the keyboard menu


hindi-before.png (504×801 px, 74 KB)

Created attachment 13589
IM names in Hindi after the IM is changed from the keyboard menu


hindi-after.png (497×793 px, 78 KB)

Change 92526 had a related patch set uploaded by Siebrand:
Update jQuery.IME from upstream

Change 92526 merged by jenkins-bot:
Update jQuery.IME from upstream

I just realised that the description from the initial attachment may cause some confusion about the issue reported. This problem is seen for several languages and not just for Hindi and Marathi (the screenshots are illustrations of the problem).

To solve this bug, all the sources for the text labels need to be identified and checked for any variation.

I think this indicates that we still use strings from different sources. Sometimes it comes from the IME definition file (for example rules/am/am-transliteration.js), sometimes from jquery.ime.inputmethods.js. I think it should ALWAYS come from the latter (jquery.ime.inputmethods.js).

The main reason is that strings from the IME definition files are only available in one language, while a single input method can be used under different language codes and with different descriptions (as is done for nn-tildeforms, for example).

My guess is that some key is still being used from the IME definition file (for example, instead of from jquery.ime.inputmethods.js ($ (or however the notation in JavaScript is supposed to be).

Amire80 claimed this task.

I'm not sure when was it fixed, but it appears to be fixed. I cannot reproduce according to the instructions in the original bug. Please reopen if it still happens.