Page MenuHomePhabricator

Make oojs and oojs-ui libraries available in MediaWiki core
Closed, ResolvedPublic

Description

OOjs and OOjs-UI should be made available as a library in core, much like jQuery.


Version: unspecified
Severity: enhancement

Details

Reference
bz56572

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:37 AM
bzimport set Reference to bz56572.

Change 98887 had a related patch set uploaded by Catrope:
Add oojs and oojs-ui to core

https://gerrit.wikimedia.org/r/98887

Change 98887 had a related patch set uploaded by Jforrester:
Add oojs and oojs-ui to core

https://gerrit.wikimedia.org/r/98887

OOJS (not included the UI part) was added in https://gerrit.wikimedia.org/r/#/c/99305/ (which is merged).

Change 98887 had a related patch set uploaded by Jforrester:
Add OOJS UI v0.1.0-pre (f90c7bcce6) to core

https://gerrit.wikimedia.org/r/98887

Change 98887 had a related patch set uploaded by Siebrand:
Add OOJS UI v0.1.0-pre (da9ec955a8) to core

https://gerrit.wikimedia.org/r/98887

Can we please use submodules in mediawiki/core.git that would point to OOUI / OOJS tags. I really hate the proposal of copy/pasting code there.

If we want to ship them on Wikimedia cluster, we can still use submodules like we are doing in wmf branches with extensions.

To ship OOUI / OOJS with MediaWiki tarball, the make-release script we are using can be made to proceed submodules and thus include the content in the .tar.gz.

(In reply to comment #6)

Can we please use submodules in mediawiki/core.git that would point to OOUI /
OOJS tags. I really hate the proposal of copy/pasting code there.
If we want to ship them on Wikimedia cluster, we can still use submodules
like we are doing in wmf branches with extensions.
To ship OOUI / OOJS with MediaWiki tarball, the make-release script we are
using can be made to proceed submodules and thus include the content in the
.tar.gz.

We've historically avoided submodules in MW core because they add complications for down-stream users of git.

Also, note in this case that these aren't just "copy-and-pasted" OOjs / OOjs-UI trees, but are built, bundled libraries via a grunt process.

hashar added a comment.Feb 7 2014, 1:25 PM

We've historically avoided submodules in MW core because they add
complications
for down-stream users of git.
Also, note in this case that these aren't just "copy-and-pasted" OOjs /
OOjs-UI
trees, but are built, bundled libraries via a grunt process.

Fair enough. I have removed my -2 from the Gerrit change :-]

Change 98887 merged by jenkins-bot:
Add OOjs UI v0.1.0-pre (3b61a8d77c) to MW core

https://gerrit.wikimedia.org/r/98887