Page MenuHomePhabricator

[RFC] make SpecialChangePassword form text depending on login status of $wgUser
Open, NormalPublic

Description

make SpecialChangePassword form text depending on login status of $wgUser

During development of Extension:OpenID I found, that I have to apply a small patch to ChangePassword for the case that I want the pre-login user to enter their temporary password.

During development of E:OpenID, I found that the SpecialChangePassword shows the "Temporary password" text only if I apply this patch.

https://gerrit.wikimedia.org/r/#/c/96651/

I suppose, but I am not sure, that this was a design mistake (in the old version of ChangePassword) to check against the passed parameter $user instead of (new version) to check against $wgUser.

This is a request for comments.

Chris answered on Patch Set 4: Code-Review-1:

This seems like the wrong way to accomplish this, and seems like it relies on another bug that might disappear.
I'd rather see this use a parameter to showForm(), or use a flag in the class to indicate what wording you want, and then have your code set that.

I still think, that originally $wgUser was meant, perhaps you can ask around.

For my extension OpenID, which calls under certain conditions ChangePassword, an additional parameter would be fine, in order to trigger the correct label text "temporary password".


Version: 1.23.0
Severity: normal

Details

Reference
bz57731

Related Objects

StatusAssignedTask
OpenNone
OpenNone
OpenNone
DeclinedWikinaut
DeclinedNone
OpenNone
OpenNone
OpenNone
ResolvedTgr
ResolvedAnomie
ResolvedJoe
ResolvedJoe
Resolvedhashar
Resolved bd808
ResolvedAnomie
ResolvedKrinkle
OpenNone
ResolvedJanZerebecki
ResolvedKrinkle
ResolvedTgr

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:29 AM
bzimport set Reference to bz57731.
bzimport added a subscriber: Unknown Object (MLST).
Wikinaut created this task.Nov 29 2013, 8:04 AM

Change 96651 had a related patch set uploaded by Wikinaut:
make SpecialChangePassword form text depending on login status of wgUser

https://gerrit.wikimedia.org/r/96651

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2015, 3:57 AM