Page MenuHomePhabricator

VisualEditor: <ref> in media item caption in a <ref> isn't blocked, which means page can get into an uneditable state on load
Closed, InvalidPublic

Description

Author: Wikifram

Description:
This version of my sandbox at enwiki, [https://en.wikipedia.org/w/index.php?title=User:Fram/sandbox&oldid=585258547], is no longer editable in VE by me (FF25, W7). It opens, and I can make whatever changes I want, but the "save" button stays disabled, and when I open the reference interface, I can no longer close that one either. The category and media interface work allright though.


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57573

Details

Reference
bz58270

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:38 AM
bzimport set Reference to bz58270.

Could you please open the Error Console (or whatever it is called in your browser) and reload the page that you see the problem on? If there is a problem or an error with JavaScript it should be printed in that console.
For more information please see:

Yuck.

So the problem is that you've got a reference in an image's caption, which is inside a reference; this is not allowed in wikitext (as you can see from the "Cite error: A <ref> tag is missing the closing </ref> (see the help page)." error), and is because the restriction on media items' captions doesn't inherit the restriction of the reference block.

We'll need to build a way for restrictions to be explicit and inheritable.

Jdforrester-WMF lowered the priority of this task from High to Medium.Jan 15 2015, 12:28 AM
Jdforrester-WMF set Security to None.
Deskana lowered the priority of this task from Medium to Lowest.Apr 12 2018, 4:23 PM
WMDE-Fisch subscribed.

Sorry for randomly stumbling over that ticket. I can not reproduce the issue anymore. What I did:

I open the sandbox with the revision linked and edit that revision in VE:

  • I can make changes in the editor and the Save button becomes enabled.
  • I can open, use & close the references interface without issues.

Feel free to re-open the task if anything remains or I missed a point here.