Page MenuHomePhabricator
Create Task
Maniphest T61699

Better spinner icon for jquery.spinner.js
Closed, DuplicatePublic
Actions

Description

The media viewer throbber in the BetaFeatures extension appears to be low resolution and looks kind of bad. Screenshot attached.

See Also: T56814

Screenshot of throbber from media viewer in BetaFeatures:

Screen_Shot_2014-01-05_at_5.42.51_PM.png (822×531 px, 22 KB)

Details

Reference
bz59699
SubjectRepoBranchLines +/-
Hi-DPI spinner using 2x-density animated GIFmediawiki/coremaster+14 -0
Hi-DPI spinner using CSS animationmediawiki/coremaster+131 -0
high-resolution spinner-iconmediawiki/coremaster+0 -0
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:20 AM
• bzimport added projects: MediaWiki-JavaScript, good first task.
• bzimport set Reference to bz59699.
• bzimport added a subscriber: Unknown Object (MLST).
• MZMcBride created this task.Jan 5 2014, 10:51 PM
• MZMcBride added a comment.Jan 12 2014, 9:13 AM

It's called a spinner in the code. :-)

• MZMcBride added a comment.Jan 13 2014, 3:43 AM

Mark: did this get fixed? I think the throbber/spinner may be gone now (I looked at mediawiki.org briefly and it didn't seem to be there).

MarkTraceur added a comment.Jan 14 2014, 12:15 AM

It got "fixed" but only in that we don't use this library anymore. In core, we should fix the bug more resolutely by using APNG or just a properly alpha'd GIF. Test on a variety of coloured backgrounds to make sure.

MarkTraceur added a comment.Jan 14 2014, 12:17 AM

Note: The library in question is resources/jquery/jquery.spinner.js - the files that need changing are resources/jquery/images/spinner.gif and resources/jquery/images/spinner-large.gif - just so you know where to go :)

• MZMcBride added a comment.Jan 14 2014, 2:14 AM

[[mw:User:Splarka/Throbber]]

If this bug report is only about MediaWiki core's generic throbber, this is probably a duplicate.

Tinaj1234 added a comment.Jan 14 2014, 6:38 AM

Created attachment 14304
Another kind of spinner

Was wondering if we could go for another kind of spinner ? Not necessarily this.

Attached:

spinner (32×32 px, 6 KB)

Tgr added a comment.Feb 11 2014, 7:23 PM

Oops, sorry. Just wanted to rename it.

gerritbot added a comment.Feb 28 2014, 2:19 PM

Change 116103 had a related patch set uploaded by Deepali:
Add better spinner icon for jquery.spinner.js

https://gerrit.wikimedia.org/r/116103

gerritbot added a comment.Mar 1 2014, 5:50 AM

Change 116225 had a related patch set uploaded by Deepali:
Add vector svg animated spinner icon

https://gerrit.wikimedia.org/r/116225

matmarex updated the task description. (Show Details)Dec 30 2014, 8:33 PM
matmarex edited projects, added MediaWiki-User-Interface, JavaScript; removed Patch-For-Review, MediaWiki-JavaScript.
matmarex set Security to None.
matmarex removed a subscriber: Unknown Object (MLST).

The patches have been abandoned. Someone could pick up the work.

Jdforrester-WMF lowered the priority of this task from Medium to Lowest.Jan 30 2015, 5:09 AM

No-one's working on this, and there's no urgency.

gerritbot added a project: Patch-For-Review.Jan 30 2015, 8:18 PM
gerritbot subscribed.

Change 187737 had a related patch set uploaded (by MarkTraceur):
high-resolution spinner-icon

https://gerrit.wikimedia.org/r/187737

Patch-For-Review

gerritbot added a comment.Jun 17 2015, 9:59 PM

Change 187737 abandoned by Bartosz Dziewoński:
high-resolution spinner-icon

Reason:
No response from uploader; does not fix the linked bug.

https://gerrit.wikimedia.org/r/187737

• brooke subscribed.Jul 8 2015, 3:59 PM
gerritbot added a comment.Jul 8 2015, 6:01 PM

Change 223586 had a related patch set uploaded (by Brion VIBBER):
Hi-DPI spinner using CSS animation

https://gerrit.wikimedia.org/r/223586

• brooke mentioned this in T75972: Loading indicators / Progress indicators are inconsistent. .Jul 9 2015, 9:35 PM
Ricordisamoa subscribed.Jul 10 2015, 7:18 AM
Tinaj1234 unsubscribed.Jul 11 2015, 9:01 PM
matmarex assigned this task to • brooke.Oct 27 2015, 9:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2015, 9:48 PM
matmarex mentioned this in T56814: UploadWizard: The (grey) dialog should not have a spinner with a fixed white background.Nov 3 2015, 3:28 PM
gerritbot added a comment.Nov 23 2015, 10:18 PM

Change 255029 had a related patch set uploaded (by Brion VIBBER):
Hi-DPI spinner using 2x-density animated GIF

https://gerrit.wikimedia.org/r/255029

gerritbot added a comment.Nov 23 2015, 10:19 PM

Change 223586 abandoned by Brion VIBBER:
Hi-DPI spinner using CSS animation

Reason:
Abandoning in favor of simpler I2af30082

https://gerrit.wikimedia.org/r/223586

Krinkle unsubscribed.Nov 24 2015, 3:34 AM
MarkTraceur unsubscribed.Jan 27 2017, 10:22 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJan 27 2017, 10:22 PM
Framawiki moved this task from Backlog to Doing on the good first task board.Dec 2 2017, 1:36 PM
• Phabricator_maintenance moved this task from Doing to Backlog on the good first task board.Sep 24 2018, 9:52 AM
ori closed this task as a duplicate of T219163: Rewrite jquery.spinner module to use CSS.Feb 19 2020, 6:16 AM
gerritbot added a comment.Feb 19 2020, 6:19 AM

Change 255029 abandoned by Ori.livneh:
Hi-DPI spinner using 2x-density animated GIF

Reason:
obsoleted by https://gerrit.wikimedia.org/r/#/c/498884/

https://gerrit.wikimedia.org/r/255029

TerraCodes unsubscribed.Feb 19 2020, 11:18 AM
Bugreporter removed a parent task: T34101: High-density display issues (HiDPI) (tracking).Aug 20 2021, 7:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits