Page MenuHomePhabricator

Include /* section title */ in edit summary for mobile section edits
Closed, ResolvedPublic

Description

So page history is easier to read.


Version: unspecified
Severity: enhancement

Details

Reference
bz60134

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:59 AM
bzimport set Reference to bz60134.
bzimport added a subscriber: Unknown Object (MLST).
liangent created this task.Jan 16 2014, 3:14 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1631

Jared/Kenan is this something we want?

sure? maybe stripping out the extra character though, doesn't seem necessary

sure? maybe stripping out the extra character though, doesn't seem necessary

Change 135311 had a related patch set uploaded by Florianschmidtwelzow:
Insert section name in edit summary

https://gerrit.wikimedia.org/r/135311

I'm very unsure, if this is the best solution to get the new sections name, any suggestions i overlook?

(In reply to Florian from comment #6)

I'm very unsure, if this is the best solution to get the new sections name,
any suggestions i overlook?

  1. When the title is "== [[section]] ==", the output on desktop is /* section */ while MF now outputs /* [[section]] */
  1. When the section title got changed in an edit, desktop uses the original section title while MF uses the new one (if I read your code correctly)

I'm not sure which is better, but at least they're inconsistent.

Can I suggest we do not pre-fill the edit summary and instead auto prepend it programatically?

I worry seeing /* Section History */ in an input box might be off putting to a user not familiar with wiki editing and might lead to them not adding edit summaries... (although I have no evidence to back this up)

Hmm, it's an argument, the other side is, that, if we look at consistency between desktop and mobile edit, a pre filled summary with the section name is an obligation. But i see the possible problem like you :/

Maybe adding section name without show this to user (maybe only, if the user entered a summary)?

(In reply to Florian from comment #10)

Maybe adding section name without show this to user (maybe only, if the user
entered a summary)?

Mobile Apps do a slight variation of this. They prepend the section name automatically all the time, even if the user didn't enter any

Ok. The thing to add section name only, if the user enteres a summary is a maybe :) maybe the behavior can be configureable for wiki administrators with a config variable (default to true).

Any opinions? :)

Any progress? I prefer the App solution.

Change 135311 merged by jenkins-bot:
Insert section name in edit summary

https://gerrit.wikimedia.org/r/135311

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJun 7 2017, 7:01 PM