Description
Details
- Reference
- bz61024
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Xqt | T63024 cosmetic changes must not remove useless spaces inside templates | |||
Resolved | jayvdb | T105621 textlib.replaceExcept() doesn't work properly with template exceptions | |||
Resolved | Xqt | T140608 cosmetic change removeUselessSpaces removes desirable spaces on de.wp |
Event Timeline
I'd guess not so: CosmeticChangesToolkit.removeUselessSpaces should not replace spaces inside of templates.
'template' is in the exceptions list; maybe the exceptions regex doesn't work as expected for templates
New linkt to talk page Archive: https://de.wikipedia.org/wiki/Benutzer_Diskussion:Xqt/Archiv/2014-1#.C3.84nderungen_in_Uran
The affected edit was https://de.wikipedia.org/w/index.php?title=Uran&diff=127298985&oldid=127121719
Are there still problems with nested templates?
Change 224301 had a related patch set uploaded (by Xqt):
Deactivate removeUselessSpaces due to several bugs
The replaceExcept 'template' handler was rewritten in 13cd73de7ac9244f67bc33a27e7278b9d48abbd3#3e3bbe17, and the 'nested' part is no longer complicated.
Change 226531 had a related patch set uploaded (by John Vandenberg):
Reduce complexity of NESTED_TEMPLATE_REGEX
Change 299137 had a related patch set uploaded (by Xqt):
Deactivate removeUselessSpaces due to several bugs
Change 299137 merged by jenkins-bot:
Deactivate removeUselessSpaces due to several bugs
@Xqt This seems solved as in cosmetic_changes there is already a code for this and there seems to be no more problems with nested template regex, right?