Page MenuHomePhabricator

EducationProgram should pass jshint
Closed, ResolvedPublic

Description

From https://gerrit.wikimedia.org/r/#/c/125959/

18:18:40 resources/jquery.imageinput.js: line 37, col 14, Too many errors. (29% scanned).
18:18:40
18:18:40 676 errors
18:18:40 Build step 'Execute shell' marked build as failure
18:18:40 Finished: FAILURE


Version: unspecified
Severity: normal
URL: https://integration.wikimedia.org/ci/job/mwext-EducationProgram-jslint/661/consoleFull
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56962

Attached:

Details

Reference
bz63959

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:25 AM
bzimport set Reference to bz63959.
bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.Apr 15 2014, 7:15 PM

andrew.green.df wrote:

Thanks! Since normally jslint passes for this extension, I'm changing this to a continuous integration bug.

$ jshint --version
jshint v2.4.4
$ jshint .
..
resources/jquery.imageinput.js: line 37, col 14, Too many errors. (29% scanned).

676 errors
$

It does not pass on my machine :-/

andrew.green.df wrote:

For example, see https://gerrit.wikimedia.org/r/#/c/118101 . Patch set 9 fails but patch set 10 passes. No changes in js modules. Sorry I haven't had time to try to chase this down... Thanks!!! :)

Change 160986 had a related patch set uploaded by 01tonythomas:
Added .jshintrc file to pass Jenkins

https://gerrit.wikimedia.org/r/160986

Moving bug under MediaWiki extensions

Change 167954 had a related patch set uploaded by Hashar:
Have Jenkins use the standard configuration for JSLint

https://gerrit.wikimedia.org/r/167954

Change 167954 merged by jenkins-bot:
Have Jenkins use the standard configuration for JSLint

https://gerrit.wikimedia.org/r/167954

Change 160986 abandoned by 01tonythomas:
Added .jshintrc file to pass Jenkins

Reason:
in favor of I1652e641f0a778db8a47ed8e5da00a31636c4f55

https://gerrit.wikimedia.org/r/160986

All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

It seems to be behaving lately, so I'll close it as fixed.

CI is up to date :)