Page MenuHomePhabricator

VisualEditor: Inline images don't display correctly if converted to floating images and then back
Closed, ResolvedPublic

Description

Steps to Reproduce:

  1. Open a page that contains inline images at the start of a paragraph or list item.
  1. Select the image, open the image dialog, and de-select the "Wrap text around" item. The item will float right.
  1. Change your mind. Open the imge dialog again, and re-select the "Wrap text around" item.

Actual Results:
The inline image appears to be, but isn't actually, on its own line.

Reproducible: Always


Version: unspecified
Severity: minor

Details

Reference
bz65924

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:17 AM
bzimport set Reference to bz65924.

I'm a bit confused. You mentioned you need to de-select the floating value of the image, but inline images aren't supposed to have floating values at all (the checkbox should be unchecked) -- are you sure you're looking at inline images, or that you unchecked the value first?

Can you give me an example to look at? Thanks!

Look at what happens to the "laundromat" image at http://en.wikipedia.beta.wmflabs.org/w/index.php?diff=100058&oldid=100057

It was inline; I made it be a normal/non-inline image (perhaps "floating" isn't the right word?). Then I moved it back. When I moved it back, it displayed oddly—on its own line in the display, although it was inline when I saved.

I'll upload some screenshots for you.

Created attachment 15534
Inline image has been moved back, and displays on its own line

Attached:

Created attachment 15535
Before moving the image. This is what it ought to look like after I move it back, too (perhaps minus the space between image and text).

Attached:

After further examination, this isn't an image bug per say, it is a list bug.

When the image is transformed from block to inline it goes back to being on its own paragraph (as it does always regardless of lists) letting the user decide where it should be.

The problem with the list, however, is that when the image goes back to being inline it is presented as if it is on its own line inside the list (with the text being on a different paragraph in the list item)

However, the list itself won't allow for multi paragraphs and the resulting wikitext shows the image and followup text without the extra line space.

We could either add a <br> in between the image and the new text (in Parsoid?) or find a creative solution to make lists with multiline text behavior reflect that of the resulting wikitext in general.

Why does it always add a paragraph? Surely that's for fixUpInsertion to decide?

If we can have fixUpInsertion insert the image into an existing paragraph in the case of lists, that can be a good solution too.

Change 138114 had a related patch set uploaded by Catrope:
[BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup

https://gerrit.wikimedia.org/r/138114

(In reply to Gerrit Notification Bot from comment #8)

Change 138114 had a related patch set uploaded by Catrope:
[BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window
process cleanup
https://gerrit.wikimedia.org/r/138114

Whoops, not relevant; my mistake.

Change 139064 had a related patch set uploaded by Mooeypoo:
Add inline images into existing paragraphs

https://gerrit.wikimedia.org/r/139064

Change 139269 had a related patch set uploaded by Mooeypoo:
Don't create new paragraph for inline image inside list

https://gerrit.wikimedia.org/r/139269

Change 139064 abandoned by Mooeypoo:
Add inline images into existing paragraphs

Reason:
Moving this to the MWImageModel in a new commit

https://gerrit.wikimedia.org/r/139064

Change 139269 merged by jenkins-bot:
Insert inline image inside list to the existing paragraph

https://gerrit.wikimedia.org/r/139269