Page MenuHomePhabricator

VisualEditor: Metas at the end of a link annotation's anchor cause it to be split; should instead change with it
Closed, ResolvedPublic0 Estimated Story Points


(Taken from bug 52127.)

Previously, before comments were node-ified, editing


… to point to "Baz" would create the wikitext:


… whereas it should have done


… (i.e., meta items inside annotations should get changed when the annotation changes, not keep their existing ones).

As comments are (mostly) now nodes, this doesn't apply to them, but will apply to other meta items like {{DISPLAYTITLE:Foo}} or whatever broken items might exist.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:30 AM
bzimport set Reference to bz68779.
Jdforrester-WMF assigned this task to dchan.
Jdforrester-WMF moved this task from Freezer to TR3: Language support on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 0.

So, it turns out we fixed this at some point in the past ~3 years anyway – tested on 1.31.0-wmf.17:

However, it still works after the re-unification of data and meta-data, tested on 0c9fb65fbe:

… hurrah?