Page MenuHomePhabricator

"float: none" should be cleaned up ContentTranslation LESS files
Open, LowPublic

Description

ContentTranslation LESS files have a lot of "float: none" rules marked with XXX. This makes the display correct, but it seems to me that they aren't really needed and that there should be another way to make these row elements stack, but I can't think of a proper way to do it.


Version: unspecified
Severity: minor

Details

Reference
bz68925

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:40 AM
bzimport set Reference to bz68925.
bzimport added a subscriber: Unknown Object (MLST).
Amire80 created this task.Jul 31 2014, 4:08 PM

Is this related to the grid framework we are using?

(In reply to Niklas Laxström from comment #1)

Is this related to the grid framework we are using?

Yes. I'd expect that the grid will handle that automatically without the need for this rule. It's also possible that I misunderstand what the grid is supposed to do :)

List of such float: name cases

modules/tools/styles/ext.cx.tools.dictionary.less
40: float: none; XXX why would it be needed?
53: float: none;
XXX why would it be needed?
62: float: none; XXX why would it be needed?
85: float: none;
XXX why would it be needed?

modules/tools/styles/ext.cx.tools.link.less
40: float: none;

modules/tools/styles/ext.cx.tools.manager.less
43: float: none; XXX why would it be needed?
55: float: none;
XXX why would it be needed?
64: float: none; // XXX why would it be needed?

modules/tools/styles/ext.cx.tools.mt.less
8: float: none; XXX why would it be needed?
15: float: none;
XXX why would it be needed?
96: float: none; XXX why would it be needed?
137: float: none;
XXX why would it be needed?

modules/tools/styles/ext.cx.tools.reference.less
17: float: none;

modules/translationview/styles/ext.cx.translationview.less
126: float: none;

This comment was removed by Pginer-WMF.
Amire80 moved this task from Needs Triage to CX6 on the ContentTranslation board.Jul 3 2015, 3:40 PM
Amire80 set Security to None.
Amire80 moved this task from Backlog to Tech Debt on the ContentTranslation-Release6 board.
Pginer-WMF moved this task from CX6 to CX7 on the ContentTranslation board.Jul 21 2015, 4:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2015, 4:21 PM
Amire80 moved this task from CX7 to CX6 on the ContentTranslation board.Jul 29 2015, 10:39 PM
Amire80 moved this task from CX6 to CX7 on the ContentTranslation board.Oct 2 2015, 3:27 PM

Change 259638 had a related patch set uploaded (by Amire80):
MT Card: Avoid having a dedicated element for clearfix

https://gerrit.wikimedia.org/r/259638

Change 259638 merged by jenkins-bot:
MT Card: Avoid having a dedicated element for clearfix

https://gerrit.wikimedia.org/r/259638

Danny_B moved this task from Unsorted to Cleanup on the Technical-Debt board.Jan 22 2016, 11:34 PM