ContentTranslation LESS files have a lot of "float: none" rules marked with XXX. This makes the display correct, but it seems to me that they aren't really needed and that there should be another way to make these row elements stack, but I can't think of a proper way to do it.
Version: unspecified
Severity: minor
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| MT Card: Avoid having a dedicated element for clearfix | mediawiki/extensions/ContentTranslation | master | +18 -22 |
(In reply to Niklas Laxström from comment #1)
Is this related to the grid framework we are using?
Yes. I'd expect that the grid will handle that automatically without the need for this rule. It's also possible that I misunderstand what the grid is supposed to do :)
List of such float: name cases
modules/tools/styles/ext.cx.tools.dictionary.less
40: float: none; XXX why would it be needed?
53: float: none; XXX why would it be needed?
62: float: none; XXX why would it be needed?
85: float: none; XXX why would it be needed?
modules/tools/styles/ext.cx.tools.link.less
40: float: none;
modules/tools/styles/ext.cx.tools.manager.less
43: float: none; XXX why would it be needed?
55: float: none; XXX why would it be needed?
64: float: none; // XXX why would it be needed?
modules/tools/styles/ext.cx.tools.mt.less
8: float: none; XXX why would it be needed?
15: float: none; XXX why would it be needed?
96: float: none; XXX why would it be needed?
137: float: none; XXX why would it be needed?
modules/tools/styles/ext.cx.tools.reference.less
17: float: none;
modules/translationview/styles/ext.cx.translationview.less
126: float: none;
Change 259638 had a related patch set uploaded (by Amire80):
MT Card: Avoid having a dedicated element for clearfix
Change 259638 merged by jenkins-bot:
MT Card: Avoid having a dedicated element for clearfix