I would like to open a dialog box for OAuth authorization instead of redirecting to the whole page and then back. So it would be great if I could pass a parameter to make the dialog be the only thing in the window, and not just a small part of it.
(Implemented with display=popup, as per the OIDC spec.)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| SpecialMWOAuth: Support &display=popup | mediawiki/extensions/OAuth | master | +44 -20 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T90925 General authentication improvements for MediaWiki | |||
| Open | None | T86869 Support a nice sso experience with MediaWiki's OAuth | |||
| Open | None | T75062 OAuth permission screen needs redesign for better usability and comprehension | |||
| Resolved | Feature | matmarex | T71246 Provide a way to show OAuth authorization dialog with a layout appropriate for a popup | ||
| Resolved | matmarex | T362706 Permit displaying the login / signup page in a popup or iframe |
We can't allow framing of the page, but it should be a trivial change to prevent loading the javascript that creates the dialog, so you can have the authorization page in a small popup like Yahoo used to use.
Yes, I had a popup in mind. I am using now a popup, but the issue is that then the overlay inside the page is not over the whole window. So there could be a query string parameter which would make overlay inside the window appear from edge to edge.
This would ideally extend to the login page, since authorization might involve logging the user in. So it has some overlap with T71596: Provide JavaScript login widget. Opening the login dialog in a separate window would be an acceptable workaround, though.
Change #1031627 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/OAuth@master] SpecialMWOAuth: Support &display=popup
Example of the popup style being used in a tool:
Change #1031627 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] SpecialMWOAuth: Support &display=popup
This has been implemented. If you make use of this mode, we'd appreciate comments (on this task) about what you or your users think about it.
We should probably advertise this to tool authors. Not sure what's the best mechanism for that. Tech News? wikitech-l? There's a Developer-notice tag but I don't think it does much.