Page MenuHomePhabricator

Stop using inline <img> for thumbnail magnify icon
Closed, ResolvedPublic

Description

Let's stop using inline <img> for thumbnail magnify icon. According to bug 69277 comment 11, there are 87619775 requests per day for 'magnify-clip.png'. It should be embedded in some piece of CSS.

(Bug 65160 / [[mw:Thumbnail style update]] call for complete removal of the icon, but it would only affect the Vector skin.)


Version: 1.24rc
Severity: normal

Details

Reference
bz69673

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:38 AM
bzimport added a project: MediaWiki-Interface.
bzimport set Reference to bz69673.
matmarex created this task.Aug 17 2014, 6:45 PM

A number of extensions also refer to this file directly, including VisualEditor and WikiEditor. These will need to be updated.

There are probably also innumerable user scripts that refer to it. Looking at bug 69277 comment 10, the Popups gadget is a big offender.

(In reply to Bartosz Dziewoński from comment #0)

(Bug 65160 / [[mw:Thumbnail style update]] call for complete removal of the
icon, but it would only affect the Vector skin.)

At this point this artefact would become a Monobook-only item, right? Should it be moved to that repo at that point?

(In reply to Bartosz Dziewoński from comment #1)

A number of extensions also refer to this file directly, including
VisualEditor and WikiEditor. These will need to be updated.

VisualEditor only uses it through mediawiki.content.styling.parsoid (faked Vector-like content rendering; yes yes, I know…), which should be fixed as the fixing for bug 65160.

(In reply to James Forrester from comment #2)

At this point this artefact would become a Monobook-only item, right? Should
it be moved to that repo at that point?

No, it would become every-skin-but-Vector-including-custom-skins-only item.

VisualEditor only uses it through mediawiki.content.styling.parsoid

It is also used in ve.ce.MWImageCaptionNode.js via 'magnifyClipIconURL' config item.

ori added a comment.Aug 17 2014, 10:35 PM

(In reply to Bartosz Dziewoński from comment #0)

Let's stop using inline <img> for thumbnail magnify icon. According to bug
69277 comment 11, there are 87619775 requests per day for
'magnify-clip.png'. It should be embedded in some piece of CSS.
(Bug 65160 / [[mw:Thumbnail style update]] call for complete removal of the
icon, but it would only affect the Vector skin.)

Makes sense to me.

Change 154830 had a related patch set uploaded by Bartosz Dziewoński:
Generate 'Enlarge' image in CSS rather than HTML (Linker)

https://gerrit.wikimedia.org/r/154830

Change 154831 had a related patch set uploaded by Bartosz Dziewoński:
Remove WMF deployment hack for 'Enlarge' image

https://gerrit.wikimedia.org/r/154831

Change 154830 merged by jenkins-bot:
Generate 'Enlarge' image in CSS rather than HTML (Linker)

https://gerrit.wikimedia.org/r/154830

Deeming this merged now, as this is 'fixed' even without the clean-up from gerrit 154831 landing.

Change 161625 had a related patch set uploaded by Jforrester:
Remove WMF deployment hack for 'Enlarge' image

https://gerrit.wikimedia.org/r/161625

Change 154831 merged by jenkins-bot:
Remove WMF deployment hack for 'Enlarge' image

https://gerrit.wikimedia.org/r/154831

Change 161625 merged by jenkins-bot:
Remove WMF deployment hack for 'Enlarge' image

https://gerrit.wikimedia.org/r/161625