If I enable “Preferences/Recent changes/Advanced options/Group changes […]”, the watchlist has incorrect behaviour:
- “diff” and “n changes” are links to “title=Topic:…&curid=0&diff=0&oldid=0” (normal enhanced RC uses numerical IDs here).
See also:
Description
Description
Details
Details
- Reference
- bz70513
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix link targets in usenewrc | mediawiki/extensions/Flow | master | +83 -0 | |
| Add hook EnhancedChangesList::getLogText | mediawiki/core | master | +119 -88 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | Nemo_bis | T88102 Consider possibility of enabling Flow on translatewiki.net | |||
| Open | None | T85540 Feed (watchlist/RC/contribs) - Flow issues (tracking) | |||
| Invalid | None | T88111 Flow must play well with CleanChanges (Translatewiki) | |||
| Resolved | None | T72513 R2. Bad Flow link targets in usenewrc (Enhanced RC) in watchlist and recentchanges (Portuguese) |
Event Timeline
Comment Actions
(In reply to Ltrlg from comment #0)
- all Flow revisions are marked unpatrolled;
Forked into bug 71456
(In reply to Ltrlg from comment #0)
- “diff” and “n changes” are links to “title=Topic:…&curid=0&diff=0&oldid=0”
(it should be simple text like in normal watchlist).
- Also the timestamps, which link to “title=Topic:…&curid=0”
Note: Docs at https://meta.wikimedia.org/wiki/Help:Enhanced_recent_changes
(I'll focus this bug ticket on just this aspect. Thanks for the report :) Tracked on trello at https://trello.com/c/c9dxYaQl/
Comment Actions
markers about particular languages on Collaboration team tickets denote where we can move forward deployments with particular languages by closing the linked ticket. This helps to align the work being done with the wiki's that are moving forward with flow deployment.
Comment Actions
Change 193094 had a related patch set uploaded (by Matthias Mullie):
Fix link targets in usenewrc
Comment Actions
Patch is up. Depends on a couple of fixes in Flow & a core change as well.
I've made a slight change in terminology.
Currently, Enhanced RC says: "X changes" (however many there were) or "diff" (if there's only been only 1 change)
I've also made that say "1 change" instead of "diff", since we're not linking to diff pages, but to the topic with highlighted posts.
Which brings me to another point: a change can also be something that won't pop out when being linked to the topic page with highlighted posts (like a moderated post). I've ignored that for now, since we have no view to display all kind of changes (and well, there's also still al link to history...)
Comment Actions
Change 193091 had a related patch set uploaded (by Mattflaschen):
Add hook EnhancedChangesList::getLogText
Comment Actions
That patch addresses the main line (unexpanded view) well.
However, there are some issues with the ungrouped (expanded view) part.
In the expanded view for a topic, links just go to the topic page with a invalid curid. For example, I created a topic, then made two more posts (one a reply to the initial post). They should show up as
post links, but instead just go to the topic:
<a href="/w/index.php?title=Topic:Scte781slghgc6yq&curid=0" title="Topic:Scte781slghgc6yq">03:48</a>.
It looks like this would probably require another hook
Comment Actions
There is still some work that needs to be done in the expanded view, unless we want to make that a separate task.
Comment Actions
English beta is http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA . There are also beta's in a couple other languages, try switching out the en for other language codes.
Comment Actions
This is not fixed there. I watched "Talk:Flow QA" and "Special:Watchlist" has is a link named "58 changes" which points to
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:Senqsumbi4s45wtn&fromnotif=1#flow-post-sem8qx52h93lvy1k
However, that page only one comment from "Selenium user", not the "58 changes" I wanted to see.