Page MenuHomePhabricator

VisualEditor: [Regression wmf5] Comment inspector closes and saves empty comment when tool is used
Closed, ResolvedPublic

Description

Screenshot

Environment- test2, beta, production

1> insert a comment in a blank page.
2> open the Edit comment box
3> while the cursor is still blinking in the comment box, click to add numbered / Bullet point. The comment box closes and the comment is shown as the bullet/numbered list item
4> Now open the edit comment box again and decrease the indentation.I get "JS console error, Uncaught Error: Cannot set attributes on closing element".See screenshot.


Version: unspecified
Severity: minor

Attached:

s.PNG (1×2 px, 124 KB)

Details

Reference
bz71706

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:48 AM
bzimport set Reference to bz71706.

This isn't as bad any more (no JS errors), probably thanks to Ed's change making the comment inspector use staging. But there's still a minor bug:

  • Insert a comment in a blank page
  • Type some text into the comment
  • While comment box is still open, click Bullet list
  • Comment inspector closes, comment ends up inside list
  • Inspect comment
  • Comment is empty (?!)
  • Close inspector. Comment is automatically removed because it is empty

(If you don't type some text at step 2, the comment is removed at that point because it's empty.)

(Marking as regression pre-wmf5 even though the behavior in wmf4 was much worse.)

gerritadmin wrote:

Change 173812 had a related patch set uploaded by Esanders:
Apply comment changes using fragment

https://gerrit.wikimedia.org/r/173812

gerritadmin wrote:

Change 173812 merged by jenkins-bot:
Apply comment changes using fragment

https://gerrit.wikimedia.org/r/173812

test2 - checked both scenarios - no js errors.