Inconsistent returns in BounceHandler
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Oct 29 2014, 5:20 PM

Description

Only the else block returns anything.

Should self::generateVerp be prepended with a return? (though, I note that always returns true)

Version: unspecified
Severity: normal

Status	Subtype	Assigned	Task
Invalid		None	T99444 Valid email address was unconfirmed for temporary spam blacklisting
Resolved		None	T104871 Mails from tools are being marked as 'spam' by gmail
Invalid		None	T54915 HTML email notifications caught by spam filters
Declined		• chasemp	T61731 mailman emails taking long time for delivery, getting stuck in sodium
Resolved		• chasemp	T58414 Get mail relay out of Yahoo! blacklist: apply to Yahoo for whitelisting bulk mail
Open	Feature	None	T58062 Notify user of mail bounces
Resolved		01tonythomas	T48640 Add proper email bounce handling to MediaWiki (with VERP)
Resolved		01tonythomas	T71019 Review and deploy BounceHandler extension to Wikimedia wikis
Resolved		01tonythomas	T74684 Inconsistent returns in BounceHandler

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:44 AM

• bzimport set Reference to bz72684.

(In reply to Sam Reed (reedy) from comment #0)

Only the else block returns anything.

Should self::generateVerp be prepended with a return? (though, I note that
always returns true)

That was for BounceHandlerHooks::onVERPAddressGenerate()

Also, ProcessBouncEmails::processEmail() doesn't return on all paths

ProcessBounceEmails::getOriginalEmail() too

gerritadmin wrote:

Change 170112 had a related patch set uploaded by 01tonythomas:
Fix inconsistent returns in BounceHandler extension

gerritadmin wrote:

Change 170112 merged by jenkins-bot:
Fix inconsistent returns in BounceHandler extension

Thanks Reedy for reporting those!