Page MenuHomePhabricator

Inconsistent returns in BounceHandler
Closed, ResolvedPublic

Description

Only the else block returns anything.

Should self::generateVerp be prepended with a return? (though, I note that always returns true)


Version: unspecified
Severity: normal

Details

Reference
bz72684

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:44 AM
bzimport set Reference to bz72684.
Reedy created this task.Oct 29 2014, 5:20 PM
Reedy added a comment.Oct 29 2014, 5:29 PM

(In reply to Sam Reed (reedy) from comment #0)

Only the else block returns anything.
Should self::generateVerp be prepended with a return? (though, I note that
always returns true)

That was for BounceHandlerHooks::onVERPAddressGenerate()

Also, ProcessBouncEmails::processEmail() doesn't return on all paths

Reedy added a comment.Oct 29 2014, 5:30 PM

ProcessBounceEmails::getOriginalEmail() too

gerritadmin wrote:

Change 170112 had a related patch set uploaded by 01tonythomas:
Fix inconsistent returns in BounceHandler extension

https://gerrit.wikimedia.org/r/170112

gerritadmin wrote:

Change 170112 merged by jenkins-bot:
Fix inconsistent returns in BounceHandler extension

https://gerrit.wikimedia.org/r/170112

Thanks Reedy for reporting those!