BounceHandlerActions::handleFailingRecipient() SQL query
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Oct 29 2014, 5:26 PM

Description

array(

				'br_user'=> $originalEmail,
				'br_timestamp' >= $bounceValidPeriod
			),

'br_timestamp' >= $bounceValidPeriod

This will be evaluated as a bool. Needs to be something more like

'br_timestamp >= ' . $bounceValidPeriod

Also a missing space after 'br_user'

Version: unspecified
Severity: normal

Details

Reference: bz72686

Related Objects
Search...

Status	Subtype	Assigned	Task
Invalid		None	T99444 Valid email address was unconfirmed for temporary spam blacklisting
Resolved		None	T104871 Mails from tools are being marked as 'spam' by gmail
Invalid		None	T54915 HTML email notifications caught by spam filters
Declined		• chasemp	T61731 mailman emails taking long time for delivery, getting stuck in sodium
Resolved		• chasemp	T58414 Get mail relay out of Yahoo! blacklist: apply to Yahoo for whitelisting bulk mail
Open	Feature	None	T58062 Notify user of mail bounces
Resolved		01tonythomas	T48640 Add proper email bounce handling to MediaWiki (with VERP)
Resolved		01tonythomas	T71019 Review and deploy BounceHandler extension to Wikimedia wikis
Resolved		01tonythomas	T74686 BounceHandlerActions::handleFailingRecipient() SQL query

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:45 AM

• bzimport added a project: MediaWiki-extensions-BounceHandler.

• bzimport set Reference to bz72686.

Reedy created this task.Oct 29 2014, 5:26 PM

(In reply to Sam Reed (reedy) from comment #0)

array(
				'br_user'=> $originalEmail,
				'br_timestamp' >= $bounceValidPeriod
			),
'br_timestamp' >= $bounceValidPeriod

This will be evaluated as a bool. Needs to be something more like

'br_timestamp >= ' . $bounceValidPeriod

Just please quote $bounceValidPeriod if you're writing the sql yourself

(In reply to Chris Steipp from comment #1)

(In reply to Sam Reed (reedy) from comment #0)
array(
				'br_user'=> $originalEmail,
				'br_timestamp' >= $bounceValidPeriod
			),
'br_timestamp' >= $bounceValidPeriod

This will be evaluated as a bool. Needs to be something more like

'br_timestamp >= ' . $bounceValidPeriod
Just please quote $bounceValidPeriod if you're writing the sql yourself

Aaron already did :) https://gerrit.wikimedia.org/r/#/c/169760/

And broke the tests :D

gerritadmin wrote:

Change 170290 had a related patch set uploaded by 01tonythomas:
Fixed DB timestamp range query in BounceHandler extension

https://gerrit.wikimedia.org/r/170290