Page MenuHomePhabricator

BounceHandlerActions::handleFailingRecipient() SQL query
Closed, ResolvedPublic

Description

array(

				'br_user'=> $originalEmail,
				'br_timestamp' >= $bounceValidPeriod
			),

'br_timestamp' >= $bounceValidPeriod

This will be evaluated as a bool. Needs to be something more like

'br_timestamp >= ' . $bounceValidPeriod

Also a missing space after 'br_user'


Version: unspecified
Severity: normal

Details

Reference
bz72686

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:45 AM
bzimport set Reference to bz72686.
Reedy created this task.Oct 29 2014, 5:26 PM

(In reply to Sam Reed (reedy) from comment #0)

array(

				'br_user'=> $originalEmail,
				'br_timestamp' >= $bounceValidPeriod
			),

'br_timestamp' >= $bounceValidPeriod
This will be evaluated as a bool. Needs to be something more like
'br_timestamp >= ' . $bounceValidPeriod

Just please quote $bounceValidPeriod if you're writing the sql yourself

(In reply to Chris Steipp from comment #1)

(In reply to Sam Reed (reedy) from comment #0)

array(

				'br_user'=> $originalEmail,
				'br_timestamp' >= $bounceValidPeriod
			),

'br_timestamp' >= $bounceValidPeriod
This will be evaluated as a bool. Needs to be something more like
'br_timestamp >= ' . $bounceValidPeriod

Just please quote $bounceValidPeriod if you're writing the sql yourself

Aaron already did :) https://gerrit.wikimedia.org/r/#/c/169760/

And broke the tests :D

gerritadmin wrote:

Change 170290 had a related patch set uploaded by 01tonythomas:
Fixed DB timestamp range query in BounceHandler extension

https://gerrit.wikimedia.org/r/170290

gerritadmin wrote:

Change 170290 merged by jenkins-bot:
Fixed DB timestamp range query in BounceHandler extension

https://gerrit.wikimedia.org/r/170290