Page MenuHomePhabricator
Create Task
Maniphest T74971

If the input for the redirect in the meta dialog is invalid, as well as show a red outline, block the user from closing the dialog with a prompt to fix it
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This task is about VisualEditor. See its user guide for general information.

In the VisualEditor, click the ≡ icon, click "Options", and choose "Page Settings".
If someone puts an invalid page name / page title in the "Target page for redirection" field (like the page name "Talk:" or a page name with a pipe character | in it), and tries to apply the changes, an exception is caused and the editor is locked up.

The "Apply Changes" button should be disabled when the input is not valid (like in e.g. the "Insert ➙ Media" dialog when file dimensions are invalid).

You are expected to provide a patch in Wikimedia Gerrit. See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit.

Details

Reference
bz72971
SubjectRepoBranchLines +/-
Blocked apply if redirect address is invalidmediawiki/extensions/VisualEditormaster+61 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:46 AM
• bzimport added a project: VisualEditor-EditingTools.
• bzimport set Reference to bz72971.
Catrope created this task.Nov 4 2014, 8:24 PM
Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 4:30 PM
Krenair added a project: VisualEditor-MediaWiki.Jan 16 2015, 3:06 AM
Krenair subscribed.
Krenair added a comment.Jan 21 2015, 1:41 AM
#REDIRECT [[MediaWiki:Badtitletext]]
Krenair added a comment.Jan 21 2015, 1:43 AM

I was testing with characters like <>, pipes, etc.

#REDIRECT [[Talk:]]

comes up for "Talk:", but gets rendered as a numbered list element with a broken link by the MW parser.

Krenair added a comment.Jan 21 2015, 1:54 AM

So I looked into the code - MWTitleInputWidget (used for redirects and templates) vs. MWLinkTargetInputWidget (links)
I think a lot of the request/response handling code in MWLinkTargetInputWidget should probably be shared, it shows a lot of things in the result like title validity ('legality'), existence of the exact query, external links, exact matches, etc.

Krenair added a comment.Jul 27 2015, 10:23 PM

Right now it shows the red outline around the textbox when you try to do this. Do we want to block it from saving somehow? Show a warning and automatically set it back to the previous value?

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2015, 10:23 PM
Jdforrester-WMF added a comment.Sep 15 2015, 7:24 PM
In T74971#1486465, @Krenair wrote:

Right now it shows the red outline around the textbox when you try to do this. Do we want to block it from saving somehow? Show a warning and automatically set it back to the previous value?

Sounds good.

Jdforrester-WMF renamed this task from VisualEditor: Handle invalid input for redirect title in meta dialog to If the input for the redirect in the meta dialog is invalid, as well as show a red outline block the user from closing the dialog with a prompt to fix it.Sep 15 2015, 7:25 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF removed a project: VisualEditor-EditingTools.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Krenair renamed this task from If the input for the redirect in the meta dialog is invalid, as well as show a red outline block the user from closing the dialog with a prompt to fix it to If the input for the redirect in the meta dialog is invalid, as well as show a red outline, block the user from closing the dialog with a prompt to fix it.Sep 15 2015, 7:54 PM
matmarex subscribed.Oct 23 2018, 4:40 AM

This is still a problem. Typing in an invalid page title (e.g. "A<B") and trying to apply the changes causes an exception and locks up the editor. The button should be disabled when the inputs are not valid (like in e.g. the media dialog when file dimensions are invalid).

matmarex added a project: Google-Code-in-2018.Oct 23 2018, 4:40 AM

I would like to mentor this task in Google-Code-in-2018.

matmarex added a subtask: T207719: The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled.Oct 23 2018, 4:45 AM
Aklapper updated the task description. (Show Details)Oct 23 2018, 1:25 PM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.

https://codein.withgoogle.com/tasks/5265052258009088/

matmarex updated the task description. (Show Details)Oct 23 2018, 4:08 PM
gerritbot subscribed.Oct 31 2018, 9:23 PM

Change 470914 had a related patch set uploaded (by Flutterish; owner: Flutterish):
[mediawiki/extensions/VisualEditor@master] Blocked apply if redirect address is invalid

https://gerrit.wikimedia.org/r/470914

gerritbot added a project: Patch-For-Review.Oct 31 2018, 9:23 PM
Jdforrester-WMF assigned this task to Flutterish.Nov 1 2018, 10:11 PM
Jdforrester-WMF edited projects, added VisualEditor (Current work); removed Patch-For-Review, VisualEditor.
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Nov 1 2018, 10:17 PM

Change 470914 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Blocked apply if redirect address is invalid

https://gerrit.wikimedia.org/r/470914

matmarex closed this task as Resolved.Nov 1 2018, 10:24 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 1 2018, 10:24 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 1 2018, 11:00 PM
matmarex closed subtask T207719: The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled as Resolved.Nov 2 2018, 12:03 AM
• Elitre unsubscribed.Nov 8 2018, 4:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL