Page MenuHomePhabricator
Create Task
Maniphest T75289

PrefixSearchTest::testSearch fails on PostgreSQL
Open, LowPublic
Actions

Description

From my newest PHPUnit run:

fix', 'Ex', array('Example', 'Example/Baz', 'Example Bar')))
Main namespace with title prefix
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'Example'
-    1 => 'Example/Baz'
-    2 => 'Example Bar'
+    1 => 'Example Bar'
+    2 => 'Example/Baz'
 )

phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/Constraint/IsEqual.php:170
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/Assert.php:2134
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/Assert.php:475
/usr/home/saper/public_html/pg/w/tests/phpunit/includes/PrefixSearchTest.php:138
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestCase.php:976
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestCase.php:831
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestResult.php:648
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestCase.php:776
/usr/home/saper/public_html/pg/w/tests/phpunit/MediaWikiTestCase.php:141
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestSuite.php:775
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestSuite.php:745
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestSuite.php:705
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestSuite.php:705
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/Framework/TestSuite.php:705
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/TextUI/TestRunner.php:349
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/TextUI/Command.php:176
phar:///usr/share/php/phpunit/phpunit.phar/PHPUnit/TextUI/Command.php:129
/usr/share/php/phpunit/phpunit.phar:531

Freshly installed empty wiki via the commandline installer

Version: 1.25-git
Severity: normal

Details

Reference
bz73289

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNikerabbitT32323 PrefixSearch: Add support for multiple namespaces
InvalidNoneT2384 [REPLACED BY TAG] PostgreSQL/pgsql support (tracking)
OpenNoneT75289 PrefixSearchTest::testSearch fails on PostgreSQL
· · ·

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:50 AM
• bzimport added a project: MediaWiki-Search.
• bzimport set Reference to bz73289.
• bzimport added a subscriber: Unknown Object (MLST).
saper created this task.Nov 12 2014, 1:40 AM
Aklapper added a comment.Nov 12 2014, 1:53 AM
  • Bug 73288 has been marked as a duplicate of this bug. ***
Umherirrender added a project: MediaWiki-Core-Tests.Jan 3 2015, 12:12 PM
Umherirrender subscribed.
Umherirrender unsubscribed.Jan 18 2015, 7:42 PM
Aklapper triaged this task as Low priority.Mar 18 2015, 11:34 AM
Aklapper subscribed.
Danny_B merged a task: T75288: PrefixSearchTest::testSearch fails on PostgreSQL.Jul 30 2016, 8:57 PM
Danny_B added a subscriber: Krinkle.
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptJul 30 2016, 8:57 PM
• debt removed projects: Discovery-Search, Discovery-ARCHIVED.Aug 4 2016, 5:08 PM
• debt subscribed.

removing discovery team tags

• debt added a comment.Aug 4 2016, 5:09 PM

This isn't something that the discovery team supports.

Krinkle unsubscribed.Aug 4 2016, 6:54 PM
Jdforrester-WMF added a project: PostgreSQL.Nov 2 2016, 8:15 PM
Jdforrester-WMF subscribed.

Migrating from the old tracking task to a tag for PostgreSQL-related tasks.

Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:14 AM
Krinkle closed this task as a duplicate of T75174: Make PHPUnit tests pass with PHP 5.5/PostgreSQL on Travis CI.
aaron updated the task description. (Show Details)Dec 10 2024, 2:21 AM
aaron reopened this task as Open.Dec 10 2024, 2:23 AM
aaron subscribed.

I still have this probably locally and have for years. There is probably some bad assumption that some postgres sort/collation default will have a certain value.

aaron added a comment.Apr 24 2025, 2:46 AM

It's interesting that "/" sorts before " " in mysql/sqlite and the test assertions.

In terms of the title prefix searching in PrefixSearch, it just uses the same page table query for all rdbms engines. Sqlite uses BLOB, Mysql uses VARBINARY for the title field, and Postgres uses TEXT. For storage of binary columns containing utf8 strings, I'm not sure why sqlite/mysql sorts "/" before " " . The mysql server and db collations are latin1_swedish_ci, but that should not matter for varbinary columns. Since these test strings come in as utf8 and are stored with binary encoding+collation as varbinary, I'd expect ' ' to use code point x20 and '/' to use x2F. Yet the later sorts first from the ORDER BY and the tests expect that (so it passes for mysql/sqlite). I feel like there is some hidden collating going on...

My postgres locale info, triggered via the package installer invoking initdb, is:

postgres=# \l
                                                        List of databases
   Name    |  Owner   | Encoding | Locale Provider |   Collate   |    Ctype    | ICU Locale | ICU Rules |    Access privileges    
-----------+----------+----------+-----------------+-------------+-------------+------------+-----------+-------------------------
 my_wiki   | postgres | UTF8     | libc            | fr_FR.UTF-8 | fr_FR.UTF-8 |            |           | =Tc/postgres           +
           |          |          |                 |             |             |            |           | postgres=CTc/postgres  +
           |          |          |                 |             |             |            |           | "www-data"=CTc/postgres
 postgres  | postgres | UTF8     | libc            | fr_FR.UTF-8 | fr_FR.UTF-8 |            |           | 
 template0 | postgres | UTF8     | libc            | fr_FR.UTF-8 | fr_FR.UTF-8 |            |           | =c/postgres            +
           |          |          |                 |             |             |            |           | postgres=CTc/postgres
 template1 | postgres | UTF8     | libc            | fr_FR.UTF-8 | fr_FR.UTF-8 |            |           | =c/postgres            +
           |          |          |                 |             |             |            |           | postgres=CTc/postgres

Forcing the db to use en_US.UTF-8 and use template0 did not change anything for postgres.

Note that in terms of content searching, sqlite uses CLOB (TEXT affinity, not BLOB) in searchindex, mysql specifically uses DEFAULT CHARSET = utf8mb4 in searchindex, while postgres does not searchindex but rather pagecontent directly, which uses TEXT.

TheDJ moved this task from Backlog to MySQL/Postgres/SQLite search on the MediaWiki-Search board.Sep 6 2025, 9:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits