Not sure if it'll work fine as is (it has getRealmSpecificFilename() calls in). Or at worst, we'll just have a few extra bad entries...
Description
Description
Details
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | jayvdb | T100796 Run pywikibot tests on beta wikis | |||
Resolved | Krenair | T75906 Check/update dumpInterwiki for beta usage |
Event Timeline
Comment Actions
I guess this load of hardcoded urls needs something doing about
/** * Returns an array of multi-language sites * db suffix => db suffix, iw prefix, hostname * @returns array */ protected function getSites() { return array( 'wiki' => new WMFSite( 'wiki', 'w', 'wikipedia.org' ), 'wiktionary' => new WMFSite( 'wiktionary', 'wikt', 'wiktionary.org' ), 'wikiquote' => new WMFSite( 'wikiquote', 'q', 'wikiquote.org' ), 'wikibooks' => new WMFSite( 'wikibooks', 'b', 'wikibooks.org' ), 'wikinews' => new WMFSite( 'wikinews', 'n', 'wikinews.org' ), 'wikisource' => new WMFSite( 'wikisource', 's', 'wikisource.org' ), 'wikimedia' => new WMFSite( 'wikimedia', 'chapter', 'wikimedia.org' ), 'wikiversity' => new WMFSite( 'wikiversity', 'v', 'wikiversity.org' ), 'wikivoyage' => new WMFSite( 'wikivoyage', 'voy', 'wikivoyage.org' ), ); } /** * Returns an array of extra global interwiki links that can't be in the * intermap for some reason * @returns array */ protected function getExtraLinks() { return array( array( 'm', $this->urlprotocol . '//meta.wikimedia.org/wiki/$1', 1 ), array( 'meta', $this->urlprotocol . '//meta.wikimedia.org/wiki/$1', 1 ), array( 'sep11', $this->urlprotocol . '//sep11.wikipedia.org/wiki/$1', 1 ), array( 'd', $this->urlprotocol . '//www.wikidata.org/wiki/$1', 1 ), ); } /** * Additional links to provide for the needs of the different projects * @param string $project The site (e.g. wikibooks) * @returns array */ protected function getAdditionalLinks( $project ) { switch( $project ) { case 'wikisource': return array( array( 'mul', $this->urlprotocol . '//wikisource.org/wiki/$1', 1 ), ); case 'wikiversity': return array( array( 'mul', $this->urlprotocol . '//beta.wikiversity.org/wiki/$1', 1 ), ); case 'wiki': return array( array( 'w', $this->urlprotocol . '//en.wikipedia.org/wiki/$1', 1 ), ); default: return array(); } }
Comment Actions
Change 225234 had a related patch set uploaded (by Alex Monk):
dumpInterwiki: Set links in beta to beta hostnames rather than prod
Comment Actions
Okay. Unfortunately changing task priorities is not usually going to help convince people to review code.
Comment Actions
Change 225234 merged by jenkins-bot:
dumpInterwiki: Set links in beta to beta hostnames rather than prod