Page MenuHomePhabricator
Create Task
Maniphest T76718

Gray bar on top of Special:CX
Closed, ResolvedPublic
Actions

Description

pasted_file (633×897 px, 141 KB)

The element has id mwe-popups-svg.

Details

SubjectRepoBranchLines +/-
Hide gray bar artifact on top of CX pagesmediawiki/extensions/ContentTranslationmaster+9 -1
Re-position #mwe-popups-svg out of the view portmediawiki/extensions/Popupsmaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Dec 4 2014, 2:36 PM
Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added projects: ContentTranslation, Language-Team.
Nikerabbit changed Security from none to None.
Nikerabbit subscribed.
Arrbee added projects: ContentTranslation-Release3, LE-Sprint-81.Dec 10 2014, 7:54 AM
Arrbee moved this task from Backlog to Sprint 81 on the ContentTranslation-Release3 board.Dec 10 2014, 12:27 PM
santhosh closed this task as Invalid.Dec 23 2014, 10:13 AM
santhosh claimed this task.

Not able to reproduce now. See screenshot of http://es.wikipedia.beta.wmflabs.org/wiki/Special:ContentTranslation

pasted_file (289×1 px, 72 KB)

Nikerabbit reopened this task as Open.EditedDec 23 2014, 10:40 AM

It's still there for me. I went to http://es.wikipedia.beta.wmflabs.org/wiki/Especial:ContentTranslation, logged in, and did Ctrl+R to refresh before it appeared. You might also need to try with different beta features enabled.

Arrbee triaged this task as Low priority.Dec 23 2014, 2:08 PM
Arrbee removed a project: LE-Sprint-81.
gerritbot added a project: Patch-For-Review.Dec 24 2014, 9:08 AM

Change 181721 had a related patch set uploaded (by Pginer):
Hide gray bar artifact on top of CX pages

https://gerrit.wikimedia.org/r/181721

Patch-For-Review

Pginer-WMF added a project: Page-Previews.Dec 24 2014, 9:52 AM
Pginer-WMF added subscribers: • Prtksxna, Pginer-WMF.

It seems that Page-Previews (a.k.a Hovercards) is adding a div with id=mwe-popups-svg which pushes content down, and affects Content Translation layout.

@Prtksxna, would it be possible to keep the element from doing that (e.g., setting its style to "display:none" until is needed)?

gerritbot added a comment.Dec 29 2014, 9:16 AM

Change 182058 had a related patch set uploaded (by Prtksxna):
Re-position #mwe-popups-svg out of the view port

https://gerrit.wikimedia.org/r/182058

Patch-For-Review

• Prtksxna claimed this task.Dec 29 2014, 9:19 AM
• Prtksxna added a subscriber: santhosh.
gerritbot added a comment.Jan 6 2015, 9:14 AM

Change 182058 merged by jenkins-bot:
Re-position #mwe-popups-svg out of the view port

https://gerrit.wikimedia.org/r/182058

• Prtksxna mentioned this in rEPOPf7d5f890b6a8: Re-position #mwe-popups-svg out of the view port.Jan 6 2015, 9:37 AM
santhosh closed this task as Resolved.Jan 6 2015, 9:49 AM
gerritbot added a comment.Jan 6 2015, 9:51 AM

Change 181721 abandoned by Pginer:
Hide gray bar artifact on top of CX pages

Reason:
It was fixed upstream

https://gerrit.wikimedia.org/r/181721

RandomDSdevel awarded a token.Mar 4 2015, 7:56 PM
Diffusion mentioned this in rMEXT2ffe1f86d598: Updated mediawiki/extensions Project: mediawiki/extensions/Popups….Mar 11 2015, 6:23 AM
Quiddity moved this task from Backlog to Done on the Page-Previews board.Mar 28 2015, 1:16 AM
• Petar.petkovic removed a project: Patch-For-Review.Jul 30 2019, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits