Page MenuHomePhabricator
Create Task
Maniphest T78202

Wordbreak detection is faulty for selection starting just down-page of a single character
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Steps to reproduce:

1.Open a page with VE
2.Place a cursor after a text like "sub-heading 1"
3.Open the link inspector

Observe that the character 1 is not getting selected and the link inspector is opening at the end of the line

Screen_Shot_2014-12-10_at_2.39.01_PM.png (198×367 px, 16 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[BREAKING CHANGE] Use Unicode character class to calculate word expansionsVisualEditor/VisualEditormaster+101 -29
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Dec 10 2014, 10:39 PM
Ryasmeen assigned this task to Esanders.
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen changed Security from none to None.
Ryasmeen subscribed.
Ryasmeen added a project: VisualEditor.Dec 10 2014, 11:10 PM
Jdforrester-WMF triaged this task as Medium priority.Dec 11 2014, 7:05 PM
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.
Mooeypoo added a project: Utilities-UnicodeJS.Jan 9 2015, 11:12 PM
Mooeypoo subscribed.

I spoke to David about this issue, there is definitely something off about how we account for word boundary and wordbreaks.

Mooeypoo added a subscriber: dchan.Jan 9 2015, 11:13 PM
Jdforrester-WMF mentioned this in T86399: Wordbreak detection is faulty for selection starting just up-page of a link annotation.Jan 10 2015, 3:40 AM
Jdforrester-WMF renamed this task from Placing the cursor at the end of a character and clicking on link inspector icon does not select that character to Wordbreak detection is faulty for selection starting just down-page of a single character.Jan 10 2015, 3:42 AM
Jdforrester-WMF reassigned this task from Esanders to dchan.Jan 15 2015, 1:24 AM
Jdforrester-WMF moved this task from External and Administrivia to Blocked on the VisualEditor board.
Esanders added a comment.Jan 15 2015, 4:42 PM

The word break calculation is correct:

Subheading1

But our word expansion logic avoids wrapping single length ranges due to the following cases:

DoubleSpace
中國人
Jdforrester-WMF subscribed.Feb 5 2015, 2:27 AM

UnicodeJS change was released in v0.1.3, which is now in VisualEditor core master following https://gerrit.wikimedia.org/r/188729 – what's next?

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Feb 10 2015, 8:40 PM
Jdforrester-WMF edited a custom field.Feb 10 2015, 9:04 PM
Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 11 2015, 8:25 PM
• Elitre subscribed.Feb 11 2015, 8:26 PM
• MZMcBride subscribed.Feb 11 2015, 8:29 PM
Jdforrester-WMF raised the priority of this task from Medium to High.Mar 18 2015, 1:11 AM
gerritbot subscribed.Mar 18 2015, 5:05 PM

Change 197661 had a related patch set uploaded (by Divec):
WIP: BREAKING CHANGE: Use unicode character class to calculate word expansions

https://gerrit.wikimedia.org/r/197661

gerritbot added a project: Patch-For-Review.Mar 18 2015, 5:05 PM
gerritbot added a comment.Mar 19 2015, 1:16 AM

Change 197661 merged by jenkins-bot:
[BREAKING CHANGE] Use Unicode character class to calculate word expansions

https://gerrit.wikimedia.org/r/197661

Jdforrester-WMF closed this task as Resolved.Mar 19 2015, 1:24 AM
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-25_(1.25wmf23); removed Patch-For-Review.
Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 19 2015, 1:43 AM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 20 2015, 11:29 PM
dchan mentioned this in rGVED80d68eabd064: [BREAKING CHANGE] Use Unicode character class to calculate word expansions.Mar 23 2015, 3:53 PM
Ryasmeen added a comment.Mar 26 2015, 12:39 AM

Verified the fix in Betalabs and test2

Ryasmeen added a project: Verified-in-Phase0.Mar 26 2015, 12:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits