Page MenuHomePhabricator
Create Task
Maniphest T78727

Investigate and fix OOMs caused during account globalization
Closed, ResolvedPublic
Actions

Description

Was causing OOMs and disabled due to T75462. Need to fix whatever was causing that and then turn it back on.

Blocked on HHVM deployment, HHVM folks please check logs and update this task's status when that happens.

Details

SubjectRepoBranchLines +/-
Try to verify emails before testing passwordsmediawiki/extensions/CentralAuthwmf/1.25wmf14+17 -13
Try to verify emails before testing passwordsmediawiki/extensions/CentralAuthwmf/1.25wmf13+17 -13
Try to verify emails before testing passwordsmediawiki/extensions/CentralAuthmaster+17 -13
Only test passwords once in CentralAuthUser::prepareMigrationmediawiki/extensions/CentralAuthwmf/1.25wmf13+8 -5
Only test passwords once in CentralAuthUser::prepareMigrationmediawiki/extensions/CentralAuthwmf/1.25wmf14+8 -5
Only test passwords once in CentralAuthUser::prepareMigrationmediawiki/extensions/CentralAuthmaster+8 -5
Reduce Password object creations needed for an account mergemediawiki/extensions/CentralAuthwmf/1.25wmf14+104 -50
Reduce Password object creations needed for an account mergemediawiki/extensions/CentralAuthwmf/1.25wmf13+104 -50
Reduce Password object creations needed for an account mergemediawiki/extensions/CentralAuthmaster+104 -50
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Dec 16 2014, 11:54 PM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: MediaWiki-Core-Team, SUL-Finalization, MediaWiki-extensions-CentralAuth.
Legoktm changed Security from none to None.
Legoktm mentioned this in T75462: Certain users are unable to log into their account (HTTP 503 upon login attempt).
Legoktm subscribed.
Keegan subscribed.Dec 17 2014, 11:26 PM
Nemo_bis subscribed.Dec 18 2014, 8:30 AM

Do we know how many users were merged thanks to $wgCentralAuthAutoMigrate?

Legoktm added a comment.Dec 19 2014, 10:58 PM
In T78727#931822, @Nemo_bis wrote:

Do we know how many users were merged thanks to $wgCentralAuthAutoMigrate?

legoktm@fluorine:/a/mw-log/archive$ zgrep "wgCentralAuthAutoMigrate successful" centralauth.log-2014* | wc -l
14684

And the earliest logs we still have are from 20140910.

Legoktm claimed this task.Dec 22 2014, 10:27 PM
Legoktm moved this task from Backlog to In Dev/Progress on the MediaWiki-Core-Team board.
hoo mentioned this in rECAU723dd4ea933c: Split $wgCentralAuthAutoMigrate into two settings.Jan 3 2015, 11:30 PM
Legoktm added a comment.Jan 7 2015, 11:05 PM

It appears that the OOMs can be reproduced by visiting Special:MergeAccount directly, as seen in https://en.wikipedia.org/wiki/User_talk:Hoary#Global_account which has an associated OOM log entry for their centralauth logs.

Legoktm renamed this task from Re-enable $wgCentralAuthAutoMigrate = true to Investigate and fix OOMs caused during account globalization.Jan 7 2015, 11:07 PM
Legoktm triaged this task as High priority.
DerHexer subscribed.Jan 7 2015, 11:26 PM
Legoktm removed Legoktm as the assignee of this task.Jan 8 2015, 12:14 AM

[16:02:31] <hoo> I talked with _joe_ about that earlier
[16:02:40] <hoo> the pending HHVM update will probably fix it

Nemo_bis assigned this task to Joe.Jan 8 2015, 8:59 AM
Nemo_bis updated the task description. (Show Details)
Nemo_bis added a project: HHVM.
Joe added a comment.Jan 8 2015, 5:34 PM

Actually, if the bug is related to an OOM I doubt the new package would fix that.

The fix would be for cases where the user login fails because of a wrong timezone

Joe removed Joe as the assignee of this task.Jan 8 2015, 5:34 PM
hoo subscribed.Jan 8 2015, 5:37 PM
gerritbot added a project: Patch-For-Review.Jan 8 2015, 6:34 PM

Change 183554 had a related patch set uploaded (by Hoo man):
Reduce Password object creations needed for an account merge

https://gerrit.wikimedia.org/r/183554

Patch-For-Review

gerritbot added a comment.Jan 8 2015, 9:05 PM

Change 183554 merged by jenkins-bot:
Reduce Password object creations needed for an account merge

https://gerrit.wikimedia.org/r/183554

Legoktm mentioned this in rECAU727f8517ccd2: Reduce Password object creations needed for an account merge.Jan 8 2015, 9:05 PM
gerritbot added a comment.Jan 8 2015, 11:05 PM

Change 183714 had a related patch set uploaded (by Hoo man):
Reduce Password object creations needed for an account merge

https://gerrit.wikimedia.org/r/183714

Patch-For-Review

gerritbot added a comment.Jan 8 2015, 11:06 PM

Change 183715 had a related patch set uploaded (by Hoo man):
Reduce Password object creations needed for an account merge

https://gerrit.wikimedia.org/r/183715

Patch-For-Review

gerritbot added a comment.Jan 8 2015, 11:10 PM

Change 183715 merged by jenkins-bot:
Reduce Password object creations needed for an account merge

https://gerrit.wikimedia.org/r/183715

hoo mentioned this in rECAU25b499c5f82f: Reduce Password object creations needed for an account merge.Jan 8 2015, 11:10 PM
gerritbot added a comment.Jan 8 2015, 11:11 PM

Change 183714 merged by jenkins-bot:
Reduce Password object creations needed for an account merge

https://gerrit.wikimedia.org/r/183714

hoo mentioned this in rECAUc40eb549956d: Reduce Password object creations needed for an account merge.Jan 8 2015, 11:11 PM
gerritbot added a comment.Jan 9 2015, 12:01 PM

Change 183832 had a related patch set uploaded (by Hoo man):
Only test passwords once in CentralAuthUser::prepareMigration

https://gerrit.wikimedia.org/r/183832

Patch-For-Review

gerritbot added a comment.Jan 9 2015, 5:28 PM

Change 183832 merged by jenkins-bot:
Only test passwords once in CentralAuthUser::prepareMigration

https://gerrit.wikimedia.org/r/183832

hoo mentioned this in rECAUe9e5e785678e: Only test passwords once in CentralAuthUser::prepareMigration.Jan 9 2015, 5:29 PM
gerritbot added a comment.Jan 12 2015, 5:12 PM

Change 184373 had a related patch set uploaded (by Hoo man):
Only test passwords once in CentralAuthUser::prepareMigration

https://gerrit.wikimedia.org/r/184373

Patch-For-Review

gerritbot added a comment.Jan 12 2015, 5:12 PM

Change 184374 had a related patch set uploaded (by Hoo man):
Only test passwords once in CentralAuthUser::prepareMigration

https://gerrit.wikimedia.org/r/184374

Patch-For-Review

gerritbot added a comment.Jan 12 2015, 5:16 PM

Change 184374 merged by jenkins-bot:
Only test passwords once in CentralAuthUser::prepareMigration

https://gerrit.wikimedia.org/r/184374

gerritbot added a comment.Jan 12 2015, 5:17 PM

Change 184373 merged by jenkins-bot:
Only test passwords once in CentralAuthUser::prepareMigration

https://gerrit.wikimedia.org/r/184373

hoo mentioned this in rECAUc4d4b613a9db: Only test passwords once in CentralAuthUser::prepareMigration.Jan 12 2015, 5:20 PM
hoo mentioned this in rECAUb8cd8623ad9f: Only test passwords once in CentralAuthUser::prepareMigration.
gerritbot added a comment.Jan 12 2015, 7:20 PM

Change 184407 had a related patch set uploaded (by Hoo man):
Try to verify emails before testing passwords

https://gerrit.wikimedia.org/r/184407

Patch-For-Review

Legoktm moved this task from In Dev/Progress to Needs Review/Feedback on the MediaWiki-Core-Team board.Jan 12 2015, 10:30 PM
gerritbot added a comment.Jan 12 2015, 10:40 PM

Change 184407 merged by jenkins-bot:
Try to verify emails before testing passwords

https://gerrit.wikimedia.org/r/184407

Legoktm mentioned this in rECAUc98932862048: Try to verify emails before testing passwords.Jan 12 2015, 10:40 PM
gerritbot added a comment.Jan 12 2015, 11:28 PM

Change 184510 had a related patch set uploaded (by Hoo man):
Try to verify emails before testing passwords

https://gerrit.wikimedia.org/r/184510

Patch-For-Review

gerritbot added a comment.Jan 12 2015, 11:28 PM

Change 184511 had a related patch set uploaded (by Hoo man):
Try to verify emails before testing passwords

https://gerrit.wikimedia.org/r/184511

Patch-For-Review

gerritbot added a comment.Jan 12 2015, 11:31 PM

Change 184510 merged by jenkins-bot:
Try to verify emails before testing passwords

https://gerrit.wikimedia.org/r/184510

hoo mentioned this in rECAUa19dba6be68d: Try to verify emails before testing passwords.Jan 12 2015, 11:31 PM
gerritbot added a comment.Jan 12 2015, 11:31 PM

Change 184511 merged by jenkins-bot:
Try to verify emails before testing passwords

https://gerrit.wikimedia.org/r/184511

hoo mentioned this in rECAU6a675c9bf373: Try to verify emails before testing passwords.Jan 12 2015, 11:31 PM
hoo edited projects, added Upstream; removed Patch-For-Review.Jan 13 2015, 5:49 PM

I'm fairly sure now that https://github.com/facebook/hhvm/issues/3740 hits us over here.

Krenair subscribed.Jan 14 2015, 1:42 AM
bd808 added subscribers: bd808, swtaarrs.Jan 14 2015, 6:26 PM

@swtaarrs has a patch upstream that may be the true fix for this (https://github.com/facebook/hhvm/commit/fd41d2001042bf208864da0d08e3dd96a52e43f5). He found that the ^= operator was adding an extra reference to the internal string object that kept it from being GC'd.

On irc he said that a cherry-pick to our fork would only need to take the runtime/base/tv-arith.cpp changes.

ori mentioned this in T86813: Cherry-pick and deploy fd41d20010 from facebook/hhvm.Jan 14 2015, 8:22 PM
• Elitre subscribed.Jan 16 2015, 6:01 PM
Trijnstel subscribed.Jan 17 2015, 4:15 PM
Liuxinyu970226 subscribed.Jan 20 2015, 9:34 AM
Keegan mentioned this in T73241: Run sendConfirmAndMigrateEmail.php for all unconfirmed emails on all wikis.Jan 28 2015, 9:37 PM
Joe closed subtask T86813: Cherry-pick and deploy fd41d20010 from facebook/hhvm as Resolved.Feb 4 2015, 12:44 PM
hoo closed this task as Resolved.Feb 4 2015, 1:59 PM
hoo claimed this task.

Should be good now.

Liuxinyu970226 unsubscribed.Feb 4 2015, 2:04 PM
bd808 moved this task from Needs Review/Feedback to Done on the MediaWiki-Core-Team board.Feb 5 2015, 1:57 AM
bd808 moved this task from Done to Archive on the MediaWiki-Core-Team board.
Keegan moved this task from It's complicated to Done on the SUL-Finalization board.Feb 18 2015, 7:26 PM
Legoktm mentioned this in rOMWC53b953ace060: Re-enable wgCentralAuthAutoMigrate.Mar 3 2015, 9:01 PM
Diffusion mentioned this in rMEXT432f23bd1c5d: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….Mar 11 2015, 6:23 AM
hoo mentioned this in rMEXT5455de77b880: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….Mar 11 2015, 6:23 AM
hoo mentioned this in rMEXT985ac999cd4f: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….
hoo mentioned this in rMEXT900c42ab225d: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….
Krenair moved this task from Backlog to Patch merged upstream on the Upstream board.Mar 29 2015, 8:32 PM
RandomDSdevel awarded a token.Mar 29 2015, 9:22 PM
MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.May 5 2015, 5:50 PM
PleaseStand mentioned this in T74221: hash_init leaks memory in hhvm, impacting performance of pbkdf2.Aug 25 2015, 7:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL