Page MenuHomePhabricator

Navigating via Tab between fields in TransclusionCitation boxes switches to the Find/Replace fields in the background
Closed, ResolvedPublic

Description

In betalabs:

  1. On a page in VE open Find/Replace - not typing anything in it, just open - a cursor will be in the Find field.
  2. Open an existing template on the page for editing.
  3. Place a cursor in the first field of the transclusion box and click Tab to navigate to the next field.

The cursor will be placed into Replace field; clicking Tab one more time brings the cursor back into Transclusion box.

The same issue is with Citation.

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a project: VisualEditor.
Etonkovidova changed Security from none to None.
Etonkovidova subscribed.

The find and replace dialog also sets tabindexes... Guess the transclusion dialog is setting the same indexes.

So we could work out the current highest tabindex in the page and then add it to all our tabindexes in the template dialog. Which is horrible.

Or I wonder if we should really just have the info button next to the parameter name and the remove button immediately following the value field, or something. Then the actual order of the elements might be logical and we could remove the tabindexes.

Or maybe listen for events to make sure things focus in the order I wanted, or something

matmarex claimed this task.
matmarex subscribed.

It seems that I fixed this in 2015 with this change to use natural tab order: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/243527.