Page MenuHomePhabricator

Wikimedia global user rights log entry did not get updated in global rename
Open, MediumPublic

Event Timeline

Krenair assigned this task to Legoktm.
Krenair raised the priority of this task from to Needs Triage.
Krenair updated the task description. (Show Details)
Krenair changed Security from none to None.
Krenair added subscribers: Krenair, Spage, Jalexander.

So I think this is actually a larger question with global renames. We had the same issue with a globally locked account being renamed. The lock itself was transferred from Account A to Account A (Usurped) but the log entry did not.

Example: original account name with lock log (now owned by someone else) usurped account with the lock correctly transferred but no log entry.

Aklapper triaged this task as Medium priority.Dec 22 2014, 5:14 PM
Glaisher added a subscriber: Glaisher.

This is an issue with local renames itself.
When doing a rename:

UPDATE `logging` SET log_title = 'NewUser' WHERE log_type IN ('block','newusers','rights','renameuser') AND log_namespace = '2' AND log_title = 'OldUser'

and those log_types are from SpecialLog::getLogTypesOnUser() which doesn't know about CentralAuth's logs. It does have GetLogTypesOnUser hook but the problem is CentralAuth's logs are too weird. In gblrights, all changes to global groups and wikisets are also logged in addition to global user rights changes. In globalauth log also we've those @global stuff. I guess we can't use that hook here.

Why global renamers is not a global group??

Why global renamers is not a global group??

We don't want people to be able to globally rename from every wiki.

We don't want people to be able to globally rename from every wiki.

That is somehow a strange interpretation what is a global group, to see a "unconfirmed" user in local logs doing this. This group has only global change rights. Than a proper name would be:
Hidden global group

dmehus added a subscriber: Reception123.

Adding User-RhinosF1 project and moving on that workboard to Miraheze Linked, as we're quite curious when this bug will be fixed. All local log entries have the performers and targets updated following a global rename, so why not global log entries, such as the global rights log?

Adding @Reception123 per request on IRC.