UniversalLanguageSelector patches are blocked by voting schema tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Amire80
	Dec 22 2014, 8:06 AM

Description

For example, https://gerrit.wikimedia.org/r/#/c/181386/ :

07:33:36 The module 'schema.UniversalLanguageSelector' required by 'ext.uls.eventlogger' must exist
07:33:36 Failed asserting that an array contains 'schema.UniversalLanguageSelector'.

It's either an issue in ULS or in Jenkins, and I'm inclined to think that it's the latter. AFAIK, ULS registers its schema correctly using the EventLoggingRegisterSchemas hook, and not by registering a module explicitly. If I am right, then the job must be made non-voting until it's fixed to support this way of registering schemas.

Details

	Subject	Repo	Branch	Lines +/-
	ULS depends on EventLogging	integration/config	master	+4 -3

Customize query in gerrit

Related Objects

Mentioned In: T85664: CI tests fail for Translate extension patches
rCICF538e963a2e3c: ULS depends on EventLogging

Event Timeline

Amire80 created this task.Dec 22 2014, 8:06 AM

Amire80 raised the priority of this task from to Unbreak Now!.

Amire80 updated the task description. (Show Details)

Amire80 added projects: MediaWiki-extensions-EventLogging, Continuous-Integration-Infrastructure.

Amire80 changed Security from none to None.

Amire80 added subscribers: Amire80, KartikMistry.

Arrbee added a project: ContentTranslation-Deployments.Dec 22 2014, 8:24 AM

KartikMistry added a subscriber: hashar.Dec 22 2014, 8:26 AM

hashar removed a project: Continuous-Integration-Infrastructure.Dec 22 2014, 9:58 AM

The extension has bad resource loader definitions. You can reproduce on your local setup using:

cd tests/phpunit
php phpunit --testsuite structure

That is being run for all extensions since last week: https://lists.wikimedia.org/pipermail/wikitech-l/2014-December/079864.html

So looking quickly at ULS, it depends on a RL module schema.UniversalLanguageSelector which is not in the extension. That is for EventLogging so we have to add it as a dependency.

Change 181400 had a related patch set uploaded (by Hashar):
ULS depends on EventLogging

https://gerrit.wikimedia.org/r/181400

Patch-For-Review

As I said, AFAIK the schema in ULS is loaded correctly using the hook, with the technique described here:
https://phabricator.wikimedia.org/diffusion/EEVL/browse/master/includes/EventLoggingHooks.php;9522a747e665ef8d5229ccfb71363f7a1aff9597$46

If such usage is deprecated, we can update it, but I'd prefer not to change it without a good reason.

The problem is the Jenkins job does not clone the EventLogging extension when preparing the tests for ULS. The Gerrit patch above fix that dependency requirement.

Aklapper added a subscriber: greg.Dec 22 2014, 12:56 PM

Looks good to me now. Thank you.

Amire80 closed this task as Resolved.Dec 22 2014, 1:32 PM

Amire80 assigned this task to hashar.

Change 181400 merged by jenkins-bot:
ULS depends on EventLogging

https://gerrit.wikimedia.org/r/181400

Amire80 awarded a token.Dec 22 2014, 1:44 PM

hashar mentioned this in rCICF538e963a2e3c: ULS depends on EventLogging.Dec 31 2014, 6:28 PM

Amire80 mentioned this in T85664: CI tests fail for Translate extension patches.Jan 1 2015, 2:24 PM

hashar moved this task from Untriaged to Done on the Continuous-Integration-Infrastructure board.Jan 15 2015, 9:41 PM

Jdforrester-WMF removed a project: Patch-For-Review.Mar 3 2015, 5:27 PM

santhosh moved this task from Backlog to Done on the ContentTranslation-Deployments board.Apr 20 2015, 7:24 AM