Maniphest T85778

Misaligned icon on configuration button
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Jan 5 2015, 1:13 AM

Tags

Referenced Files

	F26573: Screen_Shot_2015-01-05_at_00.53.40.png
	Jan 5 2015, 1:13 AM

Subscribers

Jdforrester-WMF

Tokens

"Like" token, awarded by RandomDSdevel.

Description

https://commons.wikimedia.org/wiki/File:Prefeito_Pereira_Passos.jpg

Details

	Subject	Repo	Branch	Lines +/-
	Remove the 'top' definition from .mw-ui-icon-element:before	mediawiki/core	master	+0 -1

Customize query in gerrit

Related Objects

Mentioned In: T142391: Mobile web search x clear button masked at its bottom
rMW54f2cbd04296: Remove the 'top' definition from .mw-ui-icon-element:before

Event Timeline

Krinkle created this task.Jan 5 2015, 1:13 AM

Krinkle raised the priority of this task from to Needs Triage.

Krinkle updated the task description. (Show Details)

Krinkle added projects: MediaViewer, Regression.

Krinkle added subscribers: Krinkle, Jdforrester-WMF.

Seems to be a mediawiki.ui issue, you can see it in the styleguide as well: https://tools.wmflabs.org/styleguide/desktop/section-6.html#section-6.1

• Gilles added a project: Multimedia.Jan 6 2015, 3:37 PM

Change introduced in https://gerrit.wikimedia.org/r/#/c/177092/

Change 183176 had a related patch set uploaded (by Prtksxna):
Remove the 'top' definition from mw-ui-icon-element's pseduo element

https://gerrit.wikimedia.org/r/183176

Patch-For-Review

• Prtksxna claimed this task.Jan 7 2015, 12:54 AM

• Prtksxna triaged this task as Medium priority.

• Prtksxna removed a project: Patch-For-Review.

• Prtksxna set Security to None.

• Prtksxna added a project: Patch-For-Review.

• Prtksxna moved this task from Unsorted to Doing… on the UI-Standardization board.Jan 7 2015, 12:58 AM

Change 183176 merged by jenkins-bot:
Remove the 'top' definition from .mw-ui-icon-element:before

https://gerrit.wikimedia.org/r/183176

matmarex mentioned this in rMW54f2cbd04296: Remove the 'top' definition from .mw-ui-icon-element:before.Jan 7 2015, 2:21 PM

• Prtksxna closed this task as Resolved.Jan 7 2015, 2:26 PM

• Prtksxna moved this task from Doing… to Done on the UI-Standardization board.

Patch was reverted by @Jdlrobson

This patchset was reverted in change: https://gerrit.wikimedia.org/r/183298

This broke mobile alpha
http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=alpha#/editor/0
Look at cog and back button

Patchset was not reverted in end. We found a better fix in MobileFrontend... (Am I missing something?)

RandomDSdevel awarded a token.Jan 12 2015, 11:09 PM

Danny_B moved this task from Done to Unsorted on the UI-Standardization board.May 23 2016, 7:02 AM

Restricted Application added a subscriber: Matanya. · View Herald TranscriptMay 23 2016, 7:02 AM

• bmansurov mentioned this in T142391: Mobile web search x clear button masked at its bottom.Aug 10 2016, 8:51 PM